Skip to contentSkip to conversation

Let ath10k_err take 'ar' argument?

DISCUSSION Ben Greear 2 participants 3 messages Mar 6, 2014 – Mar 7, 2014 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

I have two NICs in a system, and it died overnight (full host lockup). Console shows this:

[root@ct523-9292 ~]# ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5

I was thinking of changing ath10k_err to take 'ar' as argument and then print out pci-id or some other identifier so that we can tell which NIC is having issues on systems with multiple NICs?

Any opinions on this before I get started?

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 6 lines · Ben Greear

I have two NICs in a system, and it died overnight (full host lockup). Console shows this:

[root@ct523-9292 ~]# ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled

Damn. Do you have anything before the target stalled message?

Quoted 6 lines

I was thinking of changing ath10k_err to take 'ar' as argument and then print out pci-id or some other identifier so that we can tell which NIC is having issues on systems with multiple NICs?

Any opinions on this before I get started?

I have been thinking exactly the same. I think we should add struct ath10k to all of our logging and debugging macros. IIRC iwlwifi does this already, you might want to check that first.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#2 lore raw
Quoted 10 lines · Kalle Valo
Quoted 6 lines · Ben Greear

I have two NICs in a system, and it died overnight (full host lockup). Console shows this:

[root@ct523-9292 ~]# ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled

Damn. Do you have anything before the target stalled message?

No, nothing useful.

I reproduced this on WLE900VX as well (and posted a week or so about it).

Well, the one above is from system with two different NICs (CUS223, WLE900VX) so not sure exactly which one had the issue...

Quoted 10 lines
Quoted 6 lines

I was thinking of changing ath10k_err to take 'ar' as argument and then print out pci-id or some other identifier so that we can tell which NIC is having issues on systems with multiple NICs?

Any opinions on this before I get started?

I have been thinking exactly the same. I think we should add struct ath10k to all of our logging and debugging macros. IIRC iwlwifi does this already, you might want to check that first.

I'll take a stab at it today if I can find time.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k