Skip to contentSkip to conversation

module: LLVMLinux: Remove unused function warning from __param_check macro

PATCH Superseded [email protected] 5 participants 12 messages Mar 7, 2014 – Mar 17, 2014 Module support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: LLVMLinux: Remove unused function warning from __param_check macro

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

I believe GCC won't complain for a static inline fuction but would if it was just a static function.

Adding the unused attribute to the function declaration removes the warning.

This code works for both gcc and clang.

---
 include/linux/moduleparam.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/moduleparam.h +1 -0
index c3eb102..5ce1f67 100644
@@ -346,6 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
+	static inline type *__check_##name(void) __attribute__ ((unused)); \
 	static inline type *__check_##name(void) { return(p); }
 
 extern struct kernel_param_ops param_ops_byte;
Signature · 1 line
1.8.3.2
#1 lore raw

include/linux/moduleparam.h static inline void destroy_params(const struct kernel_param *params, · line 350

Quoted 10 lines · On 7 Mar 2014 at 11:08, [email protected] wrote:
include/linux/moduleparam.h +1 -0
index c3eb102..5ce1f67 100644
@@ -346,6 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
+	static inline type *__check_##name(void) __attribute__ ((unused)); \
 	static inline type *__check_##name(void) { return(p); }

why can't you have the attr on the definition itself:

static inline __unused type *__check_##name(void) { return(p); }

#2 lore raw
Quoted 14 lines · PaX Team

include/linux/moduleparam.h static inline void destroy_params(const struct kernel_param *params, · line 350

Quoted 10 lines · On 7 Mar 2014 at 11:08, [email protected] wrote:
include/linux/moduleparam.h +1 -0
index c3eb102..5ce1f67 100644
@@ -346,6 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
  /* The macros to do compile-time type checking stolen from Jakub
     Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
  #define __param_check(name, p, type) \
+	static inline type *__check_##name(void) __attribute__ ((unused)); \
  	static inline type *__check_##name(void) { return(p); }

why can't you have the attr on the definition itself:

Quoted 4 lines

static inline __unused type *__check_##name(void) { return(p); }

"__unused" isn't defined anywhere I can find, except in:

src/linux/drivers/net/ethernet/amd/declance.c:#define __unused __attribute__ ((unused))

But this does work.

- static inline type *__check_##name(void) { return(p); }
+ static inline __attribute__((unused)) \
+ type *__check_##name(void) { return(p); }

If this is preferred, I will resubmit.

Behan

Signature · 2 lines
Behan Webster
[email protected]
#3 lore raw
Quoted 11 lines · Behan Webster
Quoted 6 lines · PaX Team

why can't you have the attr on the definition itself:

static inline __unused type *__check_##name(void) { return(p); }

"__unused" isn't defined anywhere I can find, except in:

src/linux/drivers/net/ethernet/amd/declance.c:#define __unused __attribute__ ((unused))

oh i forgot about that, you'd of course place this #define into the appropriate compiler*.h files so that other code can make use of it in the future as well ;).

#4 lore raw
Quoted 9 lines · PaX Team
Quoted 7 lines · Behan Webster
Quoted 6 lines · PaX Team

why can't you have the attr on the definition itself:

static inline __unused type *__check_##name(void) { return(p); }

Quoted 8 lines
Quoted 4 lines

"__unused" isn't defined anywhere I can find, except in:

src/linux/drivers/net/ethernet/amd/declance.c:#define __unused __attribute__ ((unused))

oh i forgot about that, you'd of course place this #define into the appropriate compiler*.h files so that other code can make use of it in the future as well ;).

It looks like it already exists, __always_unused.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
#5 lore raw

PATCH v2 1/1 module: LLVMLinux: Remove unused function warning from __param_check macro

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

I believe GCC won't complain for a static inline fuction but would if it was just a static function.

Adding the unused attribute to the function definition removes the warning.

This code works for both gcc and clang.

---
 include/linux/moduleparam.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/moduleparam.h +1 -1
index c3eb102..7f2a726 100644
@@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
-	static inline type *__check_##name(void) { return(p); }
+	static inline __always_unused type *__check_##name(void) { return(p); }
 
 extern struct kernel_param_ops param_ops_byte;
 extern int param_set_byte(const char *val, const struct kernel_param *kp);
Signature · 1 line
1.8.3.2
#6 lore raw
Quoted 2 lines · On Fri, 2014-03-07 at 18:10 -0800, [email protected] wrote:

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

[]

include/linux/moduleparam.h

Quoted 1 line
include/linux/moduleparam.h +0 -0

[]

include/linux/moduleparam.h static inline void destroy_params(const struct kernel_param *params, · line 349

Quoted 6 lines
include/linux/moduleparam.h +1 -1
@@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
-	static inline type *__check_##name(void) { return(p); }
+	static inline __always_unused type *__check_##name(void) { return(p); }

Perhaps __maybe_unused ?

#7 lore raw
Quoted 6 lines · Joe Perches
Quoted 2 lines · On Fri, 2014-03-07 at 18:10 -0800, [email protected] wrote:

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

[]

include/linux/moduleparam.h

Quoted 1 line
include/linux/moduleparam.h +0 -0

[]

Quoted 7 lines

include/linux/moduleparam.h static inline void destroy_params(const struct kernel_param *params, · line 349

Quoted 6 lines
include/linux/moduleparam.h +1 -1
@@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
  /* The macros to do compile-time type checking stolen from Jakub
     Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
  #define __param_check(name, p, type) \
-	static inline type *__check_##name(void) { return(p); }
+	static inline __always_unused type *__check_##name(void) { return(p); }

Perhaps __maybe_unused ?

I thought about that (and even tested with __maybe_unused), but I *think* they are always unused, except at compile time (see comment above). Though I could be wrong.

I'm certainly okay with __maybe_unused if that is preferable.

Behan

Signature · 2 lines
Behan Webster
[email protected]
#8 lore raw
In reply to [email protected]
Quoted 8 lines · [email protected] writes:

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

I believe GCC won't complain for a static inline fuction but would if it was just a static function.

Quoted 6 lines

Adding the unused attribute to the function declaration removes the warning.

This code works for both gcc and clang.

Please include the actual warning clang spits out. That helps because
(1) I know what you're referring to, and
(2) it helps others if they are later googling for the error.

I don't have any huge objections to this patch (__always_unused) though.

Thanks,
Rusty.

#9 lore raw
Quoted 11 lines · Rusty Russell
Quoted 10 lines · [email protected] writes:

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.

I believe GCC won't complain for a static inline fuction but would if it was just a static function.

Adding the unused attribute to the function declaration removes the warning.

Quoted 7 lines
Quoted 4 lines

This code works for both gcc and clang.

Please include the actual warning clang spits out. That helps because
(1) I know what you're referring to, and
(2) it helps others if they are later googling for the error.

Nice! Will fix.

Quoted 1 line

I don't have any huge objections to this patch (__always_unused) though.

Already in the posted v2 patch.

However I will post a v3 with your other suggested changes to the commit message.

Thanks,

Behan

Signature · 2 lines
Behan Webster
[email protected]
#10 lore raw

PATCH v3 1/1 module: LLVMLinux: Remove unused function warning from __param_check macro

In reply to Rusty Russell

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function:

linux/kernel/panic.c:471:1: warning: unused function '__check_panic'
[-Wunused-function]
core_param(panic, panic_timeout, int, 0644);
^
linux/moduleparam.h:283:2: note: expanded from macro

      'core_param'
        param_check_##type(name, &(var));                               \
        ^

<scratch space>:87:1: note: expanded from here param_check_int
^
linux/moduleparam.h:369:34: note: expanded from macro
'param_check_int'

#define param_check_int(name, p) __param_check(name, p, int)
                                 ^
linux/moduleparam.h:349:22: note: expanded from macro
      '__param_check'
        static inline type *__check_##name(void) { return(p); }
                            ^

<scratch space>:88:1: note: expanded from here
__check_panic

GCC won't complain for a static inline function but would if it was just a static function.

Adding the unused attribute to the function declaration removes the warning. Per request from Rusty Russell it is marked as __always_unused as the code is meant to be optimized away.

This code works for both GCC and clang.

---
 include/linux/moduleparam.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/moduleparam.h +1 -1
index c3eb102..175f699 100644
@@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
-	static inline type *__check_##name(void) { return(p); }
+	static inline type __always_unused *__check_##name(void) { return(p); }
 
 extern struct kernel_param_ops param_ops_byte;
 extern int param_set_byte(const char *val, const struct kernel_param *kp);
Signature · 1 line
1.8.3.2
#11 lore raw
Quoted 4 lines · [email protected] writes:

From: Mark Charlebois <[email protected]>

This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function:

Thanks, applied.

Cheers,
Rusty.

Quoted 53 lines

linux/kernel/panic.c:471:1: warning: unused function '__check_panic'
[-Wunused-function]
core_param(panic, panic_timeout, int, 0644);
^
linux/moduleparam.h:283:2: note: expanded from macro

      'core_param'
        param_check_##type(name, &(var));                               \
        ^

<scratch space>:87:1: note: expanded from here param_check_int
^
linux/moduleparam.h:369:34: note: expanded from macro
'param_check_int'

#define param_check_int(name, p) __param_check(name, p, int)
                                 ^
linux/moduleparam.h:349:22: note: expanded from macro
      '__param_check'
        static inline type *__check_##name(void) { return(p); }
                            ^

<scratch space>:88:1: note: expanded from here
__check_panic

GCC won't complain for a static inline function but would if it was just a static function.

Adding the unused attribute to the function declaration removes the warning. Per request from Rusty Russell it is marked as __always_unused as the code is meant to be optimized away.

This code works for both GCC and clang.

---
 include/linux/moduleparam.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/moduleparam.h +1 -1
index c3eb102..175f699 100644
@@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
 /* The macros to do compile-time type checking stolen from Jakub
    Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
 #define __param_check(name, p, type) \
-	static inline type *__check_##name(void) { return(p); }
+	static inline type __always_unused *__check_##name(void) { return(p); }
 
 extern struct kernel_param_ops param_ops_byte;
 extern int param_set_byte(const char *val, const struct kernel_param *kp);
Signature · 1 line
1.8.3.2