Skip to contentSkip to conversation

Makefile: about allmodconfig issue.

Suggestion Chen Gang 2 participants 10 messages Mar 8, 2014 – Mar 16, 2014 GPIO

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

Hello All:

"A module selects GENERIC_IRQ_CHIP and depend on IRQ_DOMAIN". For me, it is a reasonable selection and dependency, but "make allmodconfig" will report error. I guess it is the "Makefile allmodconfig" issue.

The related error report:

[root@gchen linux-next]# make ARCH=avr32 CROSS_COMPILE=/usr/local/bin/avr32-linux- allmodconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf --allmodconfig Kconfig
kernel/time/Kconfig:162:warning: range is invalid
kernel/irq/Kconfig:41:error: recursive dependency detected! kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP

The related commit (7779b34 gpio: add a driver for the Synopsys DesignWare APB GPIO block):

+config GPIO_DWAPB

  +       tristate "Synopsys DesignWare APB GPIO driver"
  +       select GPIO_GENERIC
  +       select GENERIC_IRQ_CHIP
  +       depends on OF_GPIO && IRQ_DOMAIN

Welcome any suggestions, discussions and completions.

Thanks.

Signature · 3 lines
Chen Gang

Open, share and attitude like air, water and life which God blessed
#1 lore raw
Quoted 34 lines · Chen Gang

Hello All:

"A module selects GENERIC_IRQ_CHIP and depend on IRQ_DOMAIN". For me, it is a reasonable selection and dependency, but "make allmodconfig" will report error. I guess it is the "Makefile allmodconfig" issue.

The related error report:

[root@gchen linux-next]# make ARCH=avr32 CROSS_COMPILE=/usr/local/bin/avr32-linux- allmodconfig
HOSTCC scripts/basic/fixdep
HOSTCC scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf --allmodconfig Kconfig
kernel/time/Kconfig:162:warning: range is invalid
kernel/irq/Kconfig:41:error: recursive dependency detected! kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP

The related commit (7779b34 gpio: add a driver for the Synopsys DesignWare APB GPIO block):

+config GPIO_DWAPB

  +       tristate "Synopsys DesignWare APB GPIO driver"
  +       select GPIO_GENERIC
  +       select GENERIC_IRQ_CHIP
  +       depends on OF_GPIO && IRQ_DOMAIN
Quoted 4 lines

Welcome any suggestions, discussions and completions.

Thanks.

A patch has already been submitted and applied by the subsystem maintainer.

http://marc.info/?l=linux-gpio&m=139413626320431&w=2

Signature · 1 line
~Randy
author
#2 lore raw
Quoted 1 line · Randy Dunlap

On 03/08/2014 05:07 AM, Chen Gang wrote:

[...]

Quoted 10 lines
Quoted 4 lines

Welcome any suggestions, discussions and completions.

Thanks.

A patch has already been submitted and applied by the subsystem maintainer.

http://marc.info/?l=linux-gpio&m=139413626320431&w=2

OK, Thanks. And excuse me, I can not connect to this web site in China.

Could you please past the patch contents in the reply mail? (or just let me know whether it is "make allmodconfig" issue, or only gpio driver's issue)

Thanks.

Signature · 3 lines
Chen Gang

Open, share and attitude like air, water and life which God blessed
#3 lore raw
Quoted 14 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/08/2014 05:07 AM, Chen Gang wrote:

[...]

Quoted 10 lines
Quoted 4 lines

Welcome any suggestions, discussions and completions.

Thanks.

A patch has already been submitted and applied by the subsystem maintainer.

http://marc.info/?l=linux-gpio&m=139413626320431&w=2

Quoted 8 lines

OK, Thanks. And excuse me, I can not connect to this web site in China.

Could you please past the patch contents in the reply mail? (or just let me know whether it is "make allmodconfig" issue, or only gpio driver's issue)

Thanks.

It's a gpio driver Kconfig patch -- not an allmodconfig issue.

Here is the patch:

From: Alan Tull <[email protected]>

fix build error with this message:
kernel/irq/Kconfig:41:error: recursive dependency detected! kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP

---
 drivers/gpio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 9979017..0e524d7 100644
@@ -132,7 +132,7 @@ config GPIO_DWAPB
 	tristate "Synopsys DesignWare APB GPIO driver"
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
-	depends on OF_GPIO && IRQ_DOMAIN
+	depends on OF_GPIO
 	help
 	  Say Y or M here to build support for the Synopsys DesignWare APB
 	  GPIO block.
Signature · 2 lines
-- 
~Randy
author
#4 lore raw
Quoted 17 lines · Randy Dunlap
Quoted 16 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/08/2014 05:07 AM, Chen Gang wrote:

[...]

Quoted 10 lines
Quoted 4 lines

Welcome any suggestions, discussions and completions.

Thanks.

A patch has already been submitted and applied by the subsystem maintainer.

http://marc.info/?l=linux-gpio&m=139413626320431&w=2

OK, Thanks. And excuse me, I can not connect to this web site in China.

Quoted 9 lines
Quoted 6 lines

Could you please past the patch contents in the reply mail? (or just let me know whether it is "make allmodconfig" issue, or only gpio driver's issue)

Thanks.

It's a gpio driver Kconfig patch -- not an allmodconfig issue.

Can we say that the 'select' priority is higher or equal than 'depends on'? If we really can say so, we need change our gpio driver.

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Thanks.

Quoted 29 lines

Here is the patch:

From: Alan Tull <[email protected]>

fix build error with this message:
kernel/irq/Kconfig:41:error: recursive dependency detected! kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP

---
 drivers/gpio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 9979017..0e524d7 100644
@@ -132,7 +132,7 @@ config GPIO_DWAPB
 	tristate "Synopsys DesignWare APB GPIO driver"
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
-	depends on OF_GPIO && IRQ_DOMAIN
+	depends on OF_GPIO
 	help
 	  Say Y or M here to build support for the Synopsys DesignWare APB
 	  GPIO block.
Signature · 3 lines
Chen Gang

Open, share and attitude like air, water and life which God blessed
#5 lore raw
Quoted 23 lines · Chen Gang
Quoted 22 lines · Randy Dunlap
Quoted 21 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/08/2014 05:07 AM, Chen Gang wrote:

[...]

Quoted 10 lines
Quoted 4 lines

Welcome any suggestions, discussions and completions.

Thanks.

A patch has already been submitted and applied by the subsystem maintainer.

http://marc.info/?l=linux-gpio&m=139413626320431&w=2

OK, Thanks. And excuse me, I can not connect to this web site in China.

Could you please past the patch contents in the reply mail? (or just let me know whether it is "make allmodconfig" issue, or only gpio driver's issue)

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks.

It's a gpio driver Kconfig patch -- not an allmodconfig issue.

Can we say that the 'select' priority is higher or equal than 'depends on'? If we really can say so, we need change our gpio driver.

what driver is "our gpio driver"?

Documentation/kbuild/kconfig-language.txt does not talk about priorities of depends or select.

Quoted 7 lines

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

Quoted 7 lines

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Sorry, I don't really understand the problem that you are trying to solve. Maybe you could back up and explain the underlying problem... ?

Signature · 1 line
~Randy
author
#6 lore raw
Quoted 3 lines · Randy Dunlap
Quoted 2 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/08/2014 01:44 PM, Chen Gang wrote:

[...]

Quoted 6 lines
Quoted 3 lines

Can we say that the 'select' priority is higher or equal than 'depends on'? If we really can say so, we need change our gpio driver.

what driver is "our gpio driver"?

Only point to GPIO_DWAPB driver.

For me, if its full source code are in our upstream kernel, we need treat it as "our source code". So when we find an issue about it, we can also treat it as our issue.

Quoted 3 lines

Documentation/kbuild/kconfig-language.txt does not talk about priorities of depends or select.

OK, thanks, I will/should read it completely.

Quoted 11 lines
Quoted 11 lines

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Quoted 7 lines
Quoted 3 lines

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Sorry, I don't really understand the problem that you are trying to solve. Maybe you could back up and explain the underlying problem... ?

If the fix patch applied (don't depend on IRQ_DOMAIN), I guess, if one architecture don't support IRQ_DOMAIN, GPIO_DWAPB may still be enabled and then let IRQ_DOMAIN enable too.

Thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
author
#7 lore raw
Quoted 2 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/09/2014 08:02 AM, Chen Gang wrote:

[...]

Quoted 15 lines
Quoted 15 lines
Quoted 14 lines

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Quoted 8 lines
Quoted 3 lines

Sorry, I don't really understand the problem that you are trying to solve. Maybe you could back up and explain the underlying problem... ?

If the fix patch applied (don't depend on IRQ_DOMAIN), I guess, if one architecture don't support IRQ_DOMAIN, GPIO_DWAPB may still be enabled and then let IRQ_DOMAIN enable too.

Is it possible to still go further? For me, I still think, this is not gpio driver's issue, the kbuild need be improved to support this using case.

So, if it is necessary, I will/should try to go further about it.

Thanks.

Signature · 3 lines
Chen Gang

Open, share and attitude like air, water and life which God blessed
#8 lore raw
Quoted 28 lines · Chen Gang
Quoted 2 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/09/2014 08:02 AM, Chen Gang wrote:

[...]

Quoted 15 lines
Quoted 15 lines
Quoted 14 lines

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Quoted 8 lines
Quoted 3 lines

Sorry, I don't really understand the problem that you are trying to solve. Maybe you could back up and explain the underlying problem... ?

If the fix patch applied (don't depend on IRQ_DOMAIN), I guess, if one architecture don't support IRQ_DOMAIN, GPIO_DWAPB may still be enabled and then let IRQ_DOMAIN enable too.

Quoted 4 lines

Is it possible to still go further? For me, I still think, this is not gpio driver's issue, the kbuild need be improved to support this using case.

So, if it is necessary, I will/should try to go further about it.

If you can demonstrate a problem, then please submit a patch for it, but don't just hypothesize a problem, actually show that there is one.

Signature · 1 line
~Randy
author
#9 lore raw
Quoted 29 lines · Randy Dunlap
Quoted 28 lines · Chen Gang
Quoted 2 lines · Chen Gang
Quoted 1 line · Randy Dunlap

On 03/09/2014 08:02 AM, Chen Gang wrote:

[...]

Quoted 23 lines
Quoted 11 lines
Quoted 11 lines

Else ('depends on' priority is higher than 'select')

- some architectures can choose whether support IRQ_DOMAIN.

- if IRQ_DOMAIN enabled, our gpio driver can be used, and then select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN).

- else (IRQ_DOMAIN_disabled), we can not use our gpio driver, and also can not select GENERIC_IRQ_CHIP (need not consider about it selects IRQ_DOMAIN, either).

Quoted 7 lines
Quoted 3 lines

Excuse me, I am not quite familiar with Kconfig grammar, can any members give a confirmation for it (whether 'select' priority is higher or equal than 'depends on').

Sorry, I don't really understand the problem that you are trying to solve. Maybe you could back up and explain the underlying problem... ?

If the fix patch applied (don't depend on IRQ_DOMAIN), I guess, if one architecture don't support IRQ_DOMAIN, GPIO_DWAPB may still be enabled and then let IRQ_DOMAIN enable too.

Quoted 9 lines
Quoted 4 lines

Is it possible to still go further? For me, I still think, this is not gpio driver's issue, the kbuild need be improved to support this using case.

So, if it is necessary, I will/should try to go further about it.

If you can demonstrate a problem, then please submit a patch for it, but don't just hypothesize a problem, actually show that there is one.

We are discussing this gpio driver's issue, and also discussing one fix patch (remove IRQ_DOMAIN dependency).

For me, when discussing one patch (e.g. this fix patch), it is necessary for patch maker to provide proofs to clear all related doubts from any members (e.g. me).

And theoretically, 'kbuild' need support (implement correctly) the priority between 'select' and 'depends on', or it can not express all related features (although it can not cause real world issue, now).

Thanks.

Signature · 3 lines
Chen Gang

Open, share and attitude like air, water and life which God blessed