Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard
PATCH RESEND v4 1/1 Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
Thanks,
Shuduo
Quoted 1 line
From
b153a7b14791c6e01892c0e274e23eefd625fb8dMon Sep 17 00:00:00 2001
From: Shuduo Sang <[email protected]>
Date: Mon, 3 Mar 2014 14:29:32 +0800
Subject: [PATCH] support thinkpad X1 Carbon's adaptive keyboard
Thinkpad X1 Carbon's adaptive keyboard has five modes including Home mode, Web browser mode, Web conference mode, Function mode and Lay-flat mode. We support Home mode and Function mode currently.
--- drivers/platform/x86/thinkpad_acpi.c | 102 +++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)
(quoted diff) +0 -0
b/drivers/platform/x86/thinkpad_acpi.c
index defb6af..f4978fa 100644
drivers/platform/x86/thinkpad_acpi.c +102 -0
114 lines not on this page · raw message
Signature · 1 line
1.9.0
Hi!
Quoted 4 lines
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
As far as I can tell... thinkpad just has small display above its function keys (right?).
Would it be possible to support it as a display? (/dev/fb1)?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
A message that is not in the archive (sent off-list or not yet received): CA+BAWBSqF=tL9cRm2oDb3hRMxebFV69BrgzfTbcvaGjRfKnrMw@mail.gmail.com
Quoted 9 lines · Shuduo Sang
Quoted 7 lines · Pavel Machek
Hi!
Quoted 4 lines
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
Quoted 7 lines
Quoted 5 lines
As far as I can tell... thinkpad just has small display above its function keys (right?).
Would it be possible to support it as a display? (
/dev/fb1)?Not possible so far.
Can you elaborate?
Is the problem that hw only supports few fixed images for that display?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
A message that is not in the archive (sent off-list or not yet received): 20140331151258.GA8380-5NIqAleC692hcjWhqY66xCZi+YwRKgec@public.gmane.org
Quoted 14 lines · Pavel Machek
Quoted 10 lines · Shuduo Sang
Quoted 8 lines · Pavel Machek
Hi!
Quoted 4 lines
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
As far as I can tell... thinkpad just has small display above its
function
Quoted 2 lines
Quoted 2 lines
keys (right?).
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Would it be possible to support it as a display? (
/dev/fb1)?Not possible so far.
Can you elaborate?
Is the problem that hw only supports few fixed images for that display?
No such interface can do that.
Quoted 7 lines
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
------------------------------------------------------------------------------
_______________________________________________
ibm-acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Quoted 4 lines · Shuduo Sang
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
I am unable to do a full review right now, but we can always adjust minor details of the feature with later patches and the previous reviews did help clean up the feature.
However: as far as I am concerned, this is an experimental feature until it matures for a while. I'd rather we plug this somehow to the thinkpad-acpi input map, for example.
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
A message that is not in the archive (sent off-list or not yet received): 1396288189.17715.101062725.0503948F-2RFepEojUI2N1INw9kWLP6GC3tUn3ZHUQQ4Iyu8u01E@public.gmane.org
Quoted 6 lines · Henrique de Moraes Holschuh
Quoted 4 lines · Shuduo Sang
Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive keyboard.
Hi Henrique, could you please have a chance to review it?
Quoted 9 lines
I am unable to do a full review right now, but we can always adjust minor details of the feature with later patches and the previous reviews did help clean up the feature.
However: as far as I am concerned, this is an experimental feature until it matures for a while. I'd rather we plug this somehow to the thinkpad-acpi input map, for example.
Yes, I tried to use input map but worry old logic need change many since the new event number
is far to old. The functionality is verified well and get official recognised by Lenovo.
Quoted 2 lines
There are two more patches for X1 carbon adaptive keyboard need review.
[PATCH] save and restore adaptive keyboard mode for suspend and, resume [PATCH] support thinkpad HKEY interface version 0x200
They are verified by me and other X1 carbon users.
Thanks Henrique.
Quoted 7 lines
--
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
------------------------------------------------------------------------------
_______________________________________________
ibm-acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel