Skip to contentSkip to conversation

git config for spdk/qemu review

SPDK Young Tack Jin 2 participants 3 messages May 3, 2019 – May 4, 2019

lore
Share & tools
lore

Young Tack Jin

author
#0 lore raw

Hi all,

Could anyone help with how to configure git for spdk/qemu review?

SPDK Development guide works only for spdk/spdk review.

And my commit to spdk/rocksdb review has been pending so long.

Anyone of spdk core maintainers might resolve where this to go.

Thanks,

YT

#1 lore raw

Hi YT,

Configuration works similarly to spdk/spdk - just replace spdk/spdk with spdk/qemu in your .git/config. You'll also need to replace master with the name of the target QEMU branch.

I've just merged your spdk/rocksdb patch now. Apologies for the delay.

-Jim

On 5/2/19, 5:26 PM, "SPDK on behalf of Young Tack Jin" <spdk-bounces(a)lists.01.org on behalf of youngtack.jin(a)circuitblvd.com> wrote:

Hi all,

Could anyone help with how to configure git for spdk/qemu review?

SPDK Development guide works only for spdk/spdk review.

And my commit to spdk/rocksdb review has been pending so long.

Anyone of spdk core maintainers might resolve where this to go.

Thanks,

YT
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

author
#2 lore raw

Hi Jim,

Thanks for your time to merge rockdb commit.
I understand all core maintainers are super busy to review the bunch of spdk commits and could miss other repo's commits.

I'm seeing merge conflict for spdk/qemu with "git pull --all". But this works fine for spdk/spdk repo.
If without --all, git pull for spdk/qemu passed successfully.

This is not critical now to work on spdk/qemu repo. I think someone could investigate two repos' setup.

Regards,
YT

-----Original Message-----
From: SPDK <spdk-bounces(a)lists.01.org> On Behalf Of Harris, James R
Sent: Thursday, May 2, 2019 8:12 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: Re: [SPDK] git config for spdk/qemu review

Hi YT,

Configuration works similarly to spdk/spdk - just replace spdk/spdk with spdk/qemu in your .git/config. You'll also need to replace master with the name of the target QEMU branch.

I've just merged your spdk/rocksdb patch now. Apologies for the delay.

-Jim

On 5/2/19, 5:26 PM, "SPDK on behalf of Young Tack Jin" <spdk-bounces(a)lists.01.org on behalf of youngtack.jin(a)circuitblvd.com> wrote:

Hi all,

Could anyone help with how to configure git for spdk/qemu review?

SPDK Development guide works only for spdk/spdk review.

And my commit to spdk/rocksdb review has been pending so long.

Anyone of spdk core maintainers might resolve where this to go.

Thanks,

YT
_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk