Skip to contentSkip to conversation

Adding libstrophe

PATCH New Denis Bodor 2 participants 3 messages Mar 11, 2014 – Mar 12, 2014

lore
Share & tools
lore

Denis Bodor

author
#0 lore raw

PATCH 1/1 Adding libstrophe

Signed-off-by Denis Bodor <[email protected]>
---
 package/libstrophe/Config.in                            | 11 +++++++++++
 package/libstrophe/libstrophe-make-autoreconfable.patch |  9 +++++++++
 package/libstrophe/libstrophe.mk                        | 14 ++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/libstrophe/Config.in
 create mode 100644 package/libstrophe/libstrophe-make-autoreconfable.patch
 create mode 100644 package/libstrophe/libstrophe.mk
package/libstrophe/Config.in new file +11 -0
new file mode 100644
index 0000000..ac02a66
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBSTROPHE
+	bool "libstrophe"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_EXPAT
+	help
+	  libstrophe is a lightweight XMPP client library written in C.
+	  It has minimal dependencies and is configurable for various
+	  environments. It runs well on both Linux, Unix, and Windows
+	  based platforms.
+
+	  https://github.com/strophe/libstrophe
package/libstrophe/libstrophe-make-autoreconfable.patch new file +9 -0
new file mode 100644
index 0000000..5caeaff
@@ -0,0 +1,9 @@
+diff -ur libstrophe.orig/Makefile.am libstrophe/Makefile.am
+--- libstrophe.orig/Makefile.am	2014-03-02 18:58:36.219753865 +0100
++++ libstrophe/Makefile.am	2014-03-02 18:58:02.739752477 +0100
+@@ -1,4 +1,4 @@
+-AUTOMAKE_OPTIONS = subdir-objects
++AUTOMAKE_OPTIONS = subdir-objects foreign
+ 
+ CFLAGS = -g -Wall
+
package/libstrophe/libstrophe.mk new file +14 -0
new file mode 100644
index 0000000..356d3d4
@@ -0,0 +1,14 @@
+################################################################################
+# 
+# libstrophe
+#
+################################################################################
+
+LIBSTROPHE_VERSION = d408eaf2bbfe5ff5c56eab01463c278f9891c08e
+LIBSTROPHE_SITE = $(call github,strophe,libstrophe,$(LIBSTROPHE_VERSION))
+LIBSTROPHE_INSTALL_STAGING = YES
+LIBSTROPHE_INSTALL_TARGET = NO
+LIBSTROPHE_DEPENDENCIES = expat openssl host-pkgconf
+LIBSTROPHE_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/1 Adding libstrophe

Hi Denis,

Thank you for your contribution! It looks good, but I have a few remarks
below. Could you fix them and resubmit?

Quoted 5 lines · Denis Bodor
Signed-off-by Denis Bodor <[email protected]>
---
 package/libstrophe/Config.in                            | 11 +++++++++++
 package/libstrophe/libstrophe-make-autoreconfable.patch |  9 +++++++++
 package/libstrophe/libstrophe.mk                        | 14 ++++++++++++++

You forgot to add it to package/Config.in so it won't appear in the menu.

package/libstrophe/libstrophe-make-autoreconfable.patch

Quoted 27 lines
 3 files changed, 34 insertions(+)
 create mode 100644 package/libstrophe/Config.in
 create mode 100644 package/libstrophe/libstrophe-make-autoreconfable.patch
 create mode 100644 package/libstrophe/libstrophe.mk
package/libstrophe/Config.in new file +11 -0
new file mode 100644
index 0000000..ac02a66
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBSTROPHE
+	bool "libstrophe"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_EXPAT
+	help
+	  libstrophe is a lightweight XMPP client library written in C.
+	  It has minimal dependencies and is configurable for various
+	  environments. It runs well on both Linux, Unix, and Windows
+	  based platforms.
+
+	  https://github.com/strophe/libstrophe
package/libstrophe/libstrophe-make-autoreconfable.patch new file +0 -0
new file mode 100644
index 0000000..5caeaff

Patches should be numbered, e.g. libstrophe-01-make-autoreconfable.patch

Also, the patch should have a small "commit log" with your signed-off-by.

Quoted 16 lines
package/libstrophe/libstrophe-make-autoreconfable.patch new file +9 -0
@@ -0,0 +1,9 @@
+diff -ur libstrophe.orig/Makefile.am libstrophe/Makefile.am
+--- libstrophe.orig/Makefile.am	2014-03-02 18:58:36.219753865 +0100
++++ libstrophe/Makefile.am	2014-03-02 18:58:02.739752477 +0100
+@@ -1,4 +1,4 @@
+-AUTOMAKE_OPTIONS = subdir-objects
++AUTOMAKE_OPTIONS = subdir-objects foreign
+ 
+ CFLAGS = -g -Wall
+
package/libstrophe/libstrophe.mk new file +0 -0
new file mode 100644
index 0000000..356d3d4

package/libstrophe/libstrophe.mk line 10

Quoted 10 lines
package/libstrophe/libstrophe.mk new file +10 -0
@@ -0,0 +1,14 @@
+################################################################################
+# 
+# libstrophe
+#
+################################################################################
+
+LIBSTROPHE_VERSION = d408eaf2bbfe5ff5c56eab01463c278f9891c08e
+LIBSTROPHE_SITE = $(call github,strophe,libstrophe,$(LIBSTROPHE_VERSION))
+LIBSTROPHE_INSTALL_STAGING = YES
+LIBSTROPHE_INSTALL_TARGET = NO

I guess that's because it only builds a static library? Can you add a
comment that says that?

package/libstrophe/libstrophe.mk line 12

Quoted 2 lines
package/libstrophe/libstrophe.mk new file +2 -0
+LIBSTROPHE_DEPENDENCIES = expat openssl host-pkgconf
+LIBSTROPHE_AUTORECONF = YES

You're missing _LICENSE and _LICENSE_FILES.

Regards,
Arnout

Quoted 3 lines
package/libstrophe/libstrophe.mk new file +2 -0
+
+$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#2 lore raw

PATCH 1/1 Adding libstrophe

Le mercredi 12 mars 2014 ??? 08:08:26 (+0100), Arnout Vandecappelle a ?crit :

Quoted 1 line

Hi Denis,

Hi Arnout

Quoted 2 lines

Thank you for your contribution! It looks good, but I have a few remarks
below. Could you fix them and resubmit?

Of course.
Thanks for your help. New patch will follow soon.

Signature · 1 line
Denis