Skip to contentSkip to conversation

watchdog: fix ARCH_BCM_MOBILE dependency

PATCH In review Alex Elder 2 participants 3 messages Mar 12, 2014 – Mar 13, 2014 Watchdog device drivers

lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 watchdog: fix ARCH_BCM_MOBILE dependency

Starting with this commit:
047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
the meaning of the ARCH_BCM config option is changed to represent all Broadcom chips with code in the mach-bcm directory.

Configuration options related to specific Broadcom platforms should now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or ARCH_BCM_5301X).

The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM, but it should be ARCH_BCM_MOBILE instead. Fix that.

---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
index 79d2589..47a6f10 100644
@@ -1160,7 +1160,7 @@ config BCM2835_WDT
 
 config BCM_KONA_WDT
 	tristate "BCM Kona Watchdog"
-	depends on ARCH_BCM
+	depends on ARCH_BCM_MOBILE
 	select WATCHDOG_CORE
 	help
 	  Support for the watchdog timer on the following Broadcom BCM281xx
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 5 lines · Alex Elder

Starting with this commit:
047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
the meaning of the ARCH_BCM config option is changed to represent all Broadcom chips with code in the mach-bcm directory.

Quoted 8 lines

Configuration options related to specific Broadcom platforms should now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or ARCH_BCM_5301X).

The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM, but it should be ARCH_BCM_MOBILE instead. Fix that.

Hi Alex,

Markus Mayer already submitted a similar patch:

	http://patchwork.roeck-us.net/patch/1263/

Guenter

author
#2 lore raw
Quoted 13 lines · Guenter Roeck
Quoted 12 lines · Alex Elder

Starting with this commit:
047ef2fa rename ARCH_BCM to ARCH_BCM_MOBILE (clocksource)
the meaning of the ARCH_BCM config option is changed to represent all Broadcom chips with code in the mach-bcm directory.

Configuration options related to specific Broadcom platforms should now use another symbol (currently ARCH_BCM_MOBILE, ARCH_BCM2835, or ARCH_BCM_5301X).

The BCM_KONA_WDT config option indicates a dependency on ARCH_BCM, but it should be ARCH_BCM_MOBILE instead. Fix that.

Quoted 6 lines
Quoted 1 line

Hi Alex,

Markus Mayer already submitted a similar patch:

    http://patchwork.roeck-us.net/patch/1263/

Yes someone else pointed that out to me shortly after I sent mine. I wasn't aware he had done it. I discovered the problem independently today and just sent out the fix. Thanks.

-Alex