ARM: dts: overo: Add graphics output

PATCH Superseded Florian Vaussard 2 participants 8 messages Mar 11, 2014 – Mar 13, 2014 Device tree bindings

lore

Share & tools

lore

Florian Vaussard

author

2014-03-11 12:34 UTC #0 lore raw

cover ARM: dts: overo: Add graphics output

Hi,

This series enables the DVI / LCD graphics present on some of the Overo expansion boards.

DVI output:
- Tobi
- Summit

LCD (3.5''):
- Alto35

LCD (4.3''):
- Chestnut43
- Palo43
- Gallop43

I tested on Tobi, Alto35 and Gallop43 using both OMAP35xx and OMAP36xx Overo boards.

This series depends on Tomi's DSS patches [1] that are not yet merged. It also depends on previous Overo series [2] and [3] that are under review. A complete testing tree is available [4].

Regards,
Florian

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/295881
[2] http://thread.gmane.org/gmane.linux.ports.arm.omap/111558
[3] http://thread.gmane.org/gmane.linux.ports.arm.omap/111689
[4] https://github.com/vaussard/linux.git (overo/for-3.15/review1)

Florian Vaussard (3):
ARM: dts: overo: Add support for DVI output
ARM: dts: overo: Add support for 4.3'' LCD output
ARM: dts: overo: Add support for 3.5'' LCD output

 arch/arm/boot/dts/omap3-overo-alto35-common.dtsi   |   1 +
 .../boot/dts/omap3-overo-chestnut43-common.dtsi    |   1 +
 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi      | 109 +++++++++++++++
 arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi    | 145 ++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi    | 146 +++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-gallop43-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-palo43-common.dtsi   |   1 +
 arch/arm/boot/dts/omap3-overo-summit-common.dtsi   |   1 +
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi     |   1 +
 9 files changed, 406 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi

Signature · 1 line

1.8.3.2

Florian Vaussard

author

2014-03-11 12:34 UTC #1 lore raw

PATCH 1/3 ARM: dts: overo: Add support for DVI output

Summit and Tobi expansion boards have a HDMI connector with a TFP410 encoder. Add a common include file for this configuration, and then use it for Summit and Tobi.

Signed-off-by Florian Vaussard <[email protected]>

---
 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi    | 109 +++++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-summit-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi   |   1 +
 3 files changed, 111 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi

arch/arm/boot/dts/omap3-overo-common-dvi.dtsi new file +109 -0

new file mode 100644
index 0000000..6fb5d1e
@@ -0,0 +1,109 @@
+/*
+ * Copyright (C) 2014 Florian Vaussard, EPFL Mobots group
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/*
+ * DVI output for some Gumstix Overo boards (Tobi and Summit)
+ */
+
+&omap3_pmx_core {
+	i2c3_pins: pinmux_i2c3_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x21c2, PIN_INPUT | MUX_MODE0)	/* i2c3_scl.i2c3_scl */
+			OMAP3_CORE1_IOPAD(0x21c4, PIN_INPUT | MUX_MODE0)	/* i2c3_sda.i2c3_sda */
+		>;
+	};
+
+	dss_dpi_pins: pinmux_dss_dpi_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x20d4, PIN_OUTPUT | MUX_MODE0)	/* dss_pclk.dss_pclk */
+			OMAP3_CORE1_IOPAD(0x20d6, PIN_OUTPUT | MUX_MODE0)	/* dss_hsync.dss_hsync */
+			OMAP3_CORE1_IOPAD(0x20d8, PIN_OUTPUT | MUX_MODE0)	/* dss_vsync.dss_vsync */
+			OMAP3_CORE1_IOPAD(0x20da, PIN_OUTPUT | MUX_MODE0)	/* dss_acbias.dss_acbias */
+			OMAP3_CORE1_IOPAD(0x20dc, PIN_OUTPUT | MUX_MODE0)	/* dss_data0.dss_data0 */
+			OMAP3_CORE1_IOPAD(0x20de, PIN_OUTPUT | MUX_MODE0)	/* dss_data1.dss_data1 */
+			OMAP3_CORE1_IOPAD(0x20e0, PIN_OUTPUT | MUX_MODE0)	/* dss_data2.dss_data2 */
+			OMAP3_CORE1_IOPAD(0x20e2, PIN_OUTPUT | MUX_MODE0)	/* dss_data3.dss_data3 */
+			OMAP3_CORE1_IOPAD(0x20e4, PIN_OUTPUT | MUX_MODE0)	/* dss_data4.dss_data4 */
+			OMAP3_CORE1_IOPAD(0x20e6, PIN_OUTPUT | MUX_MODE0)	/* dss_data5.dss_data5 */
+			OMAP3_CORE1_IOPAD(0x20e8, PIN_OUTPUT | MUX_MODE0)	/* dss_data6.dss_data6 */
+			OMAP3_CORE1_IOPAD(0x20ea, PIN_OUTPUT | MUX_MODE0)	/* dss_data7.dss_data7 */
+			OMAP3_CORE1_IOPAD(0x20ec, PIN_OUTPUT | MUX_MODE0)	/* dss_data8.dss_data8 */
+			OMAP3_CORE1_IOPAD(0x20ee, PIN_OUTPUT | MUX_MODE0)	/* dss_data9.dss_data9 */
+			OMAP3_CORE1_IOPAD(0x20f0, PIN_OUTPUT | MUX_MODE0)	/* dss_data10.dss_data10 */
+			OMAP3_CORE1_IOPAD(0x20f2, PIN_OUTPUT | MUX_MODE0)	/* dss_data11.dss_data11 */
+			OMAP3_CORE1_IOPAD(0x20f4, PIN_OUTPUT | MUX_MODE0)	/* dss_data12.dss_data12 */
+			OMAP3_CORE1_IOPAD(0x20f6, PIN_OUTPUT | MUX_MODE0)	/* dss_data13.dss_data13 */
+			OMAP3_CORE1_IOPAD(0x20f8, PIN_OUTPUT | MUX_MODE0)	/* dss_data14.dss_data14 */
+			OMAP3_CORE1_IOPAD(0x20fa, PIN_OUTPUT | MUX_MODE0)	/* dss_data15.dss_data15 */
+			OMAP3_CORE1_IOPAD(0x20fc, PIN_OUTPUT | MUX_MODE0)	/* dss_data16.dss_data16 */
+			OMAP3_CORE1_IOPAD(0x20fe, PIN_OUTPUT | MUX_MODE0)	/* dss_data17.dss_data17 */
+			OMAP3_CORE1_IOPAD(0x2100, PIN_OUTPUT | MUX_MODE0)	/* dss_data18.dss_data18 */
+			OMAP3_CORE1_IOPAD(0x2102, PIN_OUTPUT | MUX_MODE0)	/* dss_data19.dss_data19 */
+			OMAP3_CORE1_IOPAD(0x2104, PIN_OUTPUT | MUX_MODE0)	/* dss_data20.dss_data20 */
+			OMAP3_CORE1_IOPAD(0x2106, PIN_OUTPUT | MUX_MODE0)	/* dss_data21.dss_data21 */
+			OMAP3_CORE1_IOPAD(0x2108, PIN_OUTPUT | MUX_MODE0)	/* dss_data22.dss_data22 */
+			OMAP3_CORE1_IOPAD(0x210a, PIN_OUTPUT | MUX_MODE0)	/* dss_data23.dss_data23 */
+		>;
+	};
+};
+
+&dss {
+	status = "ok";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&dss_dpi_pins
+		     &i2c3_pins>;
+
+	dpi_out: endpoint {
+		remote-endpoint = <&tfp410_in>;
+		data-lines = <24>;
+	};
+};
+
+/ {
+	aliases {
+		display0 = &dvi0;
+	};
+
+	tfp410: encoder at 0 {
+		compatible = "ti,tfp410";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+
+				tfp410_in: endpoint at 0 {
+					remote-endpoint = <&dpi_out>;
+				};
+			};
+
+			port at 1 {
+				reg = <1>;
+
+				tfp410_out: endpoint at 0 {
+					remote-endpoint = <&dvi_connector_in>;
+				};
+			};
+		};
+	};
+
+	dvi0: connector at 0 {
+		compatible = "dvi-connector";
+		label = "dvi";
+
+		i2c-bus = <&i2c3>;
+
+		dvi_connector_in: endpoint {
+			remote-endpoint = <&tfp410_out>;
+		};
+	};
+};
+

arch/arm/boot/dts/omap3-overo-summit-common.dtsi +1 -0

index 999d1cd..0ac97ba 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-dvi.dtsi"
 
 / {
 	leds {

arch/arm/boot/dts/omap3-overo-tobi-common.dtsi +1 -0

index 13df50b..9e24b6a 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-dvi.dtsi"
 
 / {
 	leds {

Signature · 1 line

1.8.3.2

Tomi Valkeinen

2014-03-12 07:11 UTC #2 lore raw

PATCH 1/3 ARM: dts: overo: Add support for DVI output

Quoted 11 lines · Florian Vaussard

Summit and Tobi expansion boards have a HDMI connector with a TFP410 encoder. Add a common include file for this configuration, and then use it for Summit and Tobi.
Signed-off-by Florian Vaussard <[email protected]>
---
 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi    | 109 +++++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-summit-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi   |   1 +
 3 files changed, 111 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi

<snip>

arch/arm/boot/dts/omap3-overo-common-dvi.dtsi line 60

Quoted 6 lines

+&dss {
arch/arm/boot/dts/omap3-overo-common-dvi.dtsi new file +5 -0
+	status = "ok";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&dss_dpi_pins
+		     &i2c3_pins>;

The i2c3 pins don't belong here, they are not related to dss. The dvi-connector uses i2c3, but I don't think they belong there either, as the i2c3 bus can be used by multiple devices. So I guess they should be set in &i2c3 node.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140312/0bb701b0/attachment.sig>

Florian Vaussard

author

2014-03-13 08:25 UTC #3 lore raw

PATCH 1/3 ARM: dts: overo: Add support for DVI output

Hi,

Quoted 15 lines · Tomi Valkeinen

Quoted 11 lines · Florian Vaussard
Summit and Tobi expansion boards have a HDMI connector with a TFP410 encoder. Add a common include file for this configuration, and then use it for Summit and Tobi.
Signed-off-by Florian Vaussard <[email protected]>
---
 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi    | 109 +++++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-summit-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi   |   1 +
 3 files changed, 111 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-dvi.dtsi
<snip>

Quoted 12 lines

arch/arm/boot/dts/omap3-overo-common-dvi.dtsi line 60
Quoted 6 lines
+&dss {
arch/arm/boot/dts/omap3-overo-common-dvi.dtsi new file +5 -0
+	status = "ok";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&dss_dpi_pins
+		     &i2c3_pins>;
The i2c3 pins don't belong here, they are not related to dss. The dvi-connector uses i2c3, but I don't think they belong there either, as the i2c3 bus can be used by multiple devices. So I guess they should be set in &i2c3 node.

You are right. And as I am already using i2c3 for other things, this duplicates the pinctrl. I will drop it.

Regards,
Florian

Florian Vaussard

author

2014-03-11 12:34 UTC #4 lore raw

PATCH 2/3 ARM: dts: overo: Add support for 4.3'' LCD output

In reply to Florian Vaussard

Chestnut43, Gallop43 and Palo43 expansion boards have a ZIF connector for a 4.3'' LCD.Add a common include file for this configuration, and use it on relevant expansion boards.

Signed-off-by Florian Vaussard <[email protected]>

---
 .../boot/dts/omap3-overo-chestnut43-common.dtsi    |   1 +
 arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi    | 146 +++++++++++++++++++++
 arch/arm/boot/dts/omap3-overo-gallop43-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-palo43-common.dtsi   |   1 +
 4 files changed, 149 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi

arch/arm/boot/dts/omap3-overo-chestnut43-common.dtsi +1 -0

index 19de6ff..17b82f8 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-lcd43.dtsi"
 
 #include <dt-bindings/input/input.h>

arch/arm/boot/dts/omap3-overo-common-lcd43.dtsi new file +146 -0

146 lines not on this page · raw message

arch/arm/boot/dts/omap3-overo-gallop43-common.dtsi +1 -0

index 5e848c2..49d2254 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-lcd43.dtsi"
 
 #include <dt-bindings/input/input.h>

arch/arm/boot/dts/omap3-overo-palo43-common.dtsi +1 -0

index abea232..087aedf 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-lcd43.dtsi"
 
 #include <dt-bindings/input/input.h>

Signature · 1 line

1.8.3.2

Florian Vaussard

author

2014-03-11 12:34 UTC #5 lore raw

PATCH 3/3 ARM: dts: overo: Add support for 3.5'' LCD output

In reply to Florian Vaussard

Alto35 expansion board has a ZIF connector for a 3.5'' LCD. Add a common include file for this configuration, and use it on Alto35.

Signed-off-by Florian Vaussard <[email protected]>

---
 arch/arm/boot/dts/omap3-overo-alto35-common.dtsi |   1 +
 arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi  | 145 +++++++++++++++++++++++
 2 files changed, 146 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi

arch/arm/boot/dts/omap3-overo-alto35-common.dtsi +1 -0

index 19d6486..7aae8fb 100644
@@ -11,6 +11,7 @@
  */
 
 #include "omap3-overo-common-peripherals.dtsi"
+#include "omap3-overo-common-lcd35.dtsi"
 
 #include <dt-bindings/input/input.h>

arch/arm/boot/dts/omap3-overo-common-lcd35.dtsi new file +145 -0

145 lines not on this page · raw message

Signature · 1 line

1.8.3.2

Tomi Valkeinen

2014-03-12 07:14 UTC #6 lore raw

cover ARM: dts: overo: Add graphics output

In reply to Florian Vaussard

Quoted 17 lines · Florian Vaussard

Hi,
This series enables the DVI / LCD graphics present on some of the Overo expansion boards.
DVI output:
- Tobi
- Summit
LCD (3.5''):
- Alto35
LCD (4.3''):
- Chestnut43
- Palo43
- Gallop43

Quoted 6 lines

I tested on Tobi, Alto35 and Gallop43 using both OMAP35xx and OMAP36xx Overo boards.
This series depends on Tomi's DSS patches [1] that are not yet merged. It also depends on previous Overo series [2] and [3] that are under review. A complete testing tree is available [4].

Looks good to me. Unfortunately the video bindings are still being discussed (mainly the ports/endpoints), so there might be changes needed when some kind of conclusion is reached.

Tomi

Florian Vaussard

author

2014-03-13 08:24 UTC #7 lore raw

cover ARM: dts: overo: Add graphics output

Hi,

Quoted 21 lines · Tomi Valkeinen

Quoted 20 lines · Florian Vaussard
Hi,
This series enables the DVI / LCD graphics present on some of the Overo expansion boards.
DVI output:
- Tobi
- Summit
LCD (3.5''):
- Alto35
LCD (4.3''):
- Chestnut43
- Palo43
- Gallop43
I tested on Tobi, Alto35 and Gallop43 using both OMAP35xx and OMAP36xx Overo boards.

Quoted 8 lines

Quoted 3 lines
This series depends on Tomi's DSS patches [1] that are not yet merged. It also depends on previous Overo series [2] and [3] that are under review. A complete testing tree is available [4].
Looks good to me. Unfortunately the video bindings are still being discussed (mainly the ports/endpoints), so there might be changes needed when some kind of conclusion is reached.

Yes, I saw. This is why I posted this separately from the other patches. I will update if necessary, let's wait.

Regards,
Florian