Skip to contentSkip to conversation

powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM

PATCH New Shengzhou Liu 3 participants 4 messages Mar 13, 2014

lore
Share & tools
lore

Shengzhou Liu

author
#0 lore raw

PATCH 1/1 powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM

Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM

Signed-off-by Shengzhou Liu <[email protected]>
---
 include/configs/T208xQDS.h | 6 +++++-
 include/configs/T208xRDB.h | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
include/configs/T208xQDS.h +5 -1
index 7c5f57c..c9ac9a5 100644
@@ -163,13 +163,15 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_CHIP_SELECTS_PER_CTRL	(4 * CONFIG_DIMM_SLOTS_PER_CTLR)
 #define CONFIG_DDR_SPD
 #define CONFIG_SYS_FSL_DDR3
-#undef CONFIG_FSL_DDR_INTERACTIVE
+#define CONFIG_FSL_DDR_INTERACTIVE
 #define CONFIG_SYS_SPD_BUS_NUM	0
 #define CONFIG_SYS_SDRAM_SIZE	2048	/* for fixed parameter use */
 #define SPD_EEPROM_ADDRESS1	0x51
 #define SPD_EEPROM_ADDRESS2	0x52
 #define SPD_EEPROM_ADDRESS	SPD_EEPROM_ADDRESS1
 #define CTRL_INTLV_PREFERED	cacheline
+#define CONFIG_SYS_MEMTEST_START	0x01000000  /* memtest works on */
+#define CONFIG_SYS_MEMTEST_END		0x01ffffff
 
 /*
  * IFC Definitions

@@ -679,6 +681,8 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MII
 #define CONFIG_CMD_PING
+#define CONFIG_CMD_MEMTEST
+#define CONFIG_CMD_EEPROM
 #define CONFIG_CMD_SETEXPR
 #define CONFIG_CMD_REGINFO
 #define CONFIG_CMD_BDI
include/configs/T208xRDB.h +5 -1
index 1db8bea..de4d6dc 100644
@@ -152,13 +152,15 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_CHIP_SELECTS_PER_CTRL	(4 * CONFIG_DIMM_SLOTS_PER_CTLR)
 #define CONFIG_DDR_SPD
 #define CONFIG_SYS_FSL_DDR3
-#undef CONFIG_FSL_DDR_INTERACTIVE
+#define CONFIG_FSL_DDR_INTERACTIVE
 #define CONFIG_SYS_SPD_BUS_NUM	0
 #define CONFIG_SYS_SDRAM_SIZE	2048	/* for fixed parameter use */
 #define SPD_EEPROM_ADDRESS1	0x51
 #define SPD_EEPROM_ADDRESS2	0x52
 #define SPD_EEPROM_ADDRESS	SPD_EEPROM_ADDRESS1
 #define CTRL_INTLV_PREFERED	cacheline
+#define CONFIG_SYS_MEMTEST_START	0x01000000  /* memtest works on */
+#define CONFIG_SYS_MEMTEST_END		0x01ffffff
 
 /*
  * IFC Definitions

@@ -631,6 +633,8 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_PING
 #define CONFIG_CMD_ECHO
+#define CONFIG_CMD_MEMTEST
+#define CONFIG_CMD_EEPROM
 #define CONFIG_CMD_SETEXPR
 #define CONFIG_CMD_REGINFO
 #define CONFIG_CMD_BDI
Signature · 1 line
1.8.0
#1 lore raw

PATCH 1/1 powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM

Quoted 1 line · Shengzhou Liu

Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM

I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago.
As for the ddr debugging, do you need it enabled by default? I am not against the idea to have it because I debug DDR a lot. But I doubt if it is useful for developers who don't care the detail about DDR.

York

#2 lore raw

PATCH 1/1 powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM

Dear York Sun,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 1 line · Shengzhou Liu

Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM

I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago.

Except for some very specific cases (like watching signals on a scope while running the test) memtest is almost totally worthless.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Once upon a time, "PC" meant "personal computer".  Now  it  seems  to
only  mean  "Prisoner  of Bill". Alas! All my PCs run Unix, and those
include Intel, Sparc, and other processors.
          -- Tom "Bring back the non-PC meaning of `PC'" Christiansen
#3 lore raw

PATCH 1/1 powerpc/t208x: enable command MEMTEST DDR_INTERACTIVE EEPROM

Quoted 4 lines · Wolfgang Denk

Dear York Sun,

Quoted 1 line · In message <[email protected]> you wrote:
Quoted 9 lines
Quoted 5 lines · Shengzhou Liu
Quoted 2 lines

Enable CONFIG_CMD_MEMTEST, CONFIG_FSL_DDR_INTERACTIVE, CONFIG_CMD_EEPROM

I can see the ddr debugging and eeprom command are useful. But I am not convinced memtest is effective as it is intended to be. There was a discussion a while ago.

Except for some very specific cases (like watching signals on a scope while running the test) memtest is almost totally worthless.

Wolfgang,

Thanks. I will info our internal team to phase out memtest.

York