Skip to contentSkip to conversation

ARM: BCM63XX: add support for BCM63138 SoC

PATCH New Florian Fainelli 5 participants 14 messages Mar 6, 2014 – Apr 2, 2014

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

Hi all,

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Future work will focus on:

- clock device/driver/providers
- SMP support (already working)
- DT'fying drivers/tty/serial/bcm63xx_uart.c to be usable

Florian Fainelli (6):
ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC
ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE
ARM: BCM63XX: add low-level UART debug support
ARM: BCM63XX: add BCM63138 minimal Device Tree
ARM: BCM63XX: add BCM963138DVT Reference platform DTS
MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs

 .../devicetree/bindings/arm/bcm/bcm63138.txt       |   9 ++
 MAINTAINERS                                        |  10 ++
 arch/arm/Kconfig.debug                             |  20 +++-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/bcm63138.dtsi                    | 109 +++++++++++++++++++++
 arch/arm/boot/dts/bcm63138dvt.dts                  |  18 ++++
 arch/arm/include/debug/bcm63xxx.S                  |  33 +++++++
 arch/arm/mach-bcm/Kconfig                          |  20 ++++
 arch/arm/mach-bcm/Makefile                         |   2 +
 arch/arm/mach-bcm/bcm63xx.h                        |  29 ++++++
 arch/arm/mach-bcm/board_bcm63xx.c                  |  94 ++++++++++++++++++
 11 files changed, 342 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt
 create mode 100644 arch/arm/boot/dts/bcm63138.dtsi
 create mode 100644 arch/arm/boot/dts/bcm63138dvt.dts
 create mode 100644 arch/arm/include/debug/bcm63xxx.S
 create mode 100644 arch/arm/mach-bcm/bcm63xx.h
 create mode 100644 arch/arm/mach-bcm/board_bcm63xx.c
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/6 ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC

This patch adds basic support for the Broadcom BCM63138 DSL SoC which is using a dual-core Cortex A9 system. Add the very minimum required code boot Linux on this SoC.

Due to the two specific register address spaces located at 0x8000_0000 and 0xfffe_0000, we need to setup a specific iotable descriptor for those to be remapped at the expected virtual addresses.

Finally, the PL310 cache controller requires a bit of tweaking before handing its initialization over l2x0_of_init(), this is also taken care of to make sure that its size is properly configured.

---
 .../devicetree/bindings/arm/bcm/bcm63138.txt       |  9 +++
 arch/arm/mach-bcm/Kconfig                          | 20 +++++
 arch/arm/mach-bcm/Makefile                         |  2 +
 arch/arm/mach-bcm/bcm63xx.h                        | 29 +++++++
 arch/arm/mach-bcm/board_bcm63xx.c                  | 94 ++++++++++++++++++++++
 5 files changed, 154 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt
 create mode 100644 arch/arm/mach-bcm/bcm63xx.h
 create mode 100644 arch/arm/mach-bcm/board_bcm63xx.c
Documentation/devicetree/bindings/arm/bcm/bcm63138.txt new file +9 -0
new file mode 100644
index 000000000000..bd49987a8812
@@ -0,0 +1,9 @@
+Broadcom BCM63138 DSL System-on-a-Chip device tree bindings
+-----------------------------------------------------------
+
+Boards compatible with the BCM63138 DSL System-on-a-Chip should have the
+following properties:
+
+Required root node property:
+
+compatible: should be "brcm,bcm63138"
arch/arm/mach-bcm/Kconfig +20 -0
index b1aa6a9b3bd1..951e1ec47a04 100644
@@ -32,6 +32,26 @@ config ARCH_BCM_MOBILE
 	  BCM11130, BCM11140, BCM11351, BCM28145 and
 	  BCM28155 variants.
 
+config ARCH_BCM_63XX
+	bool "Broadcom BCM63xx DSL SoC" if ARCH_MULTI_V7
+	depends on MMU
+	select ARM_ERRATA_754322
+	select ARM_ERRATA_764369 if SMP
+	select ARM_GIC
+	select ARM_GLOBAL_TIMER
+	select CACHE_L2X0
+	select COMMON_CLK
+	select CPU_V7
+	select GENERIC_CLOCKEVENTS
+	select HAVE_ARM_ARCH_TIMER
+	select HAVE_ARM_TWD if SMP
+	select HAVE_ARM_SCU if SMP
+	select HAVE_SMP
+	help
+	  This enables support for systems based on Broadcom DSL SoCs.
+	  It currently supports the 'BCM63XX' ARM-based family, which includes
+	  the BCM63138 variant.
+
 endmenu
 
 endif
arch/arm/mach-bcm/Makefile +2 -0
index c2ccd5a0f772..3bf068ac797a 100644
@@ -13,3 +13,5 @@
 obj-$(CONFIG_ARCH_BCM_MOBILE)	:= board_bcm281xx.o bcm_kona_smc.o bcm_kona_smc_asm.o kona.o
 plus_sec := $(call as-instr,.arch_extension sec,+sec)
 AFLAGS_bcm_kona_smc_asm.o	:=-Wa,-march=armv7-a$(plus_sec)
+
+obj-$(CONFIG_ARCH_BCM_63XX)	:= board_bcm63xx.o
arch/arm/mach-bcm/bcm63xx.h new file +29 -0
new file mode 100644
index 000000000000..95872c8131f6
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2014 Broadcom Corporation
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARM_BCM63XX_H
+#define __ARM_BCM63XX_H
+
+#define IO_ADDRESS(x)		(((x) & 0x00ffffff) + 0xfc000000)
+
+/* AHB register space */
+#define BCM63XX_AHB_PHYS	0x80001000
+#define BCM63XX_AHB_VIRT	IO_ADDRESS(BCM63XX_AHB_PHYS)
+#define BCM63XX_AHB_SIZE	0x800000
+
+/* PERIPH (legacy) register space */
+#define BCM63XX_PERIPH_PHYS	0xfffe8000
+#define BCM63XX_PERIPH_VIRT	IO_ADDRESS(BCM63XX_PERIPH_PHYS)
+#define BCM63XX_PERIPH_SIZE	0x10000
+
+#endif /* __ARM_BCM63XX_H */
arch/arm/mach-bcm/board_bcm63xx.c new file +94 -0

94 lines not on this page · raw message

Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 2/6 ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE

In reply to Florian Fainelli

Low-level debugging using the Broadcom Kona UART only makes sense on the ARCH_BCM_MOBILE platform and would otherwise prevent ARCH_BCM_63XX from picking up the right UART implementation by default.

---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig.debug +1 -1
index 0531da8e5216..c23f52445308 100644
@@ -108,7 +108,7 @@ choice
 
 	config DEBUG_BCM_KONA_UART
 		bool "Kernel low-level debugging messages via BCM KONA UART"
-		depends on ARCH_BCM
+		depends on ARCH_BCM_MOBILE
 		select DEBUG_UART_8250
 		help
 		  Say Y here if you want kernel low-level debugging support
Signature · 1 line
1.8.3.2
#3 lore raw

PATCH 2/6 ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE

Quoted 23 lines · Florian Fainelli

Low-level debugging using the Broadcom Kona UART only makes sense on the ARCH_BCM_MOBILE platform and would otherwise prevent ARCH_BCM_63XX from picking up the right UART implementation by default.

---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/Kconfig.debug +1 -2
index 0531da8e5216..c23f52445308 100644
@@ -108,7 +108,7 @@ choice
 
        config DEBUG_BCM_KONA_UART
                bool "Kernel low-level debugging messages via BCM KONA UART"
-               depends on ARCH_BCM
+               depends on ARCH_BCM_MOBILE
                select DEBUG_UART_8250
                help
                  Say Y here if you want kernel low-level debugging support
--
Quoted 1 line

1.8.3.2

Applied
#4 lore raw

PATCH 2/6 ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE

In reply to Florian Fainelli
Quoted 8 lines · Florian Fainelli

Low-level debugging using the Broadcom Kona UART only makes sense on the ARCH_BCM_MOBILE platform and would otherwise prevent ARCH_BCM_63XX from picking up the right UART implementation by default.

---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to mach-bcm armsoc/for-3.15/soc-3

Thanks,
Matt

#5 lore raw

PATCH 3/6 ARM: BCM63XX: add low-level UART debug support

In reply to Florian Fainelli

Broadcom BCM63xx DSL SoCs have a different UART implementation for which we need specially crafted low-level debug assembly code to support. Add support for this using the standard definitions provided in include/linux/serial_bcm63xx.h (shared with their MIPS counterparts).

---
 arch/arm/Kconfig.debug            | 18 ++++++++++++++++--
 arch/arm/include/debug/bcm63xxx.S | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/debug/bcm63xxx.S
arch/arm/Kconfig.debug +16 -2
index c23f52445308..a1a4281dc4b9 100644
@@ -117,6 +117,11 @@ choice
 		  mobile SoCs in the Kona family of chips (e.g. bcm28155,
 		  bcm11351, etc...)
 
+	config DEBUG_BCM63XX
+		bool "Kernel low-level debugging on BCM63XX UART"
+		depends on ARCH_BCM_63XX
+		select DEBUG_UART_BCM63XX
+
 	config DEBUG_BERLIN_UART
 		bool "Marvell Berlin SoC Debug UART"
 		depends on ARCH_BERLIN
@@ -985,6 +990,7 @@ config DEBUG_LL_INCLUDE
 	default "debug/vf.S" if DEBUG_VF_UART
 	default "debug/vt8500.S" if DEBUG_VT8500_UART0
 	default "debug/zynq.S" if DEBUG_ZYNQ_UART0 || DEBUG_ZYNQ_UART1
+	default "debug/bcm63xxx.S" if DEBUG_UART_BCM63XX
 	default "mach/debug-macro.S"
 
 # Compatibility options for PL01x
@@ -1004,6 +1010,10 @@ config DEBUG_UART_8250
 		ARCH_IOP33X || ARCH_IXP4XX || ARCH_KIRKWOOD || \
 		ARCH_LPC32XX || ARCH_MV78XX0 || ARCH_ORION5X || ARCH_RPC
 
+# Compatibility options for BCM63xx
+config DEBUG_UART_BCM63XX
+	def_bool ARCH_BCM_63XX
+
 config DEBUG_UART_PHYS
 	hex "Physical base address of debug UART"
 	default 0x01c20000 if DEBUG_DAVINCI_DMx_UART0
@@ -1059,10 +1069,12 @@ config DEBUG_UART_PHYS
 	default 0xffc02000 if DEBUG_SOCFPGA_UART
 	default 0xffd82340 if ARCH_IOP13XX
 	default 0xfff36000 if DEBUG_HIGHBANK_UART
+	default 0xfffe8600 if DEBUG_UART_BCM63XX
 	default 0xfffff700 if ARCH_IOP33X
 	depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
 		DEBUG_LL_UART_EFM32 || \
-		DEBUG_UART_8250 || DEBUG_UART_PL01X
+		DEBUG_UART_8250 || DEBUG_UART_PL01X || \
+		DEBUG_UART_BCM63XX
 
 config DEBUG_UART_VIRT
 	hex "Virtual base address of debug UART"
@@ -1083,6 +1095,7 @@ config DEBUG_UART_VIRT
 	default 0xf8090000 if DEBUG_VEXPRESS_UART0_RS1
 	default 0xfb009000 if DEBUG_REALVIEW_STD_PORT
 	default 0xfb10c000 if DEBUG_REALVIEW_PB1176_PORT
+	default 0xfcfe8600 if DEBUG_UART_BCM63XX
 	default 0xfd000000 if ARCH_SPEAR3XX || ARCH_SPEAR6XX
 	default 0xfd000000 if ARCH_SPEAR13XX
 	default 0xfd012000 if ARCH_MV78XX0
@@ -1120,7 +1133,8 @@ config DEBUG_UART_VIRT
 	default 0xff003000 if DEBUG_U300_UART
 	default DEBUG_UART_PHYS if !MMU
 	depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
-		DEBUG_UART_8250 || DEBUG_UART_PL01X
+		DEBUG_UART_8250 || DEBUG_UART_PL01X || \
+		DEBUG_UART_BCM63XX
 
 config DEBUG_UART_8250_SHIFT
 	int "Register offset shift for the 8250 debug UART"
arch/arm/include/debug/bcm63xxx.S new file +33 -0
new file mode 100644
index 000000000000..a28fbd1bb5d8
@@ -0,0 +1,33 @@
+/*
+ * Broadcom BCM63xxx low-level UART debug
+ *
+ * Copyright (C) 2014 Broadcom Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/serial_bcm63xx.h>
+
+	.macro	addruart, rp, rv, tmp
+	ldr	\rp, =CONFIG_DEBUG_UART_PHYS
+	ldr	\rv, =CONFIG_DEBUG_UART_VIRT
+	.endm
+
+	.macro	senduart, rd, rx
+	/* word access do not work */
+	strb	\rd, [\rx, #UART_FIFO_REG]
+	.endm
+
+	.macro	waituart, rd, rx
+1001:	ldr	\rd, [\rx, #UART_IR_REG]
+	tst	\rd, #(1 << UART_IR_TXEMPTY)
+	beq	1001b
+	.endm
+
+	.macro	busyuart, rd, rx
+1002:	ldr	\rd, [\rx, #UART_IR_REG]
+	tst	\rd, #(1 << UART_IR_TXTRESH)
+	beq	1002b
+	.endm
Signature · 1 line
1.8.3.2
#6 lore raw

PATCH 4/6 ARM: BCM63XX: add BCM63138 minimal Device Tree

In reply to Florian Fainelli

Add a very minimalistic BCM63138 Device Tree include file which describes the BCM63138 SoC with only the basic set of required peripherals:

- Cortex A9 CPU
- ARM GIC
- PL310 Level-2 cache controller
- ARM TWD & Global timers
- ARM TWD watchdog
- legacy MIPS bus (UBUS)

---
 arch/arm/boot/dts/bcm63138.dtsi | 109 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm63138.dtsi
arch/arm/boot/dts/bcm63138.dtsi new file +109 -0
new file mode 100644
index 000000000000..190d6e53a85a
@@ -0,0 +1,109 @@
+/*
+ * Broadcom BCM63138 DSL SoCs Device Tree
+ *
+ * Copyright (C) 2014 Broadcom Corporation
+ *
+ * Licensed under the GNU/GPL. See COPYING for details
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+#include "skeleton.dtsi"
+
+/ {
+	compatible = "brcm,bcm63138";
+	model = "Broadcom BCM63138 DSL SoC";
+	interrupt-parent = <&gic>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			next-level-cache = <&L2>;
+			reg = <0>;
+		};
+	};
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		arm_timer_clk: arm_timer_clk {
+			#clock-cells = <0>;
+			compatible = "fixed-clock";
+			clock-frequency = <500000000>;
+		};
+	};
+
+	/* ARM bus */
+	axi at 80000000 {
+		compatible = "simple-bus";
+		ranges = <0 0x80000000 0x783003>;
+		reg = <0x80000000 0x783003>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		L2: cache-controller at 1d000 {
+			compatible = "arm,pl310-cache";
+			reg = <0x1d000 0x1000>;
+			cache-unified;
+			cache-level = <2>;
+			interrupts = <GIC_PPI 0 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
+		mpcore at 1e000 {
+			compatible = "simple-bus";
+			reg = <0x1e000 0x20000>;
+			ranges = <0 0x1e000 0x20000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			scu: scu at 0 {
+				compatible = "arm,cortex-a9-scu";
+				reg = <0x0 0x100>;
+			};
+
+			gic: interrupt-controller at 100 {
+				compatible = "arm,cortex-a9-gic";
+				reg = <0x1000 0x1000
+					0x100 0x100>;
+				#interrupt-cells = <3>;
+				#address-cells = <0>;
+				interrupt-controller;
+			};
+
+			global_timer: timer at 200 {
+				compatible = "arm,cortex-a9-global-timer";
+				reg = <0x200 0x20>;
+				interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&arm_timer_clk>;
+			};
+
+			local_timer: local-timer at 600 {
+				compatible = "arm,cortex-a9-twd-timer";
+				reg = <0x600 0x20>;
+				interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&arm_timer_clk>;
+			};
+
+			twd_watchdog: watchdog at 620 {
+				compatible = "arm,cortex-a9-twd-wdt";
+				reg = <0x620 0x20>;
+				interupts = <GIC_PPI 14 IRQ_TYPE_LEVEL_HIGH>;
+			};
+		};
+	};
+
+	/* Legacy UBUS base */
+	ubus at fffe8000 {
+		compatible = "simple-bus";
+		reg = <0xfffe8000 0x8053>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0xfffe8000 0x8053>;
+	};
+};
Signature · 1 line
1.8.3.2
#7 lore raw

PATCH 5/6 ARM: BCM63XX: add BCM963138DVT Reference platform DTS

In reply to Florian Fainelli

Add a DTS file for the Broadcom BCM963138DVT reference platform board which leverages the bcm63138.dtsi SoC DTSi file.

---
 arch/arm/boot/dts/Makefile        |  1 +
 arch/arm/boot/dts/bcm63138dvt.dts | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm63138dvt.dts
arch/arm/boot/dts/Makefile +1 -0
index 032030361bef..1e404a51d563 100644
@@ -47,6 +47,7 @@ dtb-$(CONFIG_ARCH_AT91)	+= sama5d36ek.dtb
 
 dtb-$(CONFIG_ARCH_ATLAS6) += atlas6-evb.dtb
 dtb-$(CONFIG_ARCH_BCM2835) += bcm2835-rpi-b.dtb
+dtb-$(CONFIG_ARCH_BCM_63XX) += bcm63138dvt.dtb
 dtb-$(CONFIG_ARCH_BCM_MOBILE) += bcm11351-brt.dtb \
 	bcm28155-ap.dtb
 dtb-$(CONFIG_ARCH_BCM2835) += bcm2835-rpi-b.dtb
arch/arm/boot/dts/bcm63138dvt.dts new file +18 -0
new file mode 100644
index 000000000000..e212b4731978
@@ -0,0 +1,18 @@
+/*
+ * Broadcom BCM63138 Reference Board DTS
+ *
+ * Copyright (C) 2014 Broadcom Corporation
+ */
+
+/dts-v1/;
+
+#include "bcm63138.dtsi"
+
+/ {
+	compatible = "BCM963138DVT", "brcm,bcm63138";
+	model = "Broadcom BCM963138DVT";
+
+	memory {
+		reg = <0x0 0x08000000>;
+	};
+};
Signature · 1 line
1.8.3.2
#8 lore raw

PATCH 6/6 MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs

In reply to Florian Fainelli

Add a MAINTAINERS entry covering all the Broadcom BCM63xx ARM DSL SoCs files along with the relevant git tree and mailing-list.

---
 MAINTAINERS | 10 ++++++++++
 1 file changed, 10 insertions(+)
MAINTAINERS +10 -0
index e1297ff255e1..628cfe1c6daa 100644
@@ -1882,6 +1882,16 @@ F:	arch/arm/boot/dts/bcm2835*
 F:	arch/arm/configs/bcm2835_defconfig
 F:	drivers/*/*bcm2835*
 
+BROADCOM BCM63XX ARM ARCHITECTURE
+M:	Florian Fainelli <[email protected]>
+L:	linux-arm-kernel at lists.infradead.org
+T:	git git://git.github.com/broadcom/arm-bcm63xx
+S:	Maintained
+F:	arch/arm/mach-bcm/board_bcm63xx.c
+F:	arch/arm/mach-bcm/bcm63xx.h
+F:	arch/arm/include/debug/bcm63xxx.S
+F:	arch/arm/configs/bcm_defconfig
+
 BROADCOM TG3 GIGABIT ETHERNET DRIVER
 M:	Nithin Nayak Sujir <[email protected]>
 M:	Michael Chan <[email protected]>
Signature · 1 line
1.8.3.2
#9 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

In reply to Florian Fainelli
Quoted 4 lines · Florian Fainelli

Hi all,

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Why do you use "63xx" for the generic name, when the specific part you are defining here is 63138? I would have expected "63xxx".

-Alex

Quoted 33 lines

Future work will focus on:

- clock device/driver/providers
- SMP support (already working)
- DT'fying drivers/tty/serial/bcm63xx_uart.c to be usable

Florian Fainelli (6):
ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC
ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE
ARM: BCM63XX: add low-level UART debug support
ARM: BCM63XX: add BCM63138 minimal Device Tree
ARM: BCM63XX: add BCM963138DVT Reference platform DTS
MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs

  .../devicetree/bindings/arm/bcm/bcm63138.txt       |   9 ++
  MAINTAINERS                                        |  10 ++
  arch/arm/Kconfig.debug                             |  20 +++-
  arch/arm/boot/dts/Makefile                         |   1 +
  arch/arm/boot/dts/bcm63138.dtsi                    | 109 +++++++++++++++++++++
  arch/arm/boot/dts/bcm63138dvt.dts                  |  18 ++++
  arch/arm/include/debug/bcm63xxx.S                  |  33 +++++++
  arch/arm/mach-bcm/Kconfig                          |  20 ++++
  arch/arm/mach-bcm/Makefile                         |   2 +
  arch/arm/mach-bcm/bcm63xx.h                        |  29 ++++++
  arch/arm/mach-bcm/board_bcm63xx.c                  |  94 ++++++++++++++++++
  11 files changed, 342 insertions(+), 3 deletions(-)

create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt create mode 100644 arch/arm/boot/dts/bcm63138.dtsi
create mode 100644 arch/arm/boot/dts/bcm63138dvt.dts
create mode 100644 arch/arm/include/debug/bcm63xxx.S
create mode 100644 arch/arm/mach-bcm/bcm63xx.h
create mode 100644 arch/arm/mach-bcm/board_bcm63xx.c

#10 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

Quoted 7 lines · Alex Elder
Quoted 2 lines

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Why do you use "63xx" for the generic name, when the specific part you are defining here is 63138? I would have expected "63xxx".

The product line has a mix of 4-digit and 5-digit part numbers. The drivers for onchip peripherals all used "bcm63xx":

$ find drivers/ | grep 63xx
drivers/tty/serial/bcm63xx_uart.c
drivers/pcmcia/bcm63xx_pcmcia.h
drivers/pcmcia/bcm63xx_pcmcia.c
drivers/usb/gadget/bcm63xx_udc.c
drivers/watchdog/max63xx_wdt.c
drivers/watchdog/bcm63xx_wdt.c
drivers/char/hw_random/bcm63xx-rng.c
drivers/mtd/bcm63xxpart.c
drivers/net/phy/bcm63xx.c
drivers/net/ethernet/broadcom/bcm63xx_enet.h
drivers/net/ethernet/broadcom/bcm63xx_enet.c
drivers/spi/spi-bcm63xx.c
drivers/spi/spi-bcm63xx-hsspi.c
#11 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

Quoted 11 lines · Kevin Cernekee
Quoted 7 lines · Alex Elder
Quoted 2 lines

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Why do you use "63xx" for the generic name, when the specific part you are defining here is 63138? I would have expected "63xxx".

The product line has a mix of 4-digit and 5-digit part numbers. The drivers for onchip peripherals all used "bcm63xx":

That's too bad. I would suggest that one or the other be used consistently, apparently "63xx" (not 63xxx) would be it.

-Alex

Quoted 15 lines
$ find drivers/ | grep 63xx
drivers/tty/serial/bcm63xx_uart.c
drivers/pcmcia/bcm63xx_pcmcia.h
drivers/pcmcia/bcm63xx_pcmcia.c
drivers/usb/gadget/bcm63xx_udc.c
drivers/watchdog/max63xx_wdt.c
drivers/watchdog/bcm63xx_wdt.c
drivers/char/hw_random/bcm63xx-rng.c
drivers/mtd/bcm63xxpart.c
drivers/net/phy/bcm63xx.c
drivers/net/ethernet/broadcom/bcm63xx_enet.h
drivers/net/ethernet/broadcom/bcm63xx_enet.c
drivers/spi/spi-bcm63xx.c
drivers/spi/spi-bcm63xx-hsspi.c
#12 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

In reply to Florian Fainelli

2014-03-06 9:45 GMT-08:00 Florian Fainelli <[email protected]>:

Quoted 10 lines

Hi all,

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Future work will focus on:

- clock device/driver/providers
- SMP support (already working)
- DT'fying drivers/tty/serial/bcm63xx_uart.c to be usable

Gentle ping, patch 2 should not be too controversial and could probably be queued for a next 3.14-rc pull request?

Quoted 31 lines

Florian Fainelli (6):
ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC
ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE
ARM: BCM63XX: add low-level UART debug support
ARM: BCM63XX: add BCM63138 minimal Device Tree
ARM: BCM63XX: add BCM963138DVT Reference platform DTS
MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs

 .../devicetree/bindings/arm/bcm/bcm63138.txt       |   9 ++
 MAINTAINERS                                        |  10 ++
 arch/arm/Kconfig.debug                             |  20 +++-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/bcm63138.dtsi                    | 109 +++++++++++++++++++++
 arch/arm/boot/dts/bcm63138dvt.dts                  |  18 ++++
 arch/arm/include/debug/bcm63xxx.S                  |  33 +++++++
 arch/arm/mach-bcm/Kconfig                          |  20 ++++
 arch/arm/mach-bcm/Makefile                         |   2 +
 arch/arm/mach-bcm/bcm63xx.h                        |  29 ++++++
 arch/arm/mach-bcm/board_bcm63xx.c                  |  94 ++++++++++++++++++
 11 files changed, 342 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt
 create mode 100644 arch/arm/boot/dts/bcm63138.dtsi
 create mode 100644 arch/arm/boot/dts/bcm63138dvt.dts
 create mode 100644 arch/arm/include/debug/bcm63xxx.S
 create mode 100644 arch/arm/mach-bcm/bcm63xx.h
 create mode 100644 arch/arm/mach-bcm/board_bcm63xx.c

--
1.8.3.2

Signature · 1 line
Florian
#13 lore raw

cover ARM: BCM63XX: add support for BCM63138 SoC

Hi all,

2014-03-11 10:10 GMT-07:00 Florian Fainelli <[email protected]>:

Quoted 6 lines

2014-03-06 9:45 GMT-08:00 Florian Fainelli <[email protected]>:

Quoted 5 lines

Hi all,

This patchset adds very minimal support for the BCM63138 SoC which is a xDSL SoC using a dual Cortex A9 CPU complex.

Quoted 8 lines
Quoted 5 lines

Future work will focus on:

- clock device/driver/providers
- SMP support (already working)
- DT'fying drivers/tty/serial/bcm63xx_uart.c to be usable

Gentle ping, patch 2 should not be too controversial and could probably be queued for a next 3.14-rc pull request?

Thanks for merging patch 2, can I borrow some of your bandwidth to review the remainder of the patches?

Thanks!

Quoted 37 lines
Quoted 29 lines

Florian Fainelli (6):
ARM: BCM63XX: add basic support for the Broadcom BCM63138 DSL SoC
ARM: restrict BCM_KONA_UART to ARCH_BCM_MOBILE
ARM: BCM63XX: add low-level UART debug support
ARM: BCM63XX: add BCM63138 minimal Device Tree
ARM: BCM63XX: add BCM963138DVT Reference platform DTS
MAINTAINERS: add entry for the Broadcom BCM63xx ARM SoCs

 .../devicetree/bindings/arm/bcm/bcm63138.txt       |   9 ++
 MAINTAINERS                                        |  10 ++
 arch/arm/Kconfig.debug                             |  20 +++-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/bcm63138.dtsi                    | 109 +++++++++++++++++++++
 arch/arm/boot/dts/bcm63138dvt.dts                  |  18 ++++
 arch/arm/include/debug/bcm63xxx.S                  |  33 +++++++
 arch/arm/mach-bcm/Kconfig                          |  20 ++++
 arch/arm/mach-bcm/Makefile                         |   2 +
 arch/arm/mach-bcm/bcm63xx.h                        |  29 ++++++
 arch/arm/mach-bcm/board_bcm63xx.c                  |  94 ++++++++++++++++++
 11 files changed, 342 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/bcm63138.txt
 create mode 100644 arch/arm/boot/dts/bcm63138.dtsi
 create mode 100644 arch/arm/boot/dts/bcm63138dvt.dts
 create mode 100644 arch/arm/include/debug/bcm63xxx.S
 create mode 100644 arch/arm/mach-bcm/bcm63xx.h
 create mode 100644 arch/arm/mach-bcm/board_bcm63xx.c
Quoted 3 lines

--
1.8.3.2

--
Florian

Signature · 1 line
Florian