Skip to contentSkip to conversation

mtools: remove ignored configure options

PATCH New Frank Hunleth 3 participants 3 messages Mar 16, 2014 – Mar 17, 2014

lore
Share & tools
lore

Frank Hunleth

author
#0 lore raw

PATCH 1/1 mtools: remove ignored configure options

The --enable-xdf, --enable-vold, and --enable-new-vold options were actually not being passed to ./configure since they were specified on the wrong variable (MTOOLS_CONF_OPT vs. HOST_MTOOLS_CONF_OPT) and mtools is a host-only package. Fixing the variable name so that the options are actually used ends up causing the build to fail due to linker errors. Since vold identifiers and OS/2 XDF support are unlikely to be used any more, remove them completely.

Signed-off-by Frank Hunleth <[email protected]>
---
 package/mtools/mtools.mk | 4 ----
 1 file changed, 4 deletions(-)
package/mtools/mtools.mk +0 -4
index 6751059..11517df 100644
@@ -10,8 +10,4 @@ MTOOLS_SITE          = $(BR2_GNU_MIRROR)/mtools/
 MTOOLS_LICENSE       = GPLv3+
 MTOOLS_LICENSE_FILES = COPYING
 
-MTOOLS_CONF_OPT = --enable-xdf        \
-                  --enable-vold       \
-                  --enable-new-vold
-
 $(eval $(host-autotools-package))
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 mtools: remove ignored configure options

Quoted 9 lines · Frank Hunleth

The --enable-xdf, --enable-vold, and --enable-new-vold options were actually not being passed to ./configure since they were specified on the wrong variable (MTOOLS_CONF_OPT vs. HOST_MTOOLS_CONF_OPT) and mtools is a host-only package. Fixing the variable name so that the options are actually used ends up causing the build to fail due to linker errors. Since vold identifiers and OS/2 XDF support are unlikely to be used any more, remove them completely.

Signed-off-by Frank Hunleth <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 18 lines
---
 package/mtools/mtools.mk | 4 ----
 1 file changed, 4 deletions(-)
package/mtools/mtools.mk +0 -4
index 6751059..11517df 100644
@@ -10,8 +10,4 @@ MTOOLS_SITE          = $(BR2_GNU_MIRROR)/mtools/
 MTOOLS_LICENSE       = GPLv3+
 MTOOLS_LICENSE_FILES = COPYING
 
-MTOOLS_CONF_OPT = --enable-xdf        \
-                  --enable-vold       \
-                  --enable-new-vold
-
 $(eval $(host-autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 mtools: remove ignored configure options

In reply to Frank Hunleth
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Frank" == Frank Hunleth <[email protected]> writes:

The --enable-xdf, --enable-vold, and --enable-new-vold options were actually not being passed to ./configure since they were specified on the wrong variable (MTOOLS_CONF_OPT vs. HOST_MTOOLS_CONF_OPT) and mtools is a host-only package. Fixing the variable name so that the options are actually used ends up causing the build to fail due to linker errors. Since vold identifiers and OS/2 XDF support are unlikely to be used any more, remove them completely.

Signed-off-by Frank Hunleth <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard