usb:typec:mux: remove indentation for common path
Subsystems (2)
PATCH v4 1/1 usb:typec:mux: remove indentation for common path
Nitpick, Mostly common path will not be indented. so rewritten this function to check device_node pointer is null and removed common path indentation.
---
Fixed nitpicks in code according to comments received on other patch as below:
[ Nit, this function should be rewritten to not work like this, the "common" path should not be indented, but only the exception (i.e. bail if ep is not allocated properly.) ]
https://lore.kernel.org/all/2024041103-doornail-professor-7c1e@gregkh/
Goal is to get rid of of_node_put,but sending this patch first to do one thing at a time.
Changes since v1 - fixed the typo error for spell from identation to indentation
Changes since v2 - Shifted the indentation to one level left for the switch cases as per coding style.
Changes since v3 - Added descriptive subject for the patch and checked from and sign-off having same name.
Patches link:
------------
v1 - https://lore.kernel.org/all/[email protected]/ v2 - https://lore.kernel.org/linux-usb/[email protected]/ v3 - https://lore.kernel.org/all/[email protected]/
drivers/usb/typec/mux/nb7vpq904m.c | 68 +++++++++++++++--------------- 1 file changed, 34 insertions(+), 34 deletions(-)
drivers/usb/typec/mux/nb7vpq904m.c +34 -34
@@ -320,47 +320,47 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7)int ret, i, j; ep =of_graph_get_endpoint_by_regs (nb7->client->dev.of_node,1 ,0 ); +if (!ep) +return 0 ; -if (ep) { - ret =of_property_count_u32_elems (ep,"data-lanes" ); -if (ret == -EINVAL ) -/* Property isn't here, consider default mapping */ - goto out_done; -if (ret <0 ) - goto out_error; - -if (ret !=DATA_LANES_COUNT ) { -dev_err (&nb7->client->dev,"expected 4 data lanes\n" ); - ret = -EINVAL ; - goto out_error; - } - - ret =of_property_read_u32_array (ep,"data-lanes" , data_lanes,DATA_LANES_COUNT ); -if (ret) - goto out_error; + ret =of_property_count_u32_elems (ep,"data-lanes" ); +if (ret == -EINVAL ) +/* Property isn't here, consider default mapping */ + goto out_done; +if (ret <0 ) + goto out_error; + +if (ret !=DATA_LANES_COUNT ) { +dev_err (&nb7->client->dev,"expected 4 data lanes\n" ); + ret = -EINVAL ; + goto out_error; + } -for (i =0 ; i <ARRAY_SIZE (supported_data_lane_mapping); i++) { -for (j =0 ; j <DATA_LANES_COUNT ; j++) { -if (data_lanes[j] != supported_data_lane_mapping[i][j]) -break ; - } + ret =of_property_read_u32_array (ep,"data-lanes" , data_lanes,DATA_LANES_COUNT ); +if (ret) + goto out_error; -if (j ==DATA_LANES_COUNT ) +for (i =0 ; i <ARRAY_SIZE (supported_data_lane_mapping); i++) { +for (j =0 ; j <DATA_LANES_COUNT ; j++) { +if (data_lanes[j] != supported_data_lane_mapping[i][j])break ; } -switch (i) { -case NORMAL_LANE_MAPPING : -break ; -case INVERT_LANE_MAPPING : - nb7->swap_data_lanes = true; -dev_info (&nb7->client->dev,"using inverted data lanes mapping\n" ); +if (j ==DATA_LANES_COUNT )break ; -default : -dev_err (&nb7->client->dev,"invalid data lanes mapping\n" ); - ret = -EINVAL ; - goto out_error; - } + } + +switch (i) { +case NORMAL_LANE_MAPPING : +break ; +case INVERT_LANE_MAPPING : + nb7->swap_data_lanes = true; +dev_info (&nb7->client->dev,"using inverted data lanes mapping\n" ); +break ; +default : +dev_err (&nb7->client->dev,"invalid data lanes mapping\n" ); + ret = -EINVAL ; + goto out_error; } out_done:
Signature · 1 line
2.34.1
Heikki Krogerus
maintainerQuoted 5 lines · sundar
Nitpick, Mostly common path will not be indented. so rewritten this function to check
device_nodepointer is null and removed common path indentation.Signed-off-by sundar <[email protected]>
I don't think that is your full name, or is it?
thanks,
Signature · 1 line
heikki
Quoted 11 lines · Heikki Krogerus
Quoted 5 lines · sundar
Nitpick, Mostly common path will not be indented. so rewritten this function to check
device_nodepointer is null and removed common path indentation.Signed-off-by sundar <[email protected]>I don't think that is your full name, or is it?
thanks,
Hi Heikki,
Sundar is my full name.
Previously, I wrote my name in caps.after changing to small, conflict arises.now I fixed it.
Thanks,
Sundar
Heikki Krogerus
maintainerQuoted 10 lines · sundar
Quoted 9 lines · Heikki Krogerus
Quoted 5 lines · sundar
Nitpick, Mostly common path will not be indented. so rewritten this function to check
device_nodepointer is null and removed common path indentation.Signed-off-by sundar <[email protected]>I don't think that is your full name, or is it?
Quoted 7 lines
Quoted 2 lines
thanks,
Hi Heikki,
Sundar is my full name.
Previously, I wrote my name in caps.after changing to small, conflict arises.now I fixed it.
You need to use your real, full name - what ever your name is in your passport. I find it a bit hard to believe you don't have a family (or given?) name.
Your email returns couple of commits where you're name is "R SUNDAR". What does the "R" stand for?
thanks,
Signature · 1 line
heikki
Quoted 20 lines · Heikki Krogerus
Quoted 10 lines · sundar
Quoted 9 lines · Heikki Krogerus
Quoted 5 lines · sundar
Nitpick, Mostly common path will not be indented. so rewritten this function to check
device_nodepointer is null and removed common path indentation.Signed-off-by sundar <[email protected]>I don't think that is your full name, or is it?
Quoted 7 lines
Quoted 2 lines
thanks,
Hi Heikki,
Sundar is my full name.
Previously, I wrote my name in caps.after changing to small, conflict arises.now I fixed it.
Quoted 9 lines
You need to use your real, full name - what ever your name is in your passport. I find it a bit hard to believe you don't have a family (or given?) name.
Your email returns couple of commits where you're name is "R SUNDAR". What does the "R" stand for?
thanks,
Hi Heikki,
ok, so it will be R Sundar. I will change and send updated patch. R is first letter of father's name.
sorry for inconvenience.
Regards,
Sundar.