Skip to contentSkip to conversation

NFSv4: Don't retry server trunking discovery on timeouts (v2)

PATCH In review Steve Dickson 1 participant 3 messages Mar 7, 2014 – Mar 17, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NFSv4: Don't retry server trunking discovery on timeouts (v2)

To allow background mounts to process into background, server trunking discovery needs to return the -ETIMEDOUT error to the mount command instead of endless retrying in the kernel.

---
 fs/nfs/nfs4state.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfs/nfs4state.c +2 -1
index e1a4721..e0e4d34 100644
@@ -2083,8 +2083,9 @@ again:
 	switch (status) {
 	case 0:
 		break;
-	case -NFS4ERR_DELAY:
 	case -ETIMEDOUT:
+		break;
+	case -NFS4ERR_DELAY:
 	case -EAGAIN:
 		ssleep(1);
 	case -NFS4ERR_STALE_CLIENTID:
Signature · 1 line
1.7.1
#1 lore raw

Trond,

Quoted 6 lines · Steve Dickson

To allow background mounts to process into background, server trunking discovery needs to return the -ETIMEDOUT error to the mount command instead of endless retrying in the kernel.

Any chance of reconsidering this patch? Or come up with a better a way for the kernel to start returning ETIMEOUTS and ECONNREFUSEDs again?

steved.

Quoted 20 lines
---
 fs/nfs/nfs4state.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfs/nfs4state.c +2 -1
index e1a4721..e0e4d34 100644
@@ -2083,8 +2083,9 @@ again:
 	switch (status) {
 	case 0:
 		break;
-	case -NFS4ERR_DELAY:
 	case -ETIMEDOUT:
+		break;
+	case -NFS4ERR_DELAY:
 	case -EAGAIN:
 		ssleep(1);
 	case -NFS4ERR_STALE_CLIENTID:
#2 lore raw
Quoted 8 lines · Steve Dickson

Trond,

Quoted 5 lines · Steve Dickson

To allow background mounts to process into background, server trunking discovery needs to return the -ETIMEDOUT error to the mount command instead of endless retrying in the kernel.

Quoted 4 lines
Quoted 1 line

Any chance of reconsidering this patch? Or come up with a better a way for the kernel to start returning ETIMEOUTS and ECONNREFUSEDs again?

At least in the mount path I should say....

steved.

Quoted 27 lines

steved.

Quoted 10 lines
---
 fs/nfs/nfs4state.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfs/nfs4state.c +0 -0
index e1a4721..e0e4d34 100644

fs/nfs/nfs4state.c again: · line 2091

Quoted 10 lines
fs/nfs/nfs4state.c +2 -1
@@ -2083,8 +2083,9 @@ again:
 	switch (status) {
 	case 0:
 		break;
-	case -NFS4ERR_DELAY:
 	case -ETIMEDOUT:
+		break;
+	case -NFS4ERR_DELAY:
 	case -EAGAIN:
 		ssleep(1);
 	case -NFS4ERR_STALE_CLIENTID:

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html