Skip to contentSkip to conversation

ARM: mvebu: Enable NEON support in defconfig

PATCH New Gregory CLEMENT 3 participants 4 messages Mar 19, 2014 – Mar 20, 2014

Subsystems (2)
Arm (32-bit) Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Gregory CLEMENT

author
#0 lore raw

PATCH 1/1 ARM: mvebu: Enable NEON support in defconfig

CONFIG_NEON is no more turning on unconditionally when Armada 375 or Armada 38x are selected. However we still want it selected for the reference configuration.

Signed-off-by Gregory CLEMENT <[email protected]>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/mvebu_v7_defconfig +1 -0
index 62b6a37626c5..36797dbfa610 100644
@@ -26,6 +26,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
 CONFIG_ARM_ATAG_DTB_COMPAT=y
 CONFIG_VFP=y
+CONFIG_NEON=y
 CONFIG_NET=y
 CONFIG_INET=y
 CONFIG_BT=y
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 ARM: mvebu: Enable NEON support in defconfig

Hi Gregory,

Quoted 14 lines · Gregory CLEMENT

CONFIG_NEON is no more turning on unconditionally when Armada 375 or Armada 38x are selected. However we still want it selected for the reference configuration.

Signed-off-by Gregory CLEMENT <[email protected]>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/mvebu_v7_defconfig +0 -0
index 62b6a37626c5..36797dbfa610 100644

arch/arm/configs/mvebu_v7_defconfig CONFIG_ZBOOT_ROM_BSS=0x0 · line 32

Quoted 7 lines
arch/arm/configs/mvebu_v7_defconfig +1 -0
@@ -26,6 +26,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
 CONFIG_ARM_ATAG_DTB_COMPAT=y
 CONFIG_VFP=y
+CONFIG_NEON=y
 CONFIG_NET=y
 CONFIG_INET=y
 CONFIG_BT=y

Will the lack of support by the hardware be detected automatically (Armada 370 does not have neon support for instance)? Or does the logic relies on the fact that CONFIG_KERNEL_MODE_NEON is disabled?

Cheers,

a+

author
#2 lore raw

PATCH 1/1 ARM: mvebu: Enable NEON support in defconfig

Hi Arnaud,

Quoted 13 lines · Arnaud Ebalard

Hi Gregory,

Quoted 9 lines · Gregory CLEMENT

CONFIG_NEON is no more turning on unconditionally when Armada 375 or Armada 38x are selected. However we still want it selected for the reference configuration.

Signed-off-by Gregory CLEMENT <[email protected]>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

arch/arm/configs/mvebu_v7_defconfig CONFIG_ZBOOT_ROM_BSS=0x0 · line 32

Quoted 12 lines
arch/arm/configs/mvebu_v7_defconfig +1 -0
index 62b6a37626c5..36797dbfa610 100644
@@ -26,6 +26,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_ARM_APPENDED_DTB=y
 CONFIG_ARM_ATAG_DTB_COMPAT=y
 CONFIG_VFP=y
+CONFIG_NEON=y
 CONFIG_NET=y
 CONFIG_INET=y
 CONFIG_BT=y

Will the lack of support by the hardware be detected automatically (Armada 370 does not have neon support for instance)? Or does the

yes the lack of support by the hardware should be detected automatically, whereas if CONFIG_NEON is not selected NEON will never be used even if the hardware is present.

Gregory

Quoted 6 lines

logic relies on the fact that CONFIG_KERNEL_MODE_NEON is disabled?

Cheers,

a+

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 ARM: mvebu: Enable NEON support in defconfig

In reply to Gregory CLEMENT
Quoted 12 lines · Gregory CLEMENT

CONFIG_NEON is no more turning on unconditionally when Armada 375 or Armada 38x are selected. However we still want it selected for the reference configuration.

Signed-off-by Gregory CLEMENT <[email protected]>

---
arch/arm/configs/mvebu_v7_defconfig | 1 +

1 file changed, 1 insertion(+)
Acked-by Jason Cooper <[email protected]>

Arnd,

Mind including this with your series of fixes?

thx,

Jason.

Quoted 15 lines
arch/arm/configs/mvebu_v7_defconfig +0 -0
index 62b6a37626c5..36797dbfa610 100644
@@ -26,6 +26,7 @@ CONFIG_ZBOOT_ROM_BSS=0x0

CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
CONFIG_VFP=y
+CONFIG_NEON=y
CONFIG_NET=y
CONFIG_INET=y
CONFIG_BT=y

Signature · 1 line
1.8.1.2