Skip to contentSkip to conversation

mmc: dw_mmc: exynos: Turn SDIO interrupts on

PATCH Superseded Yuvaraj Kumar C D 4 participants 5 messages Mar 24, 2014 – Apr 23, 2014

Subsystems (3)
Arm Samsung Exynos MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver
lore
Share & tools
lore

Yuvaraj Kumar C D

author
#0 lore raw

PATCH v2 1/1 mmc: dw_mmc: exynos: Turn SDIO interrupts on

The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x.

This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Yuvaraj Kumar C D <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/dw_mmc.c +3 -0
index 0c56faa..240949d 100644
@@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
 	if (of_get_property(np, "cd-inverted", NULL))
 		pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
 
+	if (of_find_property(np, "cap-sdio-irq", NULL))
+		pdata->caps |= MMC_CAP_SDIO_IRQ;
+
 	return pdata;
 }
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

PATCH v2 1/1 mmc: dw_mmc: exynos: Turn SDIO interrupts on

Hi, Yuvaraj.

NACK. we can use "mmc_of_parese()".

I have sent the patch that use "mmc_of_parse()".
https://patchwork.kernel.org/patch/3750681/

Best Regards,
Jaehoon Chung

Quoted 28 lines · Yuvaraj Kumar C D

The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x.

This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Yuvaraj Kumar C D <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/dw_mmc.c +3 -0
index 0c56faa..240949d 100644
@@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
 	if (of_get_property(np, "cd-inverted", NULL))
 		pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
 
+	if (of_find_property(np, "cap-sdio-irq", NULL))
+		pdata->caps |= MMC_CAP_SDIO_IRQ;
+
 	return pdata;
 }
author
#2 lore raw

PATCH v2 1/1 mmc: dw_mmc: exynos: Turn SDIO interrupts on

Quoted 3 lines · Jaehoon Chung

Hi, Yuvaraj.

NACK. we can use "mmc_of_parese()".

Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".

Quoted 37 lines

I have sent the patch that use "mmc_of_parse()".
https://patchwork.kernel.org/patch/3750681/

Best Regards,
Jaehoon Chung

Quoted 28 lines · Yuvaraj Kumar C D

The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x.

This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Yuvaraj Kumar C D <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/dw_mmc.c +3 -0
index 0c56faa..240949d 100644
@@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
      if (of_get_property(np, "cd-inverted", NULL))
              pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
 
+     if (of_find_property(np, "cap-sdio-irq", NULL))
+             pdata->caps |= MMC_CAP_SDIO_IRQ;
+
      return pdata;
 }
#3 lore raw

PATCH v2 1/1 mmc: dw_mmc: exynos: Turn SDIO interrupts on

Hi Yuvaraj,

Quoted 5 lines · Yuvaraj Kumar
Quoted 3 lines · Jaehoon Chung

Hi, Yuvaraj.

NACK. we can use "mmc_of_parese()".

Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".

Are you planning to re-spin this patch? Now Jaehoon's changes for using mmc_of_parse() is landed in mmc-next.
Thanks!!

Quoted 41 lines
Quoted 29 lines

I have sent the patch that use "mmc_of_parse()".
https://patchwork.kernel.org/patch/3750681/

Best Regards,
Jaehoon Chung

Quoted 21 lines · Yuvaraj Kumar C D

The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x.

This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Yuvaraj Kumar C D <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/dw_mmc.c +0 -0
index 0c56faa..240949d 100644
@@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
      if (of_get_property(np, "cd-inverted", NULL))
              pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
Quoted 8 lines

drivers/mmc/host/dw_mmc.c static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) · line 2425

Quoted 7 lines
drivers/mmc/host/dw_mmc.c +3 -0
+     if (of_find_property(np, "cap-sdio-irq", NULL))
+             pdata->caps |= MMC_CAP_SDIO_IRQ;
+
      return pdata;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Regards,
Alim
#4 lore raw

PATCH v2 1/1 mmc: dw_mmc: exynos: Turn SDIO interrupts on

Quoted 10 lines · Alim Akhtar

Hi Yuvaraj,

Quoted 5 lines · Yuvaraj Kumar
Quoted 3 lines · Jaehoon Chung

Hi, Yuvaraj.

NACK. we can use "mmc_of_parese()".

Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".

Are you planning to re-spin this patch? Now Jaehoon's changes for using mmc_of_parse() is landed in mmc-next.

As its already added mmc_of_parse(),no respin of this. Just we need to use it in DT.

Quoted 53 lines

Thanks!!

Quoted 37 lines
Quoted 29 lines

I have sent the patch that use "mmc_of_parse()".
https://patchwork.kernel.org/patch/3750681/

Best Regards,
Jaehoon Chung

Quoted 21 lines · Yuvaraj Kumar C D

The mmc part in exynos supports SDIO interrupts and they work fine, so turn the capability on. With this I see download speeds increase about 10x.

This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Yuvaraj Kumar C D <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/dw_mmc.c +0 -0
index 0c56faa..240949d 100644
@@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
      if (of_get_property(np, "cd-inverted", NULL))
              pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
Quoted 8 lines

drivers/mmc/host/dw_mmc.c static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) · line 2425

Quoted 7 lines
drivers/mmc/host/dw_mmc.c +3 -0
+     if (of_find_property(np, "cap-sdio-irq", NULL))
+             pdata->caps |= MMC_CAP_SDIO_IRQ;
+
      return pdata;
 }
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Regards,
Alim

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel