libsoup-2.4: upgrade to 2.45.92

PATCH In review Hongxu Jia 2 participants 7 messages Mar 24, 2014 – Mar 25, 2014

lore

Share & tools

lore

Hongxu Jia

author

2014-03-24 07:40 UTC #0 lore raw

cover libsoup-2.4: upgrade to 2.45.92

The following changes since commit 49aad7da07e187f206e963001844605731b01247:

bitbake: runqueue: Remove use of waitpid on worker processes (2014-03-19 17:46:33 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-libsoup
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-libsoup

Hongxu Jia (1):
libsoup-2.4: upgrade to 2.45.92

 .../libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb}         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-support/libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb} (85%)

Signature · 1 line

1.8.1.2

Hongxu Jia

author

2014-03-24 07:40 UTC #1 lore raw

PATCH 1/1 libsoup-2.4: upgrade to 2.45.92

There was a error about mips-gcc optimization while building libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92 have fixed this issue.

[YOCTO #5512]

Signed-off-by Hongxu Jia <[email protected]>

---
 .../libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb}         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-support/libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb} (85%)

meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb renamed from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb +2 -2

similarity index 85%
rename from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
rename to meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
index b1199d8..f3a2617 100644
@@ -17,8 +17,8 @@ PACKAGECONFIG[gnome] = "--with-gnome,--without-gnome"
 SHRT_VER = "${@bb.data.getVar('PV',d,1).split('.')[0]}.${@bb.data.getVar('PV',d,1).split('.')[1]}"
 SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz"
 
-SRC_URI[md5sum] = "fe7ec04784c6b97c5f8ea963c8542f59"
-SRC_URI[sha256sum] = "6ac317b931efd2cff9cdea7122987acb3ecb0c32564a9441ba72e5cce021aa12"
+SRC_URI[md5sum] = "d72623f2baac7f58d1295c0b6ae7cd35"
+SRC_URI[sha256sum] = "d34f4b41eec99ecf082783f842a29e712e7a78e83f4cd2a060b9de64377d21d8"
 
 S = "${WORKDIR}/libsoup-${PV}"

Signature · 1 line

1.8.1.2

Hongxu Jia

author

2014-03-24 07:58 UTC #2 lore raw

Quoted 3 lines · Hongxu Jia

There was a error about mips-gcc optimization while building libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92 have fixed this issue.

Update the comments to make a clarity.

libsoup-2.4: upgrade to 2.45.92

There was an error about mips-gcc optimization while compiling libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.

The test code of libsoup-2.4 2.45.3 triggered gcc assert which located in gcc/dwarf2out.c:20810:
...
20806 gcc_assert (prev
20807 && (CALL_P (prev)
20808 || (NONJUMP_INSN_P (prev)
20809 && GET_CODE (PATTERN (prev)) == SEQUENCE
20810 && CALL_P (XVECEXP (PATTERN (prev), 0, 0)))));
...

The issue test code is the C function 'do_qvalue_tests' located in tests/header-parsing.c.

The 2.45.92 have refactored the test code and this issue has been fixed.

[YOCTO #5512]

//Hongxu

Quoted 25 lines

[YOCTO #5512]

Signed-off-by Hongxu Jia <[email protected]>

---
  .../libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb}         | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

rename meta/recipes-support/libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb} (85%)

meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb renamed from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb +2 -2

similarity index 85%
rename from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
rename to meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
index b1199d8..f3a2617 100644
@@ -17,8 +17,8 @@ PACKAGECONFIG[gnome] = "--with-gnome,--without-gnome"
  SHRT_VER = "${@bb.data.getVar('PV',d,1).split('.')[0]}.${@bb.data.getVar('PV',d,1).split('.')[1]}"
  SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz"
 
-SRC_URI[md5sum] = "fe7ec04784c6b97c5f8ea963c8542f59"
-SRC_URI[sha256sum] = "6ac317b931efd2cff9cdea7122987acb3ecb0c32564a9441ba72e5cce021aa12"
+SRC_URI[md5sum] = "d72623f2baac7f58d1295c0b6ae7cd35"
+SRC_URI[sha256sum] = "d34f4b41eec99ecf082783f842a29e712e7a78e83f4cd2a060b9de64377d21d8"
 
  S = "${WORKDIR}/libsoup-${PV}"

Burton, Ross

2014-03-24 09:06 UTC #3 lore raw

Quoted 13 lines · Hongxu Jia

There was an error about mips-gcc optimization while compiling libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.
The test code of libsoup-2.4 2.45.3 triggered gcc assert which located in gcc/dwarf2out.c:20810:
...
20806 gcc_assert (prev
20807 && (CALL_P (prev)
20808 || (NONJUMP_INSN_P (prev)
20809 && GET_CODE (PATTERN (prev)) == SEQUENCE
20810 && CALL_P (XVECEXP (PATTERN (prev), 0,
0)))));
...

So you've a bug in gcc and a well defined way of replicating it, presumably you've reported this to gcc as that's the proper fix here?

Ross

Hongxu Jia

author

2014-03-25 04:13 UTC #4 lore raw

Quoted 14 lines · Ross

Quoted 13 lines · Hongxu Jia
There was an error about mips-gcc optimization while compiling libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.
The test code of libsoup-2.4 2.45.3 triggered gcc assert which located in gcc/dwarf2out.c:20810:
...
20806 gcc_assert (prev
20807 && (CALL_P (prev)
20808 || (NONJUMP_INSN_P (prev)
20809 && GET_CODE (PATTERN (prev)) == SEQUENCE
20810 && CALL_P (XVECEXP (PATTERN (prev), 0,
0)))));
...

Quoted 2 lines

So you've a bug in gcc and a well defined way of replicating it, presumably you've reported this to gcc as that's the proper fix here?

Yes, file a bug in gcc:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=6034

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60643

//Hongxu

Quoted 1 line

Ross

Burton, Ross

2014-03-24 08:09 UTC #5 lore raw

In reply to Hongxu Jia

Quoted 3 lines · Hongxu Jia

There was a error about mips-gcc optimization while building libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92 have fixed this issue.

.92 means "beta release" in GNOME versioning, so not only is this a new upstream release (when we've frozen) but it's also not a stable release. Please backport the patch instead of upgrading.

Ross

Hongxu Jia

author

2014-03-24 08:15 UTC #6 lore raw

Quoted 7 lines · Ross

Quoted 3 lines · Hongxu Jia
There was a error about mips-gcc optimization while building libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92 have fixed this issue.
.92 means "beta release" in GNOME versioning, so not only is this a new upstream release (when we've frozen) but it's also not a stable release. Please backport the patch instead of upgrading.

OK, I will backport to 2.45.3

//Hongxu

Quoted 2 lines

Ross