Skip to contentSkip to conversation

kbuild: unconditionally clobber include/linux/version.h on distclean

PATCH In review Paul Gortmaker 3 participants 3 messages Feb 13, 2014 – Mar 29, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: unconditionally clobber include/linux/version.h on distclean

As of v3.7, the UAPI changes relocated headers around such that the kernel version header lived in a new place.

If a person is bisecting and if you go back to pre-UAPI days, you will create an include/linux/version.h -- then if you checkout a post-UAPI kernel, and even run "make distclean" it still won't delete that old version file. So you get a situation like this:

$ grep -R LINUX_VERSION_CODE include/
include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
include/linux/version.h:#define LINUX_VERSION_CODE 132646

The value in that second line is representative of a v2.6.38 version. And it will be sourced/used, hence leading to strange behaviours, such as drivers/staging content (which typically hasn't been purged of version ifdefs) failing to build.

Since it is a subtle mode of failure, lets always clobber the old file when doing a distclean.

Cc Michal Marek <[email protected]>
Cc David Howells <[email protected]>
Makefile +1 -1
index fd6a01ed9ab9..1342363ca10d 100644
@@ -1071,7 +1071,7 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
 		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
 		  signing_key.priv signing_key.x509 x509.genkey		\
 		  extra_certificates signing_key.x509.keyid		\
-		  signing_key.x509.signer
+		  signing_key.x509.signer include/linux/version.h
 
 # clean - Delete most, but leave enough to build external modules
 #
Signature · 1 line
1.8.5.2
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Paul Gortmaker

As of v3.7, the UAPI changes relocated headers around such that the kernel version header lived in a new place.

If a person is bisecting and if you go back to pre-UAPI days, you will create an include/linux/version.h -- then if you checkout a post-UAPI kernel, and even run "make distclean" it still won't delete that old version file. So you get a situation like this:

$ grep -R LINUX_VERSION_CODE include/
include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
include/linux/version.h:#define LINUX_VERSION_CODE 132646

The value in that second line is representative of a v2.6.38 version. And it will be sourced/used, hence leading to strange behaviours, such as drivers/staging content (which typically hasn't been purged of version ifdefs) failing to build.

Quoted 6 lines

Since it is a subtle mode of failure, lets always clobber the old file when doing a distclean.

Cc Michal Marek <[email protected]>
Cc David Howells <[email protected]>
#2 lore raw
In reply to Paul Gortmaker

Dne 13.2.2014 22:28, Paul Gortmaker napsal(a):

Quoted 17 lines

As of v3.7, the UAPI changes relocated headers around such that the kernel version header lived in a new place.

If a person is bisecting and if you go back to pre-UAPI days, you will create an include/linux/version.h -- then if you checkout a post-UAPI kernel, and even run "make distclean" it still won't delete that old version file. So you get a situation like this:

$ grep -R LINUX_VERSION_CODE include/
include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
include/linux/version.h:#define LINUX_VERSION_CODE 132646

The value in that second line is representative of a v2.6.38 version. And it will be sourced/used, hence leading to strange behaviours, such as drivers/staging content (which typically hasn't been purged of version ifdefs) failing to build.

Quoted 6 lines

Since it is a subtle mode of failure, lets always clobber the old file when doing a distclean.

Cc Michal Marek <[email protected]>
Cc David Howells <[email protected]>

Applied to kbuild.git, sorry for the delay. I'm curious how long will it take until somebody posts a cleanup patch removing the obsolete include/linux/version.h reference...

Michal