net: bcmgenet: Ensure MDIO unregistration has clocks enabled
Subsystems (3)
Florian Fainelli
maintainerPATCH 1/1 net: bcmgenet: Ensure MDIO unregistration has clocks enabled
With support for Ethernet PHY LEDs having been added, while unregistering a MDIO bus and its child device liks PHYs there may be "late" accesses to the MDIO bus. One typical use case is setting the PHY LEDs brightness to OFF for instance.
We need to ensure that the MDIO bus controller remains entirely functional since it runs off the main GENET adapter clock.
--- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/broadcom/genet/bcmmii.c +2 -0
@@ -668,5 +668,7 @@ void bcmgenet_mii_exit(struct net_device *dev)if (of_phy_is_fixed_link (dn))of_phy_deregister_fixed_link (dn);of_node_put (priv->phy_dn); +clk_prepare_enable (priv->clk);platform_device_unregister (priv->mii_pdev); +clk_disable_unprepare (priv->clk); }
Signature · 1 line
2.34.1
Quoted 7 lines · Florian Fainelli
With support for Ethernet PHY LEDs having been added, while unregistering a MDIO bus and its child device liks PHYs there may be "late" accesses to the MDIO bus. One typical use case is setting the PHY LEDs brightness to OFF for instance.
We need to ensure that the MDIO bus controller remains entirely functional since it runs off the main GENET adapter clock.
So this clock is enabled in bcmgenet_open() and disabled in bcmgenet_close(). The assumption being, the MDIO bus is only used when the interface is up.
How does this work when there is an MDIO based switch attached? I had similar problems with the FEC and mv88e6xxx. DSA would try to talk to the switch with the master interface down, and MDIO would time out. I needed to add runtime PM support to the MDIO bus ops.
Andrew
Florian Fainelli
maintainerQuoted 9 lines · Andrew Lunn
Quoted 7 lines · Florian Fainelli
With support for Ethernet PHY LEDs having been added, while unregistering a MDIO bus and its child device liks PHYs there may be "late" accesses to the MDIO bus. One typical use case is setting the PHY LEDs brightness to OFF for instance.
We need to ensure that the MDIO bus controller remains entirely functional since it runs off the main GENET adapter clock.
Quoted 8 lines
So this clock is enabled in
bcmgenet_open()and disabled inbcmgenet_close(). The assumption being, the MDIO bus is only used when the interface is up.How does this work when there is an MDIO based switch attached? I had similar problems with the FEC and mv88e6xxx. DSA would try to talk to the switch with the master interface down, and MDIO would time out. I needed to add runtime PM support to the MDIO bus ops.
We do not have that configuration to support today, and given the way that we do register the MDIO bus, it could actually be a bit challenging to support DSA here, I might still have a board around to test, one day.
Passing the clock to the MDIO driver does require quite a bit of restructuring in the driver such that the clock is only acquired around mii_bus::write and read operations, otherwise the clock remains constantly enabled, even if the network device is brought down, which burns power unnecessarily.
Since this is a fix, I went with the more targeted approach here.
Signature · 1 line
Florian
Andrew Lunn
Reviewed-byQuoted 1 line
Since this is a fix, I went with the more targeted approach here.
Yes, this is fine for stable.
Andrew
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 22 Jun 2023 03:31:07 -0700 you wrote:
With support for Ethernet PHY LEDs having been added, while unregistering a MDIO bus and its child device liks PHYs there may be "late" accesses to the MDIO bus. One typical use case is setting the PHY LEDs brightness to OFF for instance.
We need to ensure that the MDIO bus controller remains entirely functional since it runs off the main GENET adapter clock.
[...]
Here is the summary with links:
- [net] net: bcmgenet: Ensure MDIO unregistration has clocks enabled
https://git.kernel.org/netdev/net/c/1b5ea7ffb7a3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html