Skip to contentSkip to conversation

block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

PATCH In review Kevin Wolf 2 participants 2 messages Apr 4, 2014

lore
Share & tools
lore

Kevin Wolf

author
#0 lore raw

PATCH 1/1 block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

Signed-off-by Kevin Wolf <[email protected]>
---
 block.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
block.c +6 -1
index d89c344..990a754 100644
@@ -1184,7 +1184,12 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs, Error **errp)
        instead of opening 'filename' directly */
 
     /* Get the required size from the image */
-    total_size = bdrv_getlength(bs) & BDRV_SECTOR_MASK;
+    total_size = bdrv_getlength(bs);
+    if (total_size < 0) {
+        error_setg_errno(errp, -total_size, "Could not get image size");
+        return;
+    }
+    total_size &= BDRV_SECTOR_MASK;
 
     /* Create the temporary image */
     ret = get_tmp_filename(tmp_filename, sizeof(tmp_filename));
Signature · 1 line
1.8.3.1