Skip to contentSkip to conversation

host-binutils broken?

Buildroot Vincent Stehlé 4 participants 9 messages Apr 4, 2014 – Apr 5, 2014

lore
Share & tools
lore

Vincent Stehlé

author
#0 lore raw

Hi,

FYI it seems the following recent commit broke compilation of host-binutils (2.22 in my case) when compiling for e.g. raspberrypi_defconfig:

6acb2e1 binutils: backport gas xtensa jump trampolines

If I revert it, host-binutils builds fine.

Best regards,

V.

#1 lore raw

Hi Vincent,

Quoted 6 lines · Vincent Stehl?

FYI it seems the following recent commit broke compilation of host-binutils (2.22 in my case) when compiling for e.g. raspberrypi_defconfig:

6acb2e1 binutils: backport gas xtensa jump trampolines

If I revert it, host-binutils builds fine.

I couldn't reproduce it, the following steps complete successfully for me:

$ git checkout f90760fe0ed7317510bc6f44c5508e2072ed217d
$ mkdir ../build
$ make O=`pwd`/../build raspberrypi_defconfig
$ make O=`pwd`/../build toolchain

Could you please share your .config and build log?

Signature · 2 lines
Thanks.
-- Max
#2 lore raw
Quoted 1 line · Max Filippov

I couldn't reproduce it,

(..)

Quoted 1 line

Could you please share your .config and build log?

Hi Max,

Thanks for looking into this issue. I could reproduce it at home in the following way:

  $ git clean -fdx
  $ git checkout f90760fe0ed7317510bc6f44c5508e2072ed217d
  $ make raspberrypi_defconfig
  $ make |& tee log

It "chokes" when making as.info, during install-am.

Here is the log: http://pastebin.com/nsUjcZXf
And here is the .config: http://pastebin.com/cyuKb9yA

Best regards,

V.

#3 lore raw
Quoted 9 lines · Vincent Stehl?

Thanks for looking into this issue. I could reproduce it at home in the following way:

  $ git clean -fdx
  $ git checkout f90760fe0ed7317510bc6f44c5508e2072ed217d
  $ make raspberrypi_defconfig
  $ make |& tee log

It "chokes" when making as.info, during install-am.

Doesn't produce even a single warning for me... What's your makeinfo version?

Quoted 2 lines

Here is the log: http://pastebin.com/nsUjcZXf
And here is the .config: http://pastebin.com/cyuKb9yA

Signature · 2 lines
Thanks.
-- Max
#4 lore raw

On 04/05/2014 12:46 AM, Max Filippov wrote:
(..)

Quoted 1 line

Doesn't produce even a single warning for me...

Hi Max,

Thanks for re-trying. You are lucky that it works for you :)

Quoted 1 line

What's your makeinfo version?

This is:

makeinfo (GNU texinfo) 5.2

...on debian testing, from package texinfo 5.2.0.dfsg.1-2.

Does this call for a host-texinfo / host-makeinfo package?

Best regards,

V.

#5 lore raw

Dear Vincent,

Quoted 11 lines · Vincent

Thanks for re-trying. You are lucky that it works for you :)

Quoted 1 line

What's your makeinfo version?

This is:

makeinfo (GNU texinfo) 5.2

...on debian testing, from package texinfo 5.2.0.dfsg.1-2.

Does this call for a host-texinfo / host-makeinfo package?

We already have, and in some situations, binutils depends on it:

ifeq ($(BINUTILS_FROM_GIT),y)
BINUTILS_DEPENDENCIES += host-texinfo host-flex host-bison HOST_BINUTILS_DEPENDENCIES += host-texinfo host-flex host-bison endif

I believe what's happening is that the patches added by Max are making certain files newer, which triggers a rebuild of the documentation in binutils, which normally doesn't happen with release tarballs.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw
In reply to Vincent
Quoted 7 lines · Vincent
Quoted 1 line · Max Filippov

What's your makeinfo version?

This is:

makeinfo (GNU texinfo) 5.2

...on debian testing, from package texinfo 5.2.0.dfsg.1-2.

Ok, I'll try this version (I currently have 4.13 on build machine).

Quoted 1 line

Does this call for a host-texinfo / host-makeinfo package?

Signature · 2 lines
Thanks.
-- Max
#7 lore raw
Quoted 10 lines · Max Filippov
Quoted 7 lines · Vincent
Quoted 1 line · Max Filippov

What's your makeinfo version?

This is:

makeinfo (GNU texinfo) 5.2

...on debian testing, from package texinfo 5.2.0.dfsg.1-2.

Ok, I'll try this version (I currently have 4.13 on build machine).

Yes, now make as.info fails for me too. However, it fails for me both with and without
my patch. Seems to me the easiest fix would be to drop *.texi hunks from my patch to binutils to just avoid as.info rebuild. Ok?

Signature · 2 lines
Thanks.
-- Max
#8 lore raw

Dear Max Filippov,

Quoted 4 lines · Max Filippov

Yes, now make as.info fails for me too. However, it fails for me both with and without
my patch. Seems to me the easiest fix would be to drop *.texi hunks from my patch to binutils to just avoid as.info rebuild. Ok?

Sounds good. Can you send a followup patch that does this?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com