Skip to contentSkip to conversation

v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.

PATCH In review Mike Sampson 2 participants 2 messages Apr 3, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.

This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?

---
 drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/workitem.c +1 -1
index ba16fd5..0a03bf7 100644
@@ -75,7 +75,7 @@ typedef struct cfs_wi_sched {
 	char			ws_name[CFS_WS_NAME_LEN];
 } cfs_wi_sched_t;
 
-struct cfs_workitem_data {
+static struct cfs_workitem_data {
 	/** serialize */
 	spinlock_t		wi_glock;
 	/** list of all schedulers */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Mike Sampson

This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?

Patch is ok. Signed off should go at the end instead of at the start of the commit message. The subject should be:

[PATCH] Staging: lustre: mark a variable static in workitem.c

Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a better prefix. Btw, for these kinds of changes, then you should be working against -next.

regards,
dan carpenter