Skip to contentSkip to conversation

Staging: lustre: mark a variable static in workitem.c

PATCH Superseded Mike Sampson 2 participants 2 messages Apr 4, 2014 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: lustre: mark a variable static in workitem.c

next-20140403: This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?

---
 drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/workitem.c +1 -1
index ba16fd5..0a03bf7 100644
@@ -75,7 +75,7 @@ typedef struct cfs_wi_sched {
 	char			ws_name[CFS_WS_NAME_LEN];
 } cfs_wi_sched_t;
 
-struct cfs_workitem_data {
+static struct cfs_workitem_data {
 	/** serialize */
 	spinlock_t		wi_glock;
 	/** list of all schedulers */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Mike Sampson

next-20140403: This fixes a sparse warning:

^^^^^^^^^^^^^

Just leave this out. Either it applies when Greg gets around to it, or you'll have to redo it. If you want to add this information then put it directly after the --- cut off line so it doesn't show up in the permanent commit log.

The subject should have a [PATCH v2] because this is a second version.

After the --- write:
---
v2: updated the changelog

regards,
dan carpenter