ARM: dts: keystone: add cell's information to i2c nodes
PATCH 1/1 ARM: dts: keystone: add cell's information to i2c nodes
I2C nodes should always have #address-cells and #size-cells defined. Hence, ensure that all i2cX nodes have #address-cells and #size-cells properties defined.
--- arch/arm/boot/dts/keystone.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/keystone.dtsi +4 -0
@@ -115,6 +115,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; i2c2: i2c at 2530800 {
@@ -123,6 +125,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; spi0: spi at 21000400 {
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: dts: keystone: add cell's information to i2c nodes
Quoted 6 lines · Grygorii Strashko
I2C nodes should always have #address-cells and #size-cells defined. Hence, ensure that all i2cX nodes have #address-cells and #size-cells properties defined.
Signed-off-by Grygorii Strashko <[email protected]>---
Right. BTW, have you seen some issue without this patch ? Just curious what prompted you to create this patch and whether it needs to be sent as fix during rc's.
Regards,
Santosh
PATCH 1/1 ARM: dts: keystone: add cell's information to i2c nodes
Quoted 10 lines · Santosh Shilimkar
Quoted 6 lines · Grygorii Strashko
I2C nodes should always have #address-cells and #size-cells defined. Hence, ensure that all i2cX nodes have #address-cells and #size-cells properties defined.
Signed-off-by Grygorii Strashko <[email protected]>---
Right. BTW, have you seen some issue without this patch ? Just curious what prompted you to create this patch and whether it needs to be sent as fix during rc's.
I think, it can wait for next. Without this patch warnings will
be produced in case of adding child node to the bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c at 2530800/pca at 20 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c at 2530800/pca at 20
I'll updated patch description and resend.
Regards,
-grygorii