Skip to contentSkip to conversation

btrfs: remove useless ACL check

PATCH New ZhangZhen 1 participant 1 message Apr 8, 2014 1 message not in the archive Btrfs file system

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

ZhangZhen

author
#1 lore raw

PATCH 1/1 btrfs: remove useless ACL check

posix_acl_xattr_set() already does the check, and it's the only way to feed in an ACL from userspace.
So the check here is useless, remove it.

---
 fs/btrfs/acl.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
fs/btrfs/acl.c +0 -7
index ff9b399..9a0124a 100644
@@ -79,13 +79,6 @@ static int __btrfs_set_acl(struct btrfs_trans_handle *trans,
 	const char *name;
 	char *value = NULL;
 
-	if (acl) {
-		ret = posix_acl_valid(acl);
-		if (ret < 0)
-			return ret;
-		ret = 0;
-	}
-
 	switch (type) {
 	case ACL_TYPE_ACCESS:
 		name = POSIX_ACL_XATTR_ACCESS;
Signature · 4 lines
1.6.0.2


.