ARM: dts: keystone: i2c updates
v2 cover ARM: dts: keystone: i2c updates
Hi Santosh,
There are two small non critical fixes for Keystone 2 I2C DT definitions.
Changes in v2;
- added additional patch to move i2c0 device node from SoC to board files
- updated commits messages
Grygorii Strashko (2):
ARM: dts: keystone: add cell's information to i2c nodes
ARM: dts: keystone: move i2c0 device node from SoC to board files
arch/arm/boot/dts/k2e-evm.dts | 7 +++++++ arch/arm/boot/dts/k2hk-evm.dts | 7 +++++++ arch/arm/boot/dts/k2l-evm.dts | 7 +++++++ arch/arm/boot/dts/keystone.dtsi | 9 ++++----- 4 files changed, 25 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v2 1/2 ARM: dts: keystone: add cell's information to i2c nodes
I2C nodes should always have #address-cells and #size-cells defined,
otherwise warnings will be produced in case of adding child
nodes to the I2C bus in DT:
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c at 2530800/pca at 20 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c at 2530800/pca at 20
Hence, ensure that all i2cX nodes have #address-cells and #size-cells properties defined.
--- arch/arm/boot/dts/keystone.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/keystone.dtsi +4 -0
@@ -115,6 +115,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; i2c2: i2c at 2530800 {
@@ -123,6 +125,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; spi0: spi at 21000400 {
Signature · 1 line
1.7.9.5
PATCH v2 2/2 ARM: dts: keystone: move i2c0 device node from SoC to board files
In reply to Grygorii StrashkoI2C devices are not the part of Keystone SoC and have to be defined in board DTS files.
Hence, move i2c0 EEPROM device node from Keystone SoC to k2hk, k2e, k2l EVM files as they all have similar EEPROM SoCs installed.
--- arch/arm/boot/dts/k2e-evm.dts | 7 +++++++ arch/arm/boot/dts/k2hk-evm.dts | 7 +++++++ arch/arm/boot/dts/k2l-evm.dts | 7 +++++++ arch/arm/boot/dts/keystone.dtsi | 5 ----- 4 files changed, 21 insertions(+), 5 deletions(-)
arch/arm/boot/dts/k2e-evm.dts +7 -0
@@ -58,3 +58,10 @@ &usb1 { status = "okay"; }; + +&i2c0 { + dtt at 50 { + compatible = "at,24c1024"; + reg = <0x50>; + }; +};
arch/arm/boot/dts/k2hk-evm.dts +7 -0
@@ -138,3 +138,10 @@ }; }; }; + +&i2c0 { + dtt at 50 { + compatible = "at,24c1024"; + reg = <0x50>; + }; +};
arch/arm/boot/dts/k2l-evm.dts +7 -0
@@ -35,3 +35,10 @@ &usb { status = "okay"; }; + +&i2c0 { + dtt at 50 { + compatible = "at,24c1024"; + reg = <0x50>; + }; +};
arch/arm/boot/dts/keystone.dtsi +0 -5
@@ -102,11 +102,6 @@ interrupts = <GIC_SPI 283 IRQ_TYPE_EDGE_RISING>; #address-cells = <1>; #size-cells = <0>; - - dtt at 50 { - compatible = "at,24c1024"; - reg = <0x50>; - }; }; i2c1: i2c at 2530400 {
Signature · 1 line
1.7.9.5
v2 cover ARM: dts: keystone: i2c updates
In reply to Grygorii StrashkoQuoted 8 lines · Grygorii
Hi Santosh,
There are two small non critical fixes for Keystone 2 I2C DT definitions.
Changes in v2;
- added additional patch to move i2c0 device node from SoC to board files
- updated commits messages
Thanks. I shall pick these up for 3.16.
Regards,
Santosh