Skip to contentSkip to conversation

modpost: Fix ressource leak in read_dump()

PATCH In review Christian Engelmayer 4 participants 4 messages Apr 5, 2014 – Apr 22, 2014 Kbuild

lore
Share & tools
lore

Christian Engelmayer

author
#0 lore raw

PATCH 1/1 modpost: Fix ressource leak in read_dump()

Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419

Signed-off-by Christian Engelmayer <[email protected]>

---
Compile tested - Applies against v3.14 as well as linux-next.

---
 scripts/mod/modpost.c | 2 ++
 1 file changed, 2 insertions(+)
scripts/mod/modpost.c +2 -0
index 0663556..ea3e2bd 100644
@@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel)
 		s->preloaded = 1;
 		sym_update_crc(symname, mod, crc, export_no(export));
 	}
+	release_file(file, size);
 	return;
 fail:
+	release_file(file, size);
 	fatal("parse error in symbol dump file\n");
 }
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 3 lines · Christian Engelmayer

Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419

It doesn't matter at all. All memory is freed on exit() in this program.

-Andi

#2 lore raw
Quoted 6 lines · Andi Kleen
Quoted 3 lines · Christian Engelmayer

Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419

It doesn't matter at all. All memory is freed on exit() in this program.

The leak can disturb in valgrind output.

Michal

#3 lore raw
Quoted 9 lines · Michal Marek
Quoted 6 lines · Andi Kleen
Quoted 3 lines · Christian Engelmayer

Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419

It doesn't matter at all. All memory is freed on exit() in this program.

The leak can disturb in valgrind output.

Yeah. If release_file() didn't exist at all, I'd agree with Andi. As it is, I've queued the patch (with typo in title fixed).

Thanks!
Rusty.