f2fs: some fix and cleanup about flush_merge

PATCH In review Gu Zheng 2 participants 4 messages Apr 11, 2014 – Apr 14, 2014 VFS

Share & tools

Gu Zheng

author

2014-04-11 09:49 UTC #0 lore raw

cover f2fs: some fix and cleanup about flush_merge

Gu Zheng (7):
f2fs: put the bio when issue_flush completed
f2fs: remove the unuseful "issue_tail" list
f2fs: use __GFP_ZERO to avoid appending set-NULL
f2fs: enable flush_merge only in f2fs is not read-only
f2fs: add the flush_merge handle in the remount flow
f2fs: introduce struct flush_cmd_control to wrap the flush_merge
fields
f2fs: introduce help function {create,destroy}_flush_cmd_control

 fs/f2fs/f2fs.h    |   17 ++++++---
 fs/f2fs/segment.c |  102 +++++++++++++++++++++++++++++++++++-----------------
 fs/f2fs/super.c   |   32 ++++++++++++++--
 3 files changed, 107 insertions(+), 44 deletions(-)

Signature · 10 lines

1.7.7



------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees

Gu Zheng

author

2014-04-14 01:18 UTC #1 lore raw

Hi All,
There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list", and the whole patchset needs to be reworked. So please ignore this one. Sorry for the noise.

Regards,
Gu

Quoted 10 lines · Gu Zheng

Gu Zheng (7):
f2fs: put the bio when issue_flush completed
f2fs: remove the unuseful "issue_tail" list
f2fs: use __GFP_ZERO to avoid appending set-NULL
f2fs: enable flush_merge only in f2fs is not read-only
f2fs: add the flush_merge handle in the remount flow
f2fs: introduce struct flush_cmd_control to wrap the flush_merge
fields
f2fs: introduce help function {create,destroy}_flush_cmd_control

Quoted 5 lines

 fs/f2fs/f2fs.h    |   17 ++++++---
 fs/f2fs/segment.c |  102 +++++++++++++++++++++++++++++++++++-----------------
 fs/f2fs/super.c   |   32 ++++++++++++++--
 3 files changed, 107 insertions(+), 44 deletions(-)

Jaegeuk Kim

2014-04-14 01:44 UTC #2 lore raw

Hi Gu,

I just started to review the patches and merge them individually though. Since I've been internally doing in my local tree, so that should be no problem. I'll roll back to the latest point.
Anyway, thank you for your work. :)

2014-04-14 (월), 09:18 +0800, Gu Zheng:

Quoted 30 lines

Hi All,
There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list", and the whole patchset needs to be reworked. So please ignore this one. Sorry for the noise.
Regards,
Gu
Quoted 10 lines · Gu Zheng
Gu Zheng (7):
f2fs: put the bio when issue_flush completed
f2fs: remove the unuseful "issue_tail" list
f2fs: use __GFP_ZERO to avoid appending set-NULL
f2fs: enable flush_merge only in f2fs is not read-only
f2fs: add the flush_merge handle in the remount flow
f2fs: introduce struct flush_cmd_control to wrap the flush_merge
fields
f2fs: introduce help function {create,destroy}_flush_cmd_control
Quoted 5 lines
 fs/f2fs/f2fs.h    |   17 ++++++---
 fs/f2fs/segment.c |  102 +++++++++++++++++++++++++++++++++++-----------------
 fs/f2fs/super.c   |   32 ++++++++++++++--
 3 files changed, 107 insertions(+), 44 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 15 lines

Jaegeuk Kim
Samsung



------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Gu Zheng

author

2014-04-14 01:48 UTC #3 lore raw

Quoted 5 lines · Jaegeuk Kim

Hi Gu,
I just started to review the patches and merge them individually though. Since I've been internally doing in my local tree, so that should be no problem. I'll roll back to the latest point.

OK, and please pay some attention to the flush cmds merging operation when doing tests, it seems that some of the outstanding flush cmds(in the issue_list) will be ignored when new cmd added.
I'll review and test it more.

Quoted 1 line

Anyway, thank you for your work. :)

Regards,
Gu

Quoted 33 lines

2014-04-14 (월), 09:18 +0800, Gu Zheng:
Quoted 30 lines
Hi All,
There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list", and the whole patchset needs to be reworked. So please ignore this one. Sorry for the noise.
Regards,
Gu
Quoted 10 lines · Gu Zheng
Gu Zheng (7):
f2fs: put the bio when issue_flush completed
f2fs: remove the unuseful "issue_tail" list
f2fs: use __GFP_ZERO to avoid appending set-NULL
f2fs: enable flush_merge only in f2fs is not read-only
f2fs: add the flush_merge handle in the remount flow
f2fs: introduce struct flush_cmd_control to wrap the flush_merge
fields
f2fs: introduce help function {create,destroy}_flush_cmd_control
Quoted 5 lines
 fs/f2fs/f2fs.h    |   17 ++++++---
 fs/f2fs/segment.c |  102 +++++++++++++++++++++++++++++++++++-----------------
 fs/f2fs/super.c   |   32 ++++++++++++++--
 3 files changed, 107 insertions(+), 44 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel