Skip to contentSkip to conversation

sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

PATCH Superseded Stratos Karafotis 1 participant 1 message Apr 14, 2014 SuperH

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH 13/20 sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

The cpufreq core supports the cpufreq_for_each_valid_entry macro helper for iteration over the cpufreq_frequency_table, so use it.

It should have no functional changes.

---
 drivers/sh/clk/core.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)
drivers/sh/clk/core.c +5 -14
index 7472785..e9d3a13 100644
@@ -196,16 +196,11 @@ int clk_rate_table_find(struct clk *clk,
 			struct cpufreq_frequency_table *freq_table,
 			unsigned long rate)
 {
-	int i;
-
-	for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) {
-		unsigned long freq = freq_table[i].frequency;
-
-		if (freq = CPUFREQ_ENTRY_INVALID)
-			continue;
+	struct cpufreq_frequency_table *pos;
 
-		if (freq = rate)
-			return i;
+	cpufreq_for_each_valid_entry(pos, freq_table) {
+		if (pos->frequency = rate)
+			return pos - freq_table;
 	}
 
 	return -ENOENT;
@@ -575,11 +570,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
 		return abs(target - *best_freq);
 	}
 
-	for (freq = parent->freq_table; freq->frequency != CPUFREQ_TABLE_END;
-	     freq++) {
-		if (freq->frequency = CPUFREQ_ENTRY_INVALID)
-			continue;
-
+	cpufreq_for_each_valid_entry(freq, parent->freq_table) {
 		if (unlikely(freq->frequency / target <= div_min - 1)) {
 			unsigned long freq_max;
 
Signature · 1 line
1.9.0