Skip to contentSkip to conversation

libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down

PATCH Ira Weiny 2 participants 2 messages Apr 15, 2014 2 messages not in the archive InfiniBand

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ira Weiny

author
#1 lore raw

Ammar,

This patch does not apply cleanly.

09:41:21 > git am ../\[PATCH\]__libibmad_src_dump.c___Set_the_vlaue_of__LinkWidthActive_to_undefined\(width\)_when_the_port_is_down.eml
Applying: libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
fatal: patch fragment without header at line 18: @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val, Patch failed at 0001 libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down

Also I don't think it showed up on linux-rdma.

Could you make sure to send as plain text. That could be why linux-rdma dropped it and I missed it.

Thanks,
Ira

Quoted 65 lines · On Mon, 17 Mar 2014 15:10:10 +0200 Ammar Haj Hamad…

This patch is to set the vlaue of LinkWidthActive to undefined({width}) when the port is down

---

src/dump.c | 3 +++

1 files changed, 3 insertions(+), 0 deletions(-)
src/dump.c +0 -0

index f77d739..4bc8153 100644

--- a/src/dump.c

+++ b/src/dump.c

src/dump.c +2 -0
@@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
 int valsz)
 
               int width = *(int *)val;
 
                switch (width) {
 
+             case 0: 
 
+                             snprintf(buf , bufsz , "undefined (%d)",

width);

+ break;

               case 1:

                               snprintf(buf, bufsz, "1X");

                               break;
Signature · 17 lines
1.7.1

 

 

 

 

  _____  

Ammar Omar Haj Hamad |    Software Engineer           |   ASAL technologies
- Mellanox

Mobile : +970599751673  |    ahamad-DMD6N21cJuFWk0Htik3J/[email protected]   | Skype :
ammar.hajhamad.asal
Signature · 5 lines
Ira Weiny <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20140415094316.f16055aaa70c239bd8fe7159-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org

#3 lore raw
Quoted 49 lines · Ira Weiny

Ammar,

This patch does not apply cleanly.

09:41:21 > git am ../\[PATCH\]__libibmad_src_dump.c___Set_the_vlaue_of__LinkWidthActive_to_undefined\(width\)_when_the_port_is_down.eml
Applying: libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
fatal: patch fragment without header at line 18: @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val, Patch failed at 0001 libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down

Also I don't think it showed up on linux-rdma.

Could you make sure to send as plain text. That could be why linux-rdma dropped it and I missed it.

Thanks,
Ira

Quoted 28 lines · On Mon, 17 Mar 2014 15:10:10 +0200 Ammar Haj Hamad…

This patch is to set the vlaue of LinkWidthActive to undefined({width}) when the port is down

---

src/dump.c | 3 +++

1 files changed, 3 insertions(+), 0 deletions(-)
src/dump.c +0 -0

index f77d739..4bc8153 100644

--- a/src/dump.c

+++ b/src/dump.c

src/dump.c +0 -0
@@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
 int valsz)
 
               int width = *(int *)val;
 
Quoted 8 lines
Quoted 8 lines
src/dump.c +2 -0
                switch (width) {
 
+             case 0: 
 
+                             snprintf(buf , bufsz , "undefined (%d)",

width);

+ break;

Why special case width 0 and not handle this in default case as is currently done in mad_dump_linkspeed ?

-- Hal

Quoted 21 lines
Quoted 21 lines
               case 1:

                               snprintf(buf, bufsz, "1X");

                               break;
Signature · 11 lines
1.7.1

 

 

 

 

  _____  
Quoted 10 lines
Quoted 8 lines

Ammar Omar Haj Hamad | Software Engineer | ASAL technologies
- Mellanox

Mobile : +970599751673 | ahamad-DMD6N21cJuFWk0Htik3J/[email protected] | Skype :
ammar.hajhamad.asal

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html