Skip to contentSkip to conversation

arm: dts: exynos4: add missing pinctrls for I2C controllers

PATCH Applied Tomasz Stanislawski 3 participants 3 messages Apr 16, 2014 – May 6, 2014

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Tomasz Stanislawski

author
#0 lore raw

PATCH 1/1 arm: dts: exynos4: add missing pinctrls for I2C controllers

This patch adds missing pinctrls for I2C controllers 2-7.

Signed-off-by Tomasz Stanislawski <[email protected]>
---
 arch/arm/boot/dts/exynos4.dtsi |   12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/exynos4.dtsi +12 -0
index 0401f4d..288aa81 100644
@@ -357,6 +357,8 @@
 		interrupts = <0 60 0>;
 		clocks = <&clock CLK_I2C2>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
 		status = "disabled";
 	};
 

@@ -368,6 +370,8 @@
 		interrupts = <0 61 0>;
 		clocks = <&clock CLK_I2C3>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
 		status = "disabled";
 	};
 

@@ -379,6 +383,8 @@
 		interrupts = <0 62 0>;
 		clocks = <&clock CLK_I2C4>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c4_bus>;
 		status = "disabled";
 	};
 

@@ -390,6 +396,8 @@
 		interrupts = <0 63 0>;
 		clocks = <&clock CLK_I2C5>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c5_bus>;
 		status = "disabled";
 	};
 

@@ -401,6 +409,8 @@
 		interrupts = <0 64 0>;
 		clocks = <&clock CLK_I2C6>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c6_bus>;
 		status = "disabled";
 	};
 

@@ -412,6 +422,8 @@
 		interrupts = <0 65 0>;
 		clocks = <&clock CLK_I2C7>;
 		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c7_bus>;
 		status = "disabled";
 	};
Reviewed-by on v1 1/1
#1 lore raw

Hi Tomasz,

Quoted 58 lines · Tomasz Stanislawski

This patch adds missing pinctrls for I2C controllers 2-7.

Signed-off-by Tomasz Stanislawski <[email protected]>
---
  arch/arm/boot/dts/exynos4.dtsi |   12 ++++++++++++
  1 file changed, 12 insertions(+)
arch/arm/boot/dts/exynos4.dtsi +10 -0
index 0401f4d..288aa81 100644
@@ -357,6 +357,8 @@
  		interrupts = <0 60 0>;
  		clocks = <&clock CLK_I2C2>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
  		status = "disabled";
  	};
 

@@ -368,6 +370,8 @@
  		interrupts = <0 61 0>;
  		clocks = <&clock CLK_I2C3>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
  		status = "disabled";
  	};
 

@@ -379,6 +383,8 @@
  		interrupts = <0 62 0>;
  		clocks = <&clock CLK_I2C4>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c4_bus>;
  		status = "disabled";
  	};
 

@@ -390,6 +396,8 @@
  		interrupts = <0 63 0>;
  		clocks = <&clock CLK_I2C5>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c5_bus>;
  		status = "disabled";
  	};
 

@@ -401,6 +409,8 @@
  		interrupts = <0 64 0>;
  		clocks = <&clock CLK_I2C6>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c6_bus>;
  		status = "disabled";
  	};

arch/arm/boot/dts/exynos4.dtsi line 429

Quoted 8 lines
arch/arm/boot/dts/exynos4.dtsi +2 -0
@@ -412,6 +422,8 @@
  		interrupts = <0 65 0>;
  		clocks = <&clock CLK_I2C7>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c7_bus>;
  		status = "disabled";
  	};
Reviewed-by Tomasz Figa <[email protected]>

--
Best regards,
Tomasz

Applied
#2 lore raw
Quoted 61 lines · Tomasz Figa

Hi Tomasz,

Review

Quoted 8 lines · Tomasz Stanislawski

This patch adds missing pinctrls for I2C controllers 2-7.

Signed-off-by Tomasz Stanislawski <[email protected]>
---
  arch/arm/boot/dts/exynos4.dtsi |   12 ++++++++++++
  1 file changed, 12 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4.dtsi

Quoted 48 lines

index 0401f4d..288aa81 100644

arch/arm/boot/dts/exynos4.dtsi +10 -0
@@ -357,6 +357,8 @@
  		interrupts = <0 60 0>;
  		clocks = <&clock CLK_I2C2>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c2_bus>;
  		status = "disabled";
  	};
 

@@ -368,6 +370,8 @@
  		interrupts = <0 61 0>;
  		clocks = <&clock CLK_I2C3>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c3_bus>;
  		status = "disabled";
  	};
 

@@ -379,6 +383,8 @@
  		interrupts = <0 62 0>;
  		clocks = <&clock CLK_I2C4>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c4_bus>;
  		status = "disabled";
  	};
 

@@ -390,6 +396,8 @@
  		interrupts = <0 63 0>;
  		clocks = <&clock CLK_I2C5>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c5_bus>;
  		status = "disabled";
  	};
 

@@ -401,6 +409,8 @@
  		interrupts = <0 64 0>;
  		clocks = <&clock CLK_I2C6>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c6_bus>;
  		status = "disabled";
  	};
Quoted 13 lines

arch/arm/boot/dts/exynos4.dtsi line 429

Quoted 10 lines
arch/arm/boot/dts/exynos4.dtsi +2 -0
@@ -412,6 +422,8 @@
  		interrupts = <0 65 0>;
  		clocks = <&clock CLK_I2C7>;
  		clock-names = "i2c";
+		pinctrl-names = "default";
+		pinctrl-0 = <&i2c7_bus>;
  		status = "disabled";
  	};
Reviewed-by Tomasz Figa <[email protected]>

Applied, thanks.

- Kukjin