xen: fix alignment for bitops
Subsystems (2)
PATCH v2 1/1 xen: fix alignment for bitops
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that DEFINE_PER_CPU does required alignment for cpu_control_block; however, local copy used for bitops might not be world aligned.
For arm64 it ends up with unaligned access trap:
Unhandled fault: alignment fault (0x96000021) at 0xffffffc01cf07d64
Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 563 Comm: udevd Not tainted 3.14.0+ #1 task: ffffffc01de95c40 ti: ffffffc01cf04000 task.ti: ffffffc01cf04000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_handle_events+0x168/0x184 pc : [<ffffffc00027b6c4>] lr : [<ffffffc0002b17d8>] pstate: 600001c5
sp : ffffffc01cf07d00
x29: ffffffc01cf07d00 x28: ffffffc01dce5000
x27: 0000000000000008 x26: 0000000000000002
x25: 00000000dffe0000 x24: 0000000000000000
x23: 0000000000000007 x22: ffffffc000660000
x21: ffffffc00060d900 x20: ffffffc01efdd900
x19: ffffffc01dc26000 x18: 0000007ff1d5a570
x17: 0000007faf848824 x16: 000000000044bf10
x15: 0000007faf8ed598 x14: ffffffffffffffff
x13: 0000000000000028 x12: 0101010101010101
x11: 7f7f7f7f7f7f7f7f x10: 622e607360632e75
x9 : 7f7f7f7f7f7f7f7f x8 : 000000001e9d0000
x7 : ffffffc01d800120 x6 : 00000000a0000000
x5 : 00000000a0000000 x4 : 0000000000000000
x3 : 0000000000000080 x2 : 0000000000000001
x1 : ffffffc01cf07d64 x0 : 0000000000000000
Process udevd (pid: 563, stack limit = 0xffffffc01cf04058)
Stack: (0xffffffc01cf07d00 to 0xffffffc01cf08000)
7d00: 1cf07d80 ffffffc0 002aeb7c ffffffc0 0060d6ec ffffffc0 1efe1c90 ffffffc0 7d20: 0056e418 ffffffc0 0066c000 ffffffc0 00000000 00000000 005659a0 ffffffc0 7d40: 00565998 ffffffc0 004053b0 00000000 00423bb0 00000000 00423000 00000000 7d60: a0000000 00000080 002aeb1c ffffffc0 00000000 00000000 002aeb4c ffffffc0 7d80: 1cf07dd0 ffffffc0 002aec2c ffffffc0 1dc09f00 ffffffc0 00630360 ffffffc0 7da0: 1dc23400 ffffffc0 00567c08 ffffffc0 0000001f 00000000 1efdc400 ffffffc0 7dc0: 000001ed 00000000 004053b0 00000000 1cf07de0 ffffffc0 00092eec ffffffc0 7de0: 1cf07df0 ffffffc0 000d79bc ffffffc0 1cf07e30 ffffffc0 000d3cf0 ffffffc0 7e00: 0000001f 00000000 0060d000 ffffffc0 00565000 ffffffc0 00565000 ffffffc0 7e20: 0000001f 00000000 00000000 00000000 1cf07e50 ffffffc0 000848bc ffffffc0 7e40: 0060d5a0 ffffffc0 000848a4 ffffffc0 1cf07ea0 ffffffc0 0008128c ffffffc0 7e60: 00667000 ffffffc0 0000400c ffffff80 1cf07ed0 ffffffc0 00004010 ffffff80 7e80: 80000000 00000000 2dca8010 00000000 1cf07ed0 ffffffc0 00000012 00000000 7ea0: f1d5b710 0000007f 000841bc ffffffc0 2dca8170 00000000 f1d5b870 0000007f 7ec0: ffffffff ffffffff af848838 0000007f 00000000 00000000 f1d5b7a0 0000007f 7ee0: f1d5b720 0000007f 00000000 00000000 61642f76 632f6174 2e353a34 00706d74 7f00: f1d5b7ae 0000007f 00000000 00000000 0000004f 00000000 7f7f7f7f 7f7f7f7f 7f20: 60632e75 622e6073 7f7f7f7f 7f7f7f7f 01010101 01010101 00000028 00000000 7f40: ffffffff ffffffff af8ed598 0000007f 0044bf10 00000000 af848824 0000007f 7f60: f1d5a570 0000007f 2dca8170 00000000 f1d5b870 0000007f 2dcc6ca0 00000000 7f80: f1d5bc70 0000007f 00000000 00000000 2dca8010 00000000 000001ed 00000000 7fa0: 004053b0 00000000 00423bb0 00000000 00423000 00000000 f1d5b710 0000007f 7fc0: 0041f460 00000000 f1d5b710 0000007f af848838 0000007f 80000000 00000000 7fe0: ffffff9c ffffffff ffffffff ffffffff dfdfdfcf cfdfdfdf dfdfdfcf cfdfdfdf
Call trace: [<ffffffc00027b6c4>] clear_bit+0x14/0x30 [<ffffffc0002aeb78>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002aec28>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc000092ee8>] xen_arm_callback+0x8/0x18 [<ffffffc0000d79b8>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000d3cec>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc01cf07eb0 to 0xffffffc01cf07fd0)
7ea0: 2dca8170 00000000 f1d5b870 0000007f
7ec0: ffffffff ffffffff af848838 0000007f 00000000 00000000 f1d5b7a0 0000007f 7ee0: f1d5b720 0000007f 00000000 00000000 61642f76 632f6174 2e353a34 00706d74 7f00: f1d5b7ae 0000007f 00000000 00000000 0000004f 00000000 7f7f7f7f 7f7f7f7f 7f20: 60632e75 622e6073 7f7f7f7f 7f7f7f7f 01010101 01010101 00000028 00000000 7f40: ffffffff ffffffff af8ed598 0000007f 0044bf10 00000000 af848824 0000007f 7f60: f1d5a570 0000007f 2dca8170 00000000 f1d5b870 0000007f 2dcc6ca0 00000000 7f80: f1d5bc70 0000007f 00000000 00000000 2dca8010 00000000 000001ed 00000000 7fa0: 004053b0 00000000 00423bb0 00000000 00423000 00000000 f1d5b710 0000007f 7fc0: 0041f460 00000000 f1d5b710 0000007f
Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)
Use unsigned long for "ready" to make sure it is world aligned.
---
Changes:
v1->v2
use unsigned long instead of align attribute
drivers/xen/events/events_fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/events/events_fifo.c +1 -1
@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);
Signature · 1 line
1.8.3.2
Quoted 106 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap:
Unhandled fault: alignment fault (
0x96000021) at0xffffffc01cf07d64Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 563 Comm: udevd Not tainted 3.14.0+ #1 task: ffffffc01de95c40 ti: ffffffc01cf04000 task.ti: ffffffc01cf04000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_handle_events+0x168/0x184 pc : [<ffffffc00027b6c4>] lr : [<ffffffc0002b17d8>] pstate: 600001c5sp :
ffffffc01cf07d00
x29:ffffffc01cf07d00x28:ffffffc01dce5000
x27: 0000000000000008 x26: 0000000000000002
x25:00000000dffe0000x24: 0000000000000000
x23: 0000000000000007 x22:ffffffc000660000
x21:ffffffc00060d900x20:ffffffc01efdd900
x19:ffffffc01dc26000x18:0000007ff1d5a570
x17:0000007faf848824x16:000000000044bf10
x15:0000007faf8ed598x14: ffffffffffffffff
x13: 0000000000000028 x12: 0101010101010101
x11:7f7f7f7f7f7f7f7fx10:622e607360632e75
x9 :7f7f7f7f7f7f7f7fx8 :000000001e9d0000
x7 :ffffffc01d800120x6 :00000000a0000000
x5 :00000000a0000000x4 : 0000000000000000
x3 : 0000000000000080 x2 : 0000000000000001
x1 :ffffffc01cf07d64x0 : 0000000000000000Process udevd (pid: 563, stack limit =
0xffffffc01cf04058)Stack: (0xffffffc01cf07d00 to 0xffffffc01cf08000)7d00:
1cf07d80ffffffc0002aeb7cffffffc00060d6ecffffffc01efe1c90ffffffc07d20:0056e418ffffffc00066c000ffffffc000000000 00000000005659a0ffffffc07d40: 00565998ffffffc0004053b00000000000423bb000000000 00423000 00000000 7d60:a000000000000080002aeb1cffffffc000000000 00000000002aeb4cffffffc07d80:1cf07dd0ffffffc0002aec2cffffffc01dc09f00ffffffc000630360ffffffc07da0:1dc23400ffffffc000567c08ffffffc00000001f000000001efdc400ffffffc07dc0:000001ed00000000004053b0000000001cf07de0ffffffc000092eecffffffc07de0:1cf07df0ffffffc0000d79bcffffffc01cf07e30ffffffc0000d3cf0ffffffc07e00:0000001f000000000060d000ffffffc000565000ffffffc000565000ffffffc07e20:0000001f00000000 00000000 000000001cf07e50ffffffc0000848bcffffffc07e40:0060d5a0ffffffc0000848a4ffffffc01cf07ea0ffffffc00008128cffffffc07e60: 00667000ffffffc00000400cffffff801cf07ed0ffffffc000004010ffffff807e80: 80000000 000000002dca8010000000001cf07ed0ffffffc000000012 00000000 7ea0:f1d5b7100000007f000841bcffffffc02dca817000000000f1d5b8700000007f7ec0: ffffffff ffffffffaf8488380000007f00000000 00000000f1d5b7a00000007f7ee0:f1d5b7200000007f00000000 0000000061642f76632f61742e353a3400706d747f00:f1d5b7ae0000007f00000000 000000000000004f000000007f7f7f7f7f7f7f7f7f20:60632e75622e60737f7f7f7f7f7f7f7f01010101 01010101 00000028 00000000 7f40: ffffffff ffffffffaf8ed5980000007f0044bf1000000000af8488240000007f7f60:f1d5a5700000007f2dca817000000000f1d5b8700000007f2dcc6ca000000000 7f80:f1d5bc700000007f00000000 000000002dca801000000000000001ed00000000 7fa0:004053b00000000000423bb000000000 00423000 00000000f1d5b7100000007f7fc0:0041f46000000000f1d5b7100000007faf8488380000007f80000000 00000000 7fe0:ffffff9cffffffff ffffffff ffffffff dfdfdfcf cfdfdfdf dfdfdfcf cfdfdfdfCall trace: [<ffffffc00027b6c4>] clear_bit+0x14/0x30 [<ffffffc0002aeb78>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002aec28>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc000092ee8>] xen_arm_callback+0x8/0x18 [<ffffffc0000d79b8>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000d3cec>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc01cf07eb0 to 0xffffffc01cf07fd0)7ea0:
2dca817000000000f1d5b8700000007f
7ec0: ffffffff ffffffffaf8488380000007f00000000 00000000f1d5b7a00000007f7ee0:f1d5b7200000007f00000000 0000000061642f76632f61742e353a3400706d747f00:f1d5b7ae0000007f00000000 000000000000004f000000007f7f7f7f7f7f7f7f7f20:60632e75622e60737f7f7f7f7f7f7f7f01010101 01010101 00000028 00000000 7f40: ffffffff ffffffffaf8ed5980000007f0044bf1000000000af8488240000007f7f60:f1d5a5700000007f2dca817000000000f1d5b8700000007f2dcc6ca000000000 7f80:f1d5bc700000007f00000000 000000002dca801000000000000001ed00000000 7fa0:004053b00000000000423bb000000000 00423000 00000000f1d5b7100000007f7fc0:0041f46000000000f1d5b7100000007fCode: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)Use unsigned long for "ready" to make sure it is world aligned.
Signed-off-by Vladimir Murzin <[email protected]>---
Changes:
v1->v2
use unsigned long instead of align attributedrivers/xen/events/events_fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/xen/events/events_fifo.c +1
-2@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu); --
Quoted 2 lines
1.8.3.2
My bad :( It triggers a warning...
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready word
Bitops operations like set_bit(), clear_bit(), and test_bit() require word aligned pointers, because of architectures specific implementations.
Looks that DEFINE_PER_CPU does required alignment for cpu_control_block; however, local copy of the ready word might not be word aligned.
For arm64 it ends up with unaligned access trap at:
if (head == 0)
clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/xen/events/events_fifo.c +3 -3
@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;
@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))
@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);
Hi Vladimir/David,
Quoted 69 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +3
-3@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);
Quoted 4 lines
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
I have tried this fix on APM X-Gene and it is solving a crash (you have reported) during booting of DOM0.
But while trying out domU when I tried to execute "/etc/init.d/xencommons start || true"
I am observing a similar "alignment fault" crash while performing "clear_bit" in " evtchn_fifo_clear_pending"
Pasting a crash log:
root@arm64:~/xen-images# /etc/init.d/xencommons start || true Starting C xenstored.... Unhandled fault: alignment fault (0x96000021) at 0xffffffc0fae7700c Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.15.0-rc1-next-20140417+ #5 task: ffffffc0007188b0 ti: ffffffc00070c000 task.ti: ffffffc00070c000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_clear_pending+0x28/0x30 pc : [<ffffffc000289304>] lr : [<ffffffc0002d9f60>] pstate: 600001c5 sp : ffffffc00070fbb0 x29: ffffffc00070fbb0 x28: ffffffc0fae77000 x27: 000000000000000c x26: 0000000000000003 x25: 00000000dffe0000 x24: 0000000000000000 x23: 0000000000000007 x22: ffffffc000768000 x21: ffffffc0f94a0884 x20: ffffffc000645b80 x19: ffffffc0f94a0800 x18: 0000007f863063e0 x17: 0000007f875d0280 x16: ffffffc0000f93ec x15: 001b92d7f76c3f7d x14: 0000000000000000 x13: 00000003e8000000 x12: 0000000000000018 x11: 0000000000000000 x10: 0000000000000400 x9 : ffffffc00070fd20 x8 : 00000000fe871000 x7 : ffffffc0fa800038 x6 : ffffffc0fa800000 x5 : 00000000fffffffa x4 : 0000000000000000 x3 : 0000000080000000 x2 : 0000000000000001 x1 : ffffffc0fae7700c x0 : 0000000000000000
Process swapper/0 (pid: 0, stack limit = 0xffffffc00070c058)
Stack: (0xffffffc00070fbb0 to 0xffffffc000710000)
fba0: 0070fbc0 ffffffc0 002d7f84 ffffffc0
fbc0: 0070fbd0 ffffffc0 000e44f0 ffffffc0 0070fc00 ffffffc0 000e13e8 ffffffc0
fbe0: 00000002 00000000 fef7a900 ffffffc0 00709900 ffffffc0 000e13d4 ffffffc0
fc00: 0070fc20 ffffffc0 002da0ec ffffffc0 fac39000 ffffffc0 000d1e80 ffffffc0
fc20: 0070fca0 ffffffc0 002d74c4 ffffffc0 007096ec ffffffc0 fef7ef10 ffffffc0
fc40: 0064d878 ffffffc0 00775000 ffffffc0 00000000 00000000 00642500 ffffffc0
fc60: 006424f8 ffffffc0 00648318 ffffffc0 0070c000 ffffffc0 00000000 00000081
fc80: 00000000 00000000 a0000000 ffffffc0 00000000 00000000 002d7494 ffffffc0
fca0: 0070fcf0 ffffffc0 002d7574 ffffffc0 fac0c800 ffffffc0 0072cae0 ffffffc0
fcc0: fac26500 ffffffc0 00645b80 ffffffc0 00000018 00000000 fef79410 ffffffc0
fce0: 00000001 00000000 00648318 ffffffc0 0070fd00 ffffffc0 000a06a8 ffffffc0
fd00: 0070fd10 ffffffc0 000e50b0 ffffffc0 0070fd50 ffffffc0 000e13e8 ffffffc0
fd20: 00000018 00000000 00709000 ffffffc0 00642000 ffffffc0 00642000 ffffffc0
fd40: 00000018 00000000 00000000 00000000 0070fd70 ffffffc0 000848bc ffffffc0
fd60: 007095b0 ffffffc0 000848a4 ffffffc0 0070fdc0 ffffffc0 0008128c ffffffc0
fd80: 0076f000 ffffffc0 0000400c ffffff80 0070fdf0 ffffffc0 00004010 ffffff80
fda0: 60000145 00000000 00759cac ffffffc0 0070fdf0 ffffffc0 0070fdf0 ffffffc0
fdc0: 0070ff10 ffffffc0 00083dac ffffffc0 0070c000 ffffffc0 0070c000 ffffffc0
fde0: 0070ff10 ffffffc0 00084ef0 ffffffc0 00000000 00000000 00653708 ffffffc0
fe00: 00653708 ffffffc0 00000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 00000000 00718db0 ffffffc0 0070fd20 ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000 e8000000 00000003
fe60: 00000000 00000000 f76c3f7d 001b92d7 000f93ec ffffffc0 875d0280 0000007f
fe80: 863063e0 0000007f 0070c000 ffffffc0 0070c000 ffffffc0 00761200 ffffffc0
fea0: 0051e000 ffffffc0 006424f8 ffffffc0 00759cac ffffffc0 00000001 00000000
fec0: 00648318 ffffffc0 0070c000 ffffffc0 00000000 00000081 0070ff10 ffffffc0
fee0: 00084eec ffffffc0 0070ff10 ffffffc0 00084ef0 ffffffc0 60000145 00000000
ff00: 0070c000 ffffffc0 0070c000 ffffffc0 0070ff20 ffffffc0 000d944c ffffffc0
ff20: 0070ff80 ffffffc0 00508944 ffffffc0 00768000 ffffffc0 0075b000 ffffffc0
ff40: 006fb9a0 ffffffc0 0075b000 ffffffc0 feffde40 ffffffc0 00000000 00000041
ff60: 0007b000 00000041 0007d000 00000041 00080450 ffffffc0 0050893c ffffffc0
ff80: 0070ffa0 ffffffc0 006d68a0 ffffffc0 00000002 00000000 0075b000 ffffffc0
ffa0: 00000000 00000000 00080210 00000041 00000000 00000000 00000e11 00000000
ffc0: 08000000 00000041 500f0000 00000000 0071a000 00000041 00000000 00000000
ffe0: 006fb9a0 ffffffc0 00000000 00000000 00000000 00000000 00000000 00000000
Call trace: [<ffffffc000289304>] clear_bit+0x14/0x30 [<ffffffc0002d7f80>] ack_dynirq+0x20/0x2c [<ffffffc0000e44ec>] handle_edge_irq+0x94/0x18c [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0002da0e8>] evtchn_fifo_handle_events+0x180/0x188 [<ffffffc0002d74c0>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002d7570>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc0000a06a4>] xen_arm_callback+0x8/0x18 [<ffffffc0000e50ac>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc00070fdd0 to 0xffffffc00070fef0)
fdc0: 0070c000 ffffffc0 0070c000 ffffffc0
fde0: 0070ff10 ffffffc0 00084ef0 ffffffc0 00000000 00000000 00653708 ffffffc0
fe00: 00653708 ffffffc0 00000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 00000000 00718db0 ffffffc0 0070fd20 ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000 e8000000 00000003
fe60: 00000000 00000000 f76c3f7d 001b92d7 000f93ec ffffffc0 875d0280 0000007f
fe80: 863063e0 0000007f 0070c000 ffffffc0 0070c000 ffffffc0 00761200 ffffffc0
fea0: 0051e000 ffffffc0 006424f8 ffffffc0 00759cac ffffffc0 00000001 00000000
fec0: 00648318 ffffffc0 0070c000 ffffffc0 00000000 00000081 0070ff10 ffffffc0
fee0: 00084eec ffffffc0 0070ff10 ffffffc0
[<ffffffc000083da8>] el1_irq+0x68/0xd8 [<ffffffc0000d9448>] cpu_startup_entry+0x114/0x174 [<ffffffc000508940>] rest_init+0x7c/0x88 [<ffffffc0006d689c>] start_kernel+0x350/0x368 Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)
Thanks,
Pranav
Quoted 181 lines · Pranavkumar Sawargaonkar
Hi Vladimir/David,
Quoted 69 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +3
-3@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);Quoted 4 lines
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-develI have tried this fix on APM X-Gene and it is solving a crash (you have reported) during booting of DOM0.
But while trying out domU when I tried to execute "
/etc/init.d/xencommonsstart || true"
I am observing a similar "alignment fault" crash while performing "clear_bit" in "evtchn_fifo_clear_pending"
Pasting a crash log:root@arm64:~/xen-images# /etc/init.d/xencommons start || true Starting C xenstored.... Unhandled fault: alignment fault (0x96000021) at 0xffffffc0fae7700c Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.15.0-rc1-next-20140417+ #5 task: ffffffc0007188b0 ti: ffffffc00070c000 task.ti: ffffffc00070c000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_clear_pending+0x28/0x30 pc : [<ffffffc000289304>] lr : [<ffffffc0002d9f60>] pstate: 600001c5 sp : ffffffc00070fbb0 x29: ffffffc00070fbb0 x28: ffffffc0fae77000 x27: 000000000000000c x26: 0000000000000003 x25: 00000000dffe0000 x24: 0000000000000000 x23: 0000000000000007 x22: ffffffc000768000 x21: ffffffc0f94a0884 x20: ffffffc000645b80 x19: ffffffc0f94a0800 x18: 0000007f863063e0 x17: 0000007f875d0280 x16: ffffffc0000f93ec x15: 001b92d7f76c3f7d x14: 0000000000000000 x13: 00000003e8000000 x12: 0000000000000018 x11: 0000000000000000 x10: 0000000000000400 x9 : ffffffc00070fd20 x8 : 00000000fe871000 x7 : ffffffc0fa800038 x6 : ffffffc0fa800000 x5 : 00000000fffffffa x4 : 0000000000000000 x3 : 0000000080000000 x2 : 0000000000000001 x1 : ffffffc0fae7700c x0 : 0000000000000000Process swapper/0 (pid: 0, stack limit =
0xffffffc00070c058)Stack: (0xffffffc00070fbb0 to 0xffffffc000710000)fba0:
0070fbc0ffffffc0002d7f84ffffffc0
fbc0:0070fbd0ffffffc0000e44f0ffffffc00070fc00ffffffc0000e13e8ffffffc0
fbe0: 00000002 00000000fef7a900ffffffc000709900ffffffc0000e13d4ffffffc0
fc00:0070fc20ffffffc0002da0ecffffffc0fac39000ffffffc0000d1e80ffffffc0
fc20:0070fca0ffffffc0002d74c4ffffffc0007096ecffffffc0fef7ef10ffffffc0
fc40:0064d878ffffffc000775000ffffffc000000000 00000000 00642500ffffffc0
fc60:006424f8ffffffc000648318ffffffc00070c000ffffffc000000000 00000081
fc80: 00000000 00000000a0000000ffffffc000000000 00000000002d7494ffffffc0
fca0:0070fcf0ffffffc0002d7574ffffffc0fac0c800ffffffc00072cae0ffffffc0
fcc0:fac26500ffffffc000645b80ffffffc000000018 00000000fef79410ffffffc0
fce0: 00000001 00000000 00648318ffffffc00070fd00ffffffc0000a06a8ffffffc0
fd00:0070fd10ffffffc0000e50b0ffffffc00070fd50ffffffc0000e13e8ffffffc0
fd20: 00000018 00000000 00709000ffffffc000642000ffffffc000642000ffffffc0
fd40: 00000018 00000000 00000000 000000000070fd70ffffffc0000848bcffffffc0
fd60:007095b0ffffffc0000848a4ffffffc00070fdc0ffffffc00008128cffffffc0
fd80:0076f000ffffffc00000400cffffff800070fdf0ffffffc000004010ffffff80
fda0: 60000145 0000000000759cacffffffc00070fdf0ffffffc00070fdf0ffffffc0
fdc0:0070ff10ffffffc000083dacffffffc00070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc000084ef0ffffffc060000145 00000000
ff00:0070c000ffffffc00070c000ffffffc00070ff20ffffffc0000d944cffffffc0
ff20:0070ff80ffffffc000508944ffffffc000768000ffffffc00075b000ffffffc0
ff40:006fb9a0ffffffc00075b000ffffffc0feffde40ffffffc000000000 00000041
ff60:0007b000000000410007d00000000041 00080450ffffffc00050893cffffffc0
ff80:0070ffa0ffffffc0006d68a0ffffffc000000002 000000000075b000ffffffc0
ffa0: 00000000 00000000 00080210 00000041 00000000 0000000000000e1100000000
ffc0: 08000000 00000041500f0000000000000071a00000000041 00000000 00000000
ffe0:006fb9a0ffffffc000000000 00000000 00000000 00000000 00000000 00000000Call trace: [<ffffffc000289304>] clear_bit+0x14/0x30 [<ffffffc0002d7f80>] ack_dynirq+0x20/0x2c [<ffffffc0000e44ec>] handle_edge_irq+0x94/0x18c [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0002da0e8>] evtchn_fifo_handle_events+0x180/0x188 [<ffffffc0002d74c0>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002d7570>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc0000a06a4>] xen_arm_callback+0x8/0x18 [<ffffffc0000e50ac>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc00070fdd0 to 0xffffffc00070fef0)fdc0:
0070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc0[<ffffffc000083da8>] el1_irq+0x68/0xd8 [<ffffffc0000d9448>] cpu_startup_entry+0x114/0x174 [<ffffffc000508940>] rest_init+0x7c/0x88 [<ffffffc0006d689c>] start_kernel+0x350/0x368 Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)
Quoted 2 lines
Thanks,
Pranav
HI Pranav
I've just come back form holidays. The last time I tried run DomU there was Xen crush with syndrome 0x21 - looks like alignment trap again ;) Unfortunately, had no chance to play with it yet :(
Probably, I could post *untested* patch which makes arm64 bitops "friendly" to 32-bit... still awaiting response form arm64 about the best way to deal with it ;)
Vladimir
Quoted 192 lines · Vladimir Murzin
Quoted 181 lines · Pranavkumar Sawargaonkar
Hi Vladimir/David,
Quoted 69 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +3
-3@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);Quoted 4 lines
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-develI have tried this fix on APM X-Gene and it is solving a crash (you have reported) during booting of DOM0.
But while trying out domU when I tried to execute "
/etc/init.d/xencommonsstart || true"
I am observing a similar "alignment fault" crash while performing "clear_bit" in "evtchn_fifo_clear_pending"
Pasting a crash log:root@arm64:~/xen-images# /etc/init.d/xencommons start || true Starting C xenstored.... Unhandled fault: alignment fault (0x96000021) at 0xffffffc0fae7700c Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.15.0-rc1-next-20140417+ #5 task: ffffffc0007188b0 ti: ffffffc00070c000 task.ti: ffffffc00070c000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_clear_pending+0x28/0x30 pc : [<ffffffc000289304>] lr : [<ffffffc0002d9f60>] pstate: 600001c5 sp : ffffffc00070fbb0 x29: ffffffc00070fbb0 x28: ffffffc0fae77000 x27: 000000000000000c x26: 0000000000000003 x25: 00000000dffe0000 x24: 0000000000000000 x23: 0000000000000007 x22: ffffffc000768000 x21: ffffffc0f94a0884 x20: ffffffc000645b80 x19: ffffffc0f94a0800 x18: 0000007f863063e0 x17: 0000007f875d0280 x16: ffffffc0000f93ec x15: 001b92d7f76c3f7d x14: 0000000000000000 x13: 00000003e8000000 x12: 0000000000000018 x11: 0000000000000000 x10: 0000000000000400 x9 : ffffffc00070fd20 x8 : 00000000fe871000 x7 : ffffffc0fa800038 x6 : ffffffc0fa800000 x5 : 00000000fffffffa x4 : 0000000000000000 x3 : 0000000080000000 x2 : 0000000000000001 x1 : ffffffc0fae7700c x0 : 0000000000000000Process swapper/0 (pid: 0, stack limit =
0xffffffc00070c058)Stack: (0xffffffc00070fbb0 to 0xffffffc000710000)fba0:
0070fbc0ffffffc0002d7f84ffffffc0
fbc0:0070fbd0ffffffc0000e44f0ffffffc00070fc00ffffffc0000e13e8ffffffc0
fbe0: 00000002 00000000fef7a900ffffffc000709900ffffffc0000e13d4ffffffc0
fc00:0070fc20ffffffc0002da0ecffffffc0fac39000ffffffc0000d1e80ffffffc0
fc20:0070fca0ffffffc0002d74c4ffffffc0007096ecffffffc0fef7ef10ffffffc0
fc40:0064d878ffffffc000775000ffffffc000000000 00000000 00642500ffffffc0
fc60:006424f8ffffffc000648318ffffffc00070c000ffffffc000000000 00000081
fc80: 00000000 00000000a0000000ffffffc000000000 00000000002d7494ffffffc0
fca0:0070fcf0ffffffc0002d7574ffffffc0fac0c800ffffffc00072cae0ffffffc0
fcc0:fac26500ffffffc000645b80ffffffc000000018 00000000fef79410ffffffc0
fce0: 00000001 00000000 00648318ffffffc00070fd00ffffffc0000a06a8ffffffc0
fd00:0070fd10ffffffc0000e50b0ffffffc00070fd50ffffffc0000e13e8ffffffc0
fd20: 00000018 00000000 00709000ffffffc000642000ffffffc000642000ffffffc0
fd40: 00000018 00000000 00000000 000000000070fd70ffffffc0000848bcffffffc0
fd60:007095b0ffffffc0000848a4ffffffc00070fdc0ffffffc00008128cffffffc0
fd80:0076f000ffffffc00000400cffffff800070fdf0ffffffc000004010ffffff80
fda0: 60000145 0000000000759cacffffffc00070fdf0ffffffc00070fdf0ffffffc0
fdc0:0070ff10ffffffc000083dacffffffc00070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc000084ef0ffffffc060000145 00000000
ff00:0070c000ffffffc00070c000ffffffc00070ff20ffffffc0000d944cffffffc0
ff20:0070ff80ffffffc000508944ffffffc000768000ffffffc00075b000ffffffc0
ff40:006fb9a0ffffffc00075b000ffffffc0feffde40ffffffc000000000 00000041
ff60:0007b000000000410007d00000000041 00080450ffffffc00050893cffffffc0
ff80:0070ffa0ffffffc0006d68a0ffffffc000000002 000000000075b000ffffffc0
ffa0: 00000000 00000000 00080210 00000041 00000000 0000000000000e1100000000
ffc0: 08000000 00000041500f0000000000000071a00000000041 00000000 00000000
ffe0:006fb9a0ffffffc000000000 00000000 00000000 00000000 00000000 00000000Call trace: [<ffffffc000289304>] clear_bit+0x14/0x30 [<ffffffc0002d7f80>] ack_dynirq+0x20/0x2c [<ffffffc0000e44ec>] handle_edge_irq+0x94/0x18c [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0002da0e8>] evtchn_fifo_handle_events+0x180/0x188 [<ffffffc0002d74c0>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002d7570>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc0000a06a4>] xen_arm_callback+0x8/0x18 [<ffffffc0000e50ac>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc00070fdd0 to 0xffffffc00070fef0)fdc0:
0070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc0[<ffffffc000083da8>] el1_irq+0x68/0xd8 [<ffffffc0000d9448>] cpu_startup_entry+0x114/0x174 [<ffffffc000508940>] rest_init+0x7c/0x88 [<ffffffc0006d689c>] start_kernel+0x350/0x368 Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)Quoted 2 lines
Thanks,
PranavHI Pranav
I've just come back form holidays. The last time I tried run DomU there was Xen crush with syndrome
0x21- looks like alignment trap again ;) Unfortunately, had no chance to play with it yet :(
Quoted 5 lines
Probably, I could post *untested* patch which makes arm64 bitops "friendly" to 32-bit... still awaiting response form arm64 about the best way to deal with it ;)
Vladimir
Hi Pranav
Could you try [1]? Does it fix your case?
[1] http://www.spinics.net/lists/arm-kernel/msg325071.html
Thanks
Vladimir
Hi Vladimir,
Quoted 197 lines · Vladimir Murzin
Quoted 196 lines · Vladimir Murzin
Quoted 181 lines · Pranavkumar Sawargaonkar
Hi Vladimir/David,
Quoted 69 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +3
-3@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);Quoted 4 lines
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-develI have tried this fix on APM X-Gene and it is solving a crash (you have reported) during booting of DOM0.
But while trying out domU when I tried to execute "
/etc/init.d/xencommonsstart || true"
I am observing a similar "alignment fault" crash while performing "clear_bit" in "evtchn_fifo_clear_pending"
Pasting a crash log:root@arm64:~/xen-images# /etc/init.d/xencommons start || true Starting C xenstored.... Unhandled fault: alignment fault (0x96000021) at 0xffffffc0fae7700c Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.15.0-rc1-next-20140417+ #5 task: ffffffc0007188b0 ti: ffffffc00070c000 task.ti: ffffffc00070c000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_clear_pending+0x28/0x30 pc : [<ffffffc000289304>] lr : [<ffffffc0002d9f60>] pstate: 600001c5 sp : ffffffc00070fbb0 x29: ffffffc00070fbb0 x28: ffffffc0fae77000 x27: 000000000000000c x26: 0000000000000003 x25: 00000000dffe0000 x24: 0000000000000000 x23: 0000000000000007 x22: ffffffc000768000 x21: ffffffc0f94a0884 x20: ffffffc000645b80 x19: ffffffc0f94a0800 x18: 0000007f863063e0 x17: 0000007f875d0280 x16: ffffffc0000f93ec x15: 001b92d7f76c3f7d x14: 0000000000000000 x13: 00000003e8000000 x12: 0000000000000018 x11: 0000000000000000 x10: 0000000000000400 x9 : ffffffc00070fd20 x8 : 00000000fe871000 x7 : ffffffc0fa800038 x6 : ffffffc0fa800000 x5 : 00000000fffffffa x4 : 0000000000000000 x3 : 0000000080000000 x2 : 0000000000000001 x1 : ffffffc0fae7700c x0 : 0000000000000000Process swapper/0 (pid: 0, stack limit =
0xffffffc00070c058)Stack: (0xffffffc00070fbb0 to 0xffffffc000710000)fba0:
0070fbc0ffffffc0002d7f84ffffffc0
fbc0:0070fbd0ffffffc0000e44f0ffffffc00070fc00ffffffc0000e13e8ffffffc0
fbe0: 00000002 00000000fef7a900ffffffc000709900ffffffc0000e13d4ffffffc0
fc00:0070fc20ffffffc0002da0ecffffffc0fac39000ffffffc0000d1e80ffffffc0
fc20:0070fca0ffffffc0002d74c4ffffffc0007096ecffffffc0fef7ef10ffffffc0
fc40:0064d878ffffffc000775000ffffffc000000000 00000000 00642500ffffffc0
fc60:006424f8ffffffc000648318ffffffc00070c000ffffffc000000000 00000081
fc80: 00000000 00000000a0000000ffffffc000000000 00000000002d7494ffffffc0
fca0:0070fcf0ffffffc0002d7574ffffffc0fac0c800ffffffc00072cae0ffffffc0
fcc0:fac26500ffffffc000645b80ffffffc000000018 00000000fef79410ffffffc0
fce0: 00000001 00000000 00648318ffffffc00070fd00ffffffc0000a06a8ffffffc0
fd00:0070fd10ffffffc0000e50b0ffffffc00070fd50ffffffc0000e13e8ffffffc0
fd20: 00000018 00000000 00709000ffffffc000642000ffffffc000642000ffffffc0
fd40: 00000018 00000000 00000000 000000000070fd70ffffffc0000848bcffffffc0
fd60:007095b0ffffffc0000848a4ffffffc00070fdc0ffffffc00008128cffffffc0
fd80:0076f000ffffffc00000400cffffff800070fdf0ffffffc000004010ffffff80
fda0: 60000145 0000000000759cacffffffc00070fdf0ffffffc00070fdf0ffffffc0
fdc0:0070ff10ffffffc000083dacffffffc00070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc000084ef0ffffffc060000145 00000000
ff00:0070c000ffffffc00070c000ffffffc00070ff20ffffffc0000d944cffffffc0
ff20:0070ff80ffffffc000508944ffffffc000768000ffffffc00075b000ffffffc0
ff40:006fb9a0ffffffc00075b000ffffffc0feffde40ffffffc000000000 00000041
ff60:0007b000000000410007d00000000041 00080450ffffffc00050893cffffffc0
ff80:0070ffa0ffffffc0006d68a0ffffffc000000002 000000000075b000ffffffc0
ffa0: 00000000 00000000 00080210 00000041 00000000 0000000000000e1100000000
ffc0: 08000000 00000041500f0000000000000071a00000000041 00000000 00000000
ffe0:006fb9a0ffffffc000000000 00000000 00000000 00000000 00000000 00000000Call trace: [<ffffffc000289304>] clear_bit+0x14/0x30 [<ffffffc0002d7f80>] ack_dynirq+0x20/0x2c [<ffffffc0000e44ec>] handle_edge_irq+0x94/0x18c [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0002da0e8>] evtchn_fifo_handle_events+0x180/0x188 [<ffffffc0002d74c0>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002d7570>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc0000a06a4>] xen_arm_callback+0x8/0x18 [<ffffffc0000e50ac>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc00070fdd0 to 0xffffffc00070fef0)fdc0:
0070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc0[<ffffffc000083da8>] el1_irq+0x68/0xd8 [<ffffffc0000d9448>] cpu_startup_entry+0x114/0x174 [<ffffffc000508940>] rest_init+0x7c/0x88 [<ffffffc0006d689c>] start_kernel+0x350/0x368 Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)Quoted 2 lines
Thanks,
PranavHI Pranav
I've just come back form holidays. The last time I tried run DomU there was Xen crush with syndrome
0x21- looks like alignment trap again ;) Unfortunately, had no chance to play with it yet :(Probably, I could post *untested* patch which makes arm64 bitops "friendly" to 32-bit... still awaiting response form arm64 about the best way to deal with it ;)
Quoted 7 lines
Quoted 1 line
Vladimir
Hi Pranav
Could you try [1]? Does it fix your case?
I will try it today in some time.
Quoted 3 lines
Thanks
Vladimir
Thanks,
Pranav
Hi Vladimir,
Quoted 202 lines · Pranavkumar Sawargaonkar
Hi Vladimir,
Quoted 199 lines · Vladimir Murzin
Quoted 197 lines · Vladimir Murzin
Quoted 181 lines · Pranavkumar Sawargaonkar
Hi Vladimir/David,
Quoted 69 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +3
-3@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);Quoted 4 lines
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-develI have tried this fix on APM X-Gene and it is solving a crash (you have reported) during booting of DOM0.
But while trying out domU when I tried to execute "
/etc/init.d/xencommonsstart || true"
I am observing a similar "alignment fault" crash while performing "clear_bit" in "evtchn_fifo_clear_pending"
Pasting a crash log:root@arm64:~/xen-images# /etc/init.d/xencommons start || true Starting C xenstored.... Unhandled fault: alignment fault (0x96000021) at 0xffffffc0fae7700c Internal error: : 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.15.0-rc1-next-20140417+ #5 task: ffffffc0007188b0 ti: ffffffc00070c000 task.ti: ffffffc00070c000 PC is at clear_bit+0x14/0x30 LR is at evtchn_fifo_clear_pending+0x28/0x30 pc : [<ffffffc000289304>] lr : [<ffffffc0002d9f60>] pstate: 600001c5 sp : ffffffc00070fbb0 x29: ffffffc00070fbb0 x28: ffffffc0fae77000 x27: 000000000000000c x26: 0000000000000003 x25: 00000000dffe0000 x24: 0000000000000000 x23: 0000000000000007 x22: ffffffc000768000 x21: ffffffc0f94a0884 x20: ffffffc000645b80 x19: ffffffc0f94a0800 x18: 0000007f863063e0 x17: 0000007f875d0280 x16: ffffffc0000f93ec x15: 001b92d7f76c3f7d x14: 0000000000000000 x13: 00000003e8000000 x12: 0000000000000018 x11: 0000000000000000 x10: 0000000000000400 x9 : ffffffc00070fd20 x8 : 00000000fe871000 x7 : ffffffc0fa800038 x6 : ffffffc0fa800000 x5 : 00000000fffffffa x4 : 0000000000000000 x3 : 0000000080000000 x2 : 0000000000000001 x1 : ffffffc0fae7700c x0 : 0000000000000000Process swapper/0 (pid: 0, stack limit =
0xffffffc00070c058)Stack: (0xffffffc00070fbb0 to 0xffffffc000710000)fba0:
0070fbc0ffffffc0002d7f84ffffffc0
fbc0:0070fbd0ffffffc0000e44f0ffffffc00070fc00ffffffc0000e13e8ffffffc0
fbe0: 00000002 00000000fef7a900ffffffc000709900ffffffc0000e13d4ffffffc0
fc00:0070fc20ffffffc0002da0ecffffffc0fac39000ffffffc0000d1e80ffffffc0
fc20:0070fca0ffffffc0002d74c4ffffffc0007096ecffffffc0fef7ef10ffffffc0
fc40:0064d878ffffffc000775000ffffffc000000000 00000000 00642500ffffffc0
fc60:006424f8ffffffc000648318ffffffc00070c000ffffffc000000000 00000081
fc80: 00000000 00000000a0000000ffffffc000000000 00000000002d7494ffffffc0
fca0:0070fcf0ffffffc0002d7574ffffffc0fac0c800ffffffc00072cae0ffffffc0
fcc0:fac26500ffffffc000645b80ffffffc000000018 00000000fef79410ffffffc0
fce0: 00000001 00000000 00648318ffffffc00070fd00ffffffc0000a06a8ffffffc0
fd00:0070fd10ffffffc0000e50b0ffffffc00070fd50ffffffc0000e13e8ffffffc0
fd20: 00000018 00000000 00709000ffffffc000642000ffffffc000642000ffffffc0
fd40: 00000018 00000000 00000000 000000000070fd70ffffffc0000848bcffffffc0
fd60:007095b0ffffffc0000848a4ffffffc00070fdc0ffffffc00008128cffffffc0
fd80:0076f000ffffffc00000400cffffff800070fdf0ffffffc000004010ffffff80
fda0: 60000145 0000000000759cacffffffc00070fdf0ffffffc00070fdf0ffffffc0
fdc0:0070ff10ffffffc000083dacffffffc00070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc000084ef0ffffffc060000145 00000000
ff00:0070c000ffffffc00070c000ffffffc00070ff20ffffffc0000d944cffffffc0
ff20:0070ff80ffffffc000508944ffffffc000768000ffffffc00075b000ffffffc0
ff40:006fb9a0ffffffc00075b000ffffffc0feffde40ffffffc000000000 00000041
ff60:0007b000000000410007d00000000041 00080450ffffffc00050893cffffffc0
ff80:0070ffa0ffffffc0006d68a0ffffffc000000002 000000000075b000ffffffc0
ffa0: 00000000 00000000 00080210 00000041 00000000 0000000000000e1100000000
ffc0: 08000000 00000041500f0000000000000071a00000000041 00000000 00000000
ffe0:006fb9a0ffffffc000000000 00000000 00000000 00000000 00000000 00000000Call trace: [<ffffffc000289304>] clear_bit+0x14/0x30 [<ffffffc0002d7f80>] ack_dynirq+0x20/0x2c [<ffffffc0000e44ec>] handle_edge_irq+0x94/0x18c [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0002da0e8>] evtchn_fifo_handle_events+0x180/0x188 [<ffffffc0002d74c0>] __xen_evtchn_do_upcall+0x9c/0x144 [<ffffffc0002d7570>] xen_hvm_evtchn_do_upcall+0x8/0x14 [<ffffffc0000a06a4>] xen_arm_callback+0x8/0x18 [<ffffffc0000e50ac>] handle_percpu_devid_irq+0x90/0xb8 [<ffffffc0000e13e4>] generic_handle_irq+0x24/0x40 [<ffffffc0000848b8>] handle_IRQ+0x68/0xe0 [<ffffffc000081288>] gic_handle_irq+0x38/0x80 Exception stack(0xffffffc00070fdd0 to 0xffffffc00070fef0)fdc0:
0070c000ffffffc00070c000ffffffc0
fde0:0070ff10ffffffc000084ef0ffffffc000000000 00000000 00653708ffffffc0
fe00: 00653708ffffffc000000001 00000000 00000018 00000000 00000000 00000000
fe20: 00000001 00000000 00000400 0000000000718db0ffffffc00070fd20ffffffc0
fe40: 00000400 00000000 00000000 00000000 00000018 00000000e800000000000003
fe60: 00000000 00000000f76c3f7d001b92d7000f93ecffffffc0875d02800000007f
fe80:863063e00000007f0070c000ffffffc00070c000ffffffc000761200ffffffc0
fea0:0051e000ffffffc0006424f8ffffffc000759cacffffffc000000001 00000000
fec0: 00648318ffffffc00070c000ffffffc000000000 000000810070ff10ffffffc0
fee0:00084eecffffffc00070ff10ffffffc0[<ffffffc000083da8>] el1_irq+0x68/0xd8 [<ffffffc0000d9448>] cpu_startup_entry+0x114/0x174 [<ffffffc000508940>] rest_init+0x7c/0x88 [<ffffffc0006d689c>] start_kernel+0x350/0x368 Code: 4a030000 d2800022 8b400c21 9ac32043 (c85f7c22)Quoted 2 lines
Thanks,
PranavHI Pranav
I've just come back form holidays. The last time I tried run DomU there was Xen crush with syndrome
0x21- looks like alignment trap again ;) Unfortunately, had no chance to play with it yet :(Probably, I could post *untested* patch which makes arm64 bitops "friendly" to 32-bit... still awaiting response form arm64 about the best way to deal with it ;)
Vladimir
Quoted 7 lines
Quoted 5 lines
Hi Pranav
Could you try [1]? Does it fix your case?
I will try it today in some time.
I have tried your patch along with the suggestion of changing
" add x1, x1, x0, lsr #2 // Get word offset"
to
" mov r0, r0, lsr #5
add r1, r1, r0, lsl #2 @ Get word offset "
This manages me to get DOM0 and DOMU working on XGENE with latest Linux kernel ( 3.15.0-rc1) on XGENE.
Thanks,
Pranav
---------------------- Modified Patch -------
arch/arm64/lib/bitops.S +12 -10
@@ -26,14 +26,15 @@ */ .macro bitop, name, instr ENTRY( \name ) - and w3, w0, #63 // Get bit offset + and w3, w0, #31 // Get bit offset eor w0, w0, w3 // Clear low bits mov x2, #1 - add x1, x1, x0, lsr #3 // Get word offset + lsr x0, x0, #5 + add x1, x1, x0, lsl #2 // Get word offset lsl x3, x2, x3 // Create mask -1: ldxr x2, [x1] - \instr x2, x2, x3 - stxr w0, x2, [x1] +1: ldxr w2, [x1] + \instr w2, w2, w3 + stxr w0, w2, [x1] cbnz w0, 1b ret ENDPROC(\name )
@@ -41,15 +42,16 @@ ENDPROC(\name ) .macro testop, name, instr ENTRY( \name ) - and w3, w0, #63 // Get bit offset + and w3, w0, #31 // Get bit offset eor w0, w0, w3 // Clear low bits mov x2, #1 - add x1, x1, x0, lsr #3 // Get word offset + lsr x0, x0, #5 + add x1, x1, x0, lsl #2 // Get word offset lsl x4, x2, x3 // Create mask -1: ldxr x2, [x1] +1: ldxr w2, [x1] lsr x0, x2, x3 // Save old value of bit - \instr x2, x2, x4 // toggle bit - stlxr w5, x2, [x1] + \instr w2, w2, w4 // toggle bit + stlxr w5, w2, [x1] cbnz w5, 1b dmb ish and x0, x0, #1
Quoted 60 lines · David Vrabel
Quoted 7 lines · Vladimir Murzin
Bitops operations like set/clear/change mandate world aligned pointer, mainly because architectures specific implementation.
Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy used for bitops might not be world aligned.For arm64 it ends up with unaligned access trap...
Thanks. Does this version work for you?
David
8<----------------------
xen/events/fifo: fix alignment for bitops on local ready wordBitops operations like
set_bit(),clear_bit(), andtest_bit()require word aligned pointers, because of architectures specific implementations.Looks that
DEFINE_PER_CPUdoes required alignment forcpu_control_block; however, local copy of the ready word might not be word aligned.For arm64 it ends up with unaligned access trap at:
if (head == 0) clear_bit(priority, BM(ready));Use unsigned long for "ready" to make sure it is word aligned.
Signed-off-by Vladimir Murzin <[email protected]>Signed-off-by David Vrabel <[email protected]--- drivers/xen/events/events_fifo.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/xen/events/events_fifo.c +2
-2@@ -243,7 +243,7 @@ static void handle_irq_for_port(unsigned port)static void consume_one_event (unsigned cpu,struct evtchn_fifo_control_block *control_block, -unsigned priority,uint32_t *ready) +unsigned priority,unsigned long *ready) {struct evtchn_fifo_queue *q = &per_cpu (cpu_queue, cpu);uint32_t head;@@ -273,7 +273,7 @@ static void consume_one_event(unsigned cpu,* copy of the ready word. */ if (head ==0 ) -clear_bit (priority,BM (ready)); +clear_bit (priority, ready);if (sync_test_bit (EVTCHN_FIFO_PENDING ,BM (word)) && !sync_test_bit (EVTCHN_FIFO_MASKED ,BM (word)))
drivers/xen/events/events_fifo.c static void consume_one_event(unsigned cpu, · line 291
Quoted 8 lines
drivers/xen/events/events_fifo.c +1
-1@@ -285,7 +285,7 @@ static void consume_one_event(unsigned cpu,static void evtchn_fifo_handle_events (unsigned cpu) {struct evtchn_fifo_control_block *control_block; -uint32_t ready; +unsigned long ready;unsigned q; control_block =per_cpu (cpu_control_block, cpu);
Yes. It fixes warning and I'm able to boot Dom0.
Vladimir