phy: samsung: add exynos5 SoCs for as simple phy providers

PATCH New Rahul Sharma 4 participants 8 messages Apr 20, 2014 – Apr 21, 2014

Subsystems (3)

Device tree bindings Arm Samsung Exynos Generic PHY framework

lore

Share & tools

lore

Rahul Sharma

author

2014-04-20 10:08 UTC #0 lore raw

cover phy: samsung: add exynos5 SoCs for as simple phy providers

From: Rahul Sharma <[email protected]>

Add Exynos5250 and 5420 as Simple phy providers to the proposed simple phy driver by Tomasz Stanislawski at https://lkml.org/lkml/2014/4/8/226.

Rahul Sharma (2):
phy: samsung: add simple phys for exynos5250 SoC
phy: samsung: add simple phys for exynos5420 SoC

 .../devicetree/bindings/phy/samsung-phy.txt        |   28 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |   17 ++++++++++++
 2 files changed, 45 insertions(+)
 mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c

Signature · 1 line

1.7.9.5

Rahul Sharma

author

2014-04-20 10:08 UTC #1 lore raw

PATCH 1/2 phy: samsung: add simple phys for exynos5250 SoC

From: Rahul Sharma <[email protected]>

Extend the support for simple phys for exynos5250 SoC in simple phy driver.

Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130

---
 .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
 2 files changed, 31 insertions(+)

Documentation/devicetree/bindings/phy/samsung-phy.txt +22 -0

index f97c4c3..f469099 100644
@@ -122,6 +122,7 @@ Required properties:
 - compatible : should be one of the listed compatibles:
 	- "samsung,exynos4210-simple-phy"
 	- "samsung,exynos4412-simple-phy"
+	- "samsung,exynos5250-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;

@@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   0 - HDMI PHY,
   1 - ADC PHY,
 
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,
+
+Example:
+Simple PHY provider node:
+
+	simplephys: simple-phys at 10040000 {
+		compatible = "samsung,exynos5250-simple-phy";
+		reg = <0x10040000 0x10000>;
+		#phy-cells = <1>;
+	};
+
+Other nodes accessing simple PHYs:
+
+	hdmi {
+		phys = <&simplephys 0>;
+		phy-names = "hdmiphy";
+	};

drivers/phy/exynos-simple-phy.c +9 -0

index 57ad338..187f6b1 100644
@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
 	~0, /* end mark */
 };
 
+static const u32 exynos5250_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0718, /* ADC_PHY */
+	0x0724, /* SATA_PHY */
+	~0, /* end mark */
+};
+
 static const struct of_device_id exynos_phy_of_match[] = {
 	{ .compatible = "samsung,exynos4210-simple-phy",
 	  .data = exynos4210_offsets},
 	{ .compatible = "samsung,exynos4412-simple-phy",
 	  .data = exynos4412_offsets},
+	{ .compatible = "samsung,exynos5250-simple-phy",
+	  .data = exynos5250_offsets},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, exynos_phy_of_match);

Signature · 1 line

1.7.9.5

Pankaj Dubey

2014-04-21 00:33 UTC #2 lore raw

PATCH 1/2 phy: samsung: add simple phys for exynos5250 SoC

Hi Rahul,

Quoted 6 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>
Extend the support for simple phys for exynos5250 SoC in simple phy driver.
Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130

Change-Id should be removed. Missing Signed-off-by.

Quoted 67 lines

---
  .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
  drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
  2 files changed, 31 insertions(+)

Documentation/devicetree/bindings/phy/samsung-phy.txt +22 -0

index f97c4c3..f469099 100644
@@ -122,6 +122,7 @@ Required properties:
  - compatible : should be one of the listed compatibles:
  	- "samsung,exynos4210-simple-phy"
  	- "samsung,exynos4412-simple-phy"
+	- "samsung,exynos5250-simple-phy"
  - reg : offset and length of the register set;
  - #phy-cells : from the generic phy bindings, must be 1;

@@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
    0 - HDMI PHY,
    1 - ADC PHY,
 
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,
+
+Example:
+Simple PHY provider node:
+
+	simplephys: simple-phys@10040000 {
+		compatible = "samsung,exynos5250-simple-phy";
+		reg = <0x10040000 0x10000>;
+		#phy-cells = <1>;
+	};
+
+Other nodes accessing simple PHYs:
+
+	hdmi {
+		phys = <&simplephys 0>;
+		phy-names = "hdmiphy";
+	};

drivers/phy/exynos-simple-phy.c +9 -0

index 57ad338..187f6b1 100644
@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
  	~0, /* end mark */
  };
 
+static const u32 exynos5250_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0718, /* ADC_PHY */
+	0x0724, /* SATA_PHY */
+	~0, /* end mark */
+};
+
  static const struct of_device_id exynos_phy_of_match[] = {
  	{ .compatible = "samsung,exynos4210-simple-phy",
  	  .data = exynos4210_offsets},
  	{ .compatible = "samsung,exynos4412-simple-phy",
  	  .data = exynos4412_offsets},
+	{ .compatible = "samsung,exynos5250-simple-phy",
+	  .data = exynos5250_offsets},
  	{ },
  };
  MODULE_DEVICE_TABLE(of, exynos_phy_of_match);

Signature · 2 lines

Best Regards,
Pankaj Dubey

Rahul Sharma

2014-04-21 05:51 UTC #3 lore raw

PATCH 1/2 phy: samsung: add simple phys for exynos5250 SoC

oops. Sorry, I will change that.

Quoted 89 lines · Pankaj Dubey

Hi Rahul,

Quoted 7 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>
Extend the support for simple phys for exynos5250 SoC in simple phy driver.
Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130

Change-Id should be removed. Missing Signed-off-by.

Quoted 58 lines

---
  .../devicetree/bindings/phy/samsung-phy.txt        |   22
++++++++++++++++++++
  drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
  2 files changed, 31 insertions(+)

Documentation/devicetree/bindings/phy/samsung-phy.txt +1 -0

index f97c4c3..f469099 100644
@@ -122,6 +122,7 @@ Required properties:
  - compatible : should be one of the listed compatibles:
        - "samsung,exynos4210-simple-phy"
        - "samsung,exynos4412-simple-phy"
+       - "samsung,exynos5250-simple-phy"
  - reg : offset and length of the register set;
  - #phy-cells : from the generic phy bindings, must be 1;
  @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its

meaning is as follows:
0 - HDMI PHY,
1 - ADC PHY,
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in

Documentation/devicetree/bindings/phy/samsung-phy.txt +20 -0

+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,
+
+Example:
+Simple PHY provider node:
+
+       simplephys: simple-phys at 10040000 {
+               compatible = "samsung,exynos5250-simple-phy";
+               reg = <0x10040000 0x10000>;
+               #phy-cells = <1>;
+       };
+
+Other nodes accessing simple PHYs:
+
+       hdmi {
+               phys = <&simplephys 0>;
+               phy-names = "hdmiphy";
+       };

drivers/phy/exynos-simple-phy.c +6 -0

index 57ad338..187f6b1 100644
@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
        ~0, /* end mark */
  };
  +static const u32 exynos5250_offsets[] = {
+       0x0700, /* HDMI_PHY */
+       0x0718, /* ADC_PHY */
+       0x0724, /* SATA_PHY */
+       ~0, /* end mark */
+};
+

drivers/phy/exynos-simple-phy.c static const u32 exynos4412_offsets[] = { · line 82

Quoted 10 lines

drivers/phy/exynos-simple-phy.c +2 -0

  static const struct of_device_id exynos_phy_of_match[] = {
        { .compatible = "samsung,exynos4210-simple-phy",
          .data = exynos4210_offsets},
        { .compatible = "samsung,exynos4412-simple-phy",
          .data = exynos4412_offsets},
+       { .compatible = "samsung,exynos5250-simple-phy",
+         .data = exynos5250_offsets},
        { },
  };
  MODULE_DEVICE_TABLE(of, exynos_phy_of_match);

--
Best Regards,
Pankaj Dubey

Sachin Kamat

2014-04-21 05:54 UTC #4 lore raw

PATCH 1/2 phy: samsung: add simple phys for exynos5250 SoC

In reply to Rahul Sharma

Hi Rahul,

Quoted 24 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>

Extend the support for simple phys for exynos5250 SoC in simple phy driver.

Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130

---
 .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
 2 files changed, 31 insertions(+)

Documentation/devicetree/bindings/phy/samsung-phy.txt +1 -0

index f97c4c3..f469099 100644
@@ -122,6 +122,7 @@ Required properties:
 - compatible : should be one of the listed compatibles:
        - "samsung,exynos4210-simple-phy"
        - "samsung,exynos4412-simple-phy"
+       - "samsung,exynos5250-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;

Documentation/devicetree/bindings/phy/samsung-phy.txt the PHY specifier identifies the PHY and its meaning is as follows: · line 146

Quoted 8 lines

Documentation/devicetree/bindings/phy/samsung-phy.txt +5 -0

@@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   0 - HDMI PHY,
   1 - ADC PHY,
 
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,

What is the difference between 1 and 2? Probably it should be SATA?

Quoted 31 lines

Documentation/devicetree/bindings/phy/samsung-phy.txt +16 -0

+
+Example:
+Simple PHY provider node:
+
+       simplephys: simple-phys at 10040000 {
+               compatible = "samsung,exynos5250-simple-phy";
+               reg = <0x10040000 0x10000>;
+               #phy-cells = <1>;
+       };
+
+Other nodes accessing simple PHYs:
+
+       hdmi {
+               phys = <&simplephys 0>;
+               phy-names = "hdmiphy";
+       };

drivers/phy/exynos-simple-phy.c +7 -0

index 57ad338..187f6b1 100644
@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
        ~0, /* end mark */
 };
 
+static const u32 exynos5250_offsets[] = {
+       0x0700, /* HDMI_PHY */
+       0x0718, /* ADC_PHY */
+       0x0724, /* SATA_PHY */
+       ~0, /* end mark */
+};
+

Signature · 2 lines

With warm regards,
Sachin

Rahul Sharma

2014-04-21 05:58 UTC #5 lore raw

PATCH 1/2 phy: samsung: add simple phys for exynos5250 SoC

Thanks Sachin,

Quoted 30 lines · Sachin Kamat

Hi Rahul,

Quoted 27 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>

Extend the support for simple phys for exynos5250 SoC in simple phy driver.

Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130

---
 .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
 2 files changed, 31 insertions(+)

Documentation/devicetree/bindings/phy/samsung-phy.txt +1 -0

index f97c4c3..f469099 100644
@@ -122,6 +122,7 @@ Required properties:
 - compatible : should be one of the listed compatibles:
        - "samsung,exynos4210-simple-phy"
        - "samsung,exynos4412-simple-phy"
+       - "samsung,exynos5250-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;

@@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   0 - HDMI PHY,
   1 - ADC PHY,

Quoted 8 lines

Documentation/devicetree/bindings/phy/samsung-phy.txt the PHY specifier identifies the PHY and its meaning is as follows: · line 146
Quoted 5 lines
Documentation/devicetree/bindings/phy/samsung-phy.txt +5 -0
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,
What is the difference between 1 and 2? Probably it should be SATA?

yea correct. it is Sata.

Quoted 37 lines

Quoted 21 lines

Documentation/devicetree/bindings/phy/samsung-phy.txt +16 -0

+
+Example:
+Simple PHY provider node:
+
+       simplephys: simple-phys at 10040000 {
+               compatible = "samsung,exynos5250-simple-phy";
+               reg = <0x10040000 0x10000>;
+               #phy-cells = <1>;
+       };
+
+Other nodes accessing simple PHYs:
+
+       hdmi {
+               phys = <&simplephys 0>;
+               phy-names = "hdmiphy";
+       };

drivers/phy/exynos-simple-phy.c +0 -0

index 57ad338..187f6b1 100644

drivers/phy/exynos-simple-phy.c static const u32 exynos4412_offsets[] = { · line 73

Quoted 10 lines

drivers/phy/exynos-simple-phy.c +7 -0

@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
        ~0, /* end mark */
 };
 
+static const u32 exynos5250_offsets[] = {
+       0x0700, /* HDMI_PHY */
+       0x0718, /* ADC_PHY */
+       0x0724, /* SATA_PHY */
+       ~0, /* end mark */
+};
+

--
With warm regards,
Sachin

Rahul Sharma

author

2014-04-20 10:08 UTC #6 lore raw

PATCH 2/2 phy: samsung: add simple phys for exynos5420 SoC

In reply to Rahul Sharma

From: Rahul Sharma <[email protected]>

Extend the support for simple phys for exynos5420
SoC in simple phy driver.

Change-Id I0ab7b59b1f013db9e924fc868bd8b1b6ed8acbb3

Signed-off-by Rahul Sharma <[email protected]>

---
 .../devicetree/bindings/phy/samsung-phy.txt        |    6 ++++++
 drivers/phy/exynos-simple-phy.c                    |    8 ++++++++
 2 files changed, 14 insertions(+)
 mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c

Documentation/devicetree/bindings/phy/samsung-phy.txt +6 -0

index f469099..f0ae619 100644
@@ -123,6 +123,7 @@ Required properties:
 	- "samsung,exynos4210-simple-phy"
 	- "samsung,exynos4412-simple-phy"
 	- "samsung,exynos5250-simple-phy"
+	- "samsung,exynos5420-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;

@@ -145,6 +146,11 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   1 - ADC PHY,
   2 - ADC PHY,
 
+For "samsung,exynos5420-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+
 Example:
 Simple PHY provider node:

drivers/phy/exynos-simple-phy.c +8 -0

old mode 100644
new mode 100755
index 187f6b1..9681a43
@@ -71,6 +71,12 @@ static const u32 exynos5250_offsets[] = {
 	~0, /* end mark */
 };
 
+static const u32 exynos5420_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0720, /* ADC_PHY */
+	~0, /* end mark */
+};
+
 static const struct of_device_id exynos_phy_of_match[] = {
 	{ .compatible = "samsung,exynos4210-simple-phy",
 	  .data = exynos4210_offsets},

@@ -78,6 +84,8 @@ static const struct of_device_id exynos_phy_of_match[] = {
 	  .data = exynos4412_offsets},
 	{ .compatible = "samsung,exynos5250-simple-phy",
 	  .data = exynos5250_offsets},
+	{ .compatible = "samsung,exynos5420-simple-phy",
+	  .data = exynos5420_offsets},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, exynos_phy_of_match);

Signature · 1 line

1.7.9.5

Pankaj Dubey

2014-04-21 00:34 UTC #7 lore raw

PATCH 2/2 phy: samsung: add simple phys for exynos5420 SoC

Hi Rahul,

Quoted 6 lines · Rahul Sharma

From: Rahul Sharma <[email protected]>
Extend the support for simple phys for exynos5420
SoC in simple phy driver.
Change-Id: I0ab7b59b1f013db9e924fc868bd8b1b6ed8acbb3

Change-Id should be removed.

Quoted 6 lines

Signed-off-by Rahul Sharma <[email protected]>
---
  .../devicetree/bindings/phy/samsung-phy.txt        |    6 ++++++
  drivers/phy/exynos-simple-phy.c                    |    8 ++++++++
  2 files changed, 14 insertions(+)
mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c

File permission should not be changed.

Quoted 53 lines

Documentation/devicetree/bindings/phy/samsung-phy.txt +6 -0

index f469099..f0ae619 100644
@@ -123,6 +123,7 @@ Required properties:
  	- "samsung,exynos4210-simple-phy"
  	- "samsung,exynos4412-simple-phy"
  	- "samsung,exynos5250-simple-phy"
+	- "samsung,exynos5420-simple-phy"
  - reg : offset and length of the register set;
  - #phy-cells : from the generic phy bindings, must be 1;

@@ -145,6 +146,11 @@ the PHY specifier identifies the PHY and its meaning is as follows:
    1 - ADC PHY,
    2 - ADC PHY,
 
+For "samsung,exynos5420-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+
  Example:
  Simple PHY provider node:

drivers/phy/exynos-simple-phy.c +8 -0

old mode 100644
new mode 100755
index 187f6b1..9681a43
@@ -71,6 +71,12 @@ static const u32 exynos5250_offsets[] = {
  	~0, /* end mark */
  };
 
+static const u32 exynos5420_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0720, /* ADC_PHY */
+	~0, /* end mark */
+};
+
  static const struct of_device_id exynos_phy_of_match[] = {
  	{ .compatible = "samsung,exynos4210-simple-phy",
  	  .data = exynos4210_offsets},

@@ -78,6 +84,8 @@ static const struct of_device_id exynos_phy_of_match[] = {
  	  .data = exynos4412_offsets},
  	{ .compatible = "samsung,exynos5250-simple-phy",
  	  .data = exynos5250_offsets},
+	{ .compatible = "samsung,exynos5420-simple-phy",
+	  .data = exynos5420_offsets},
  	{ },
  };
  MODULE_DEVICE_TABLE(of, exynos_phy_of_match);

Signature · 2 lines

Best Regards,
Pankaj Dubey