Bluetooth: btusb: Add BCM20702 firmware upgrade support
Hi Marcel,
Sorry for creating a new thread instead since I didn't subscribe this mailing list.
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Interestingly, now that I look at that page more closely, Ubuntu 12.04 LTS with kernel 3.8 supports this already? Has Ubuntu made a patch that bluetooth-next doesn't have?
That is Ubuntu for you. They just push patches into their kernel and never give them back to upstream or make sure they get merged into bluetooth-next. I really dislike that behavior. It is always the easy way out instead of trying to do the right thing.
See this page: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1065400
It is a stupid userspace version that is racy as hell. Even the bug mentions that it should be done in the kernel. And I am pretty sure that was my initial comment as well. Just posting the userspace patch for reference.
No it's not the stupid userspace loader you're referring to.
And no, these patches are not pushed into Ubuntu kernel only.
These stupid patches were sent to this mailing list for review, for three or four times, and all of them were rejected by you. The latest version of patches that got rejected should be quite similar to Petri's.
Regards,
Jesse
Marcel Holtmann
maintainerHi Jesse,
Quoted 11 lines
Sorry for creating a new thread instead since I didn't subscribe this mailing list.
Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Interestingly, now that I look at that page more closely, Ubuntu 12.04 LTS with kernel 3.8 supports this already? Has Ubuntu made a patch that bluetooth-next doesn't have?
That is Ubuntu for you. They just push patches into their kernel and never give them back to upstream or make sure they get merged into bluetooth-next. I really dislike that behavior. It is always the easy way out instead of trying to do the right thing.
See this page: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1065400
Quoted 7 lines
Quoted 1 line
It is a stupid userspace version that is racy as hell. Even the bug mentions that it should be done in the kernel. And I am pretty sure that was my initial comment as well. Just posting the userspace patch for reference.
No it's not the stupid userspace loader you're referring to.
And no, these patches are not pushed into Ubuntu kernel only.
These stupid patches were sent to this mailing list for review, for three or four times, and all of them were rejected by you. The latest version of patches that got rejected should be quite similar to Petri's.
so do you have answers to all the questions I raised with Petri? I can go through the archive and read my own comments, but if I rejected the patches, then there was a reason for that.
Regards
Marcel
Hi Marcel,
2014-04-22 2:19 GMT+08:00 Marcel Holtmann <[email protected]>:
Quoted 3 lines
Hi Jesse,
Quoted 1 line
Sorry for creating a new thread instead since I didn't subscribe this ma=
iling list.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Interestingly, now that I look at that page more closely, Ubuntu 12.=
04
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
LTS with kernel 3.8 supports this already? Has Ubuntu made a patch that bluetooth-next doesn't have?
That is Ubuntu for you. They just push patches into their kernel and =
never give them back to upstream or make sure they get merged into bluetoot= h-next. I really dislike that behavior. It is always the easy way out inste= ad of trying to do the right thing.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
See this page: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/10=
65400
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
It is a stupid userspace version that is racy as hell. Even the bug men=
tions that it should be done in the kernel. And I am pretty sure that was m= y initial comment as well. Just posting the userspace patch for reference.
Quoted 6 lines
Quoted 6 lines
No it's not the stupid userspace loader you're referring to.
And no, these patches are not pushed into Ubuntu kernel only.
These stupid patches were sent to this mailing list for review, for thre=
e or four times, and all of them were rejected by you. The latest version o= f patches that got rejected should be quite similar to Petri's.
Quoted 2 lines
so do you have answers to all the questions I raised with Petri? I can go=
through the archive and read my own comments, but if I rejected the patche=
s, then there was a reason for that.
You did have a reason, and I don't complain about the rejection at all.
The reason I reply is that Petri asked why there's a patch in Ubuntu and not in upstream, and, with all due respect, the answer of "That is Ubuntu for you. They just push patches into their kernel and never give them back to upstream or make sure they get merged into bluetooth-next." doesn't reflect what happened. The launchpad link Petri mentioned is all about patching btusb instead of using userspace loader, but guess you're too busy to read the short description.
For Petri's question, patches have been rejected for several times. Since these patchram modules are equipped on more and more devices recently, making them supported is better than just leaving them unsupported, even with a solution that does not perfectly match the expectation of upstream IMHO. That's why I tried to push these rejected patches into Ubuntu kernel. The Ubuntu kernel team accepted them though they do have concerns about these patches are not accepted by upstream. I'm still working on a solution when I have time to do so.
And as I didn't subscribe to this mailing list, would you mind to show me the questions you're referring to? Most likely I won't have answers to all of the questions, after all, all the clue I have is the userspace loader. But I'd be more than happy to give it a try.
Regards,
Jesse