Skip to contentSkip to conversation

powerpc/mpc85xx: Remove QE firmware copy from NAND

PATCH New Prabhakar Kushwaha 3 participants 4 messages Apr 21, 2014 – Apr 23, 2014 PowerPC

lore
Share & tools
lore

Prabhakar Kushwaha

author
#0 lore raw

PATCH 1/1 powerpc/mpc85xx: Remove QE firmware copy from NAND

qe_init() does not use data copied from NAND. Thise code is not tested or complied causing compilation error during NAND boot

So, remove QE firmware copy from NAND to ddr.

Signed-off-by Prabhakar Kushwaha <[email protected]>
---
 arch/powerpc/cpu/mpc85xx/cpu_init.c |   13 -------------
 1 file changed, 13 deletions(-)
arch/powerpc/cpu/mpc85xx/cpu_init.c +0 -13
index ea41ffc..36ef232 100644
@@ -925,19 +925,6 @@ void cpu_secondary_init_r(void)
 #endif
 
 #ifdef CONFIG_QE
-#ifdef CONFIG_SYS_QE_FMAN_FW_IN_NAND
-	int ret;
-	size_t fw_length = CONFIG_SYS_QE_FMAN_FW_LENGTH;
-
-	/* load QE firmware from NAND flash to DDR first */
-	ret = nand_read(&nand_info[0], (loff_t)CONFIG_SYS_QE_FMAN_FW_IN_NAND,
-			&fw_length, (u_char *)CONFIG_SYS_QE_FW_ADDR);
-
-	if (ret && ret == -EUCLEAN) {
-		printf ("NAND read for QE firmware at offset %x failed %d\n",
-				CONFIG_SYS_QE_FMAN_FW_IN_NAND, ret);
-	}
-#endif
 	qe_init(qe_base);
 	qe_reset();
 #endif
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 powerpc/mpc85xx: Remove QE firmware copy from NAND

Quoted 6 lines · Prabhakar Kushwaha

qe_init() does not use data copied from NAND. Thise code is not tested or complied causing compilation error during NAND boot

So, remove QE firmware copy from NAND to ddr.

Signed-off-by Prabhakar Kushwaha <[email protected]>

Where does the QE firmware come from when booting from NAND?

-Scott

author
#2 lore raw

PATCH 1/1 powerpc/mpc85xx: Remove QE firmware copy from NAND

Quoted 10 lines · Scott Wood
Quoted 6 lines · Prabhakar Kushwaha

qe_init() does not use data copied from NAND. Thise code is not tested or complied causing compilation error during NAND boot

So, remove QE firmware copy from NAND to ddr.

Signed-off-by Prabhakar Kushwaha <[email protected]>

Where does the QE firmware come from when booting from NAND?

QE firmware load from NAND is currently not being supported.

Even if it is supported, cpu_init.c file should not have code of loading QE firmware.

-prabhakar

#3 lore raw

PATCH 1/1 powerpc/mpc85xx: Remove QE firmware copy from NAND

In reply to Prabhakar Kushwaha
Quoted 7 lines · Prabhakar Kushwaha

qe_init() does not use data copied from NAND. Thise code is not tested or complied causing compilation error during NAND boot

So, remove QE firmware copy from NAND to ddr.

Signed-off-by Prabhakar Kushwaha <[email protected]>

---

Applied to u-boot-mpc85xx/master, thanks.

York