Skip to contentSkip to conversation

powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

PATCH New Aneesh Bansal 3 participants 6 messages Jan 20, 2014 – Apr 23, 2014 1 message not in the archive

lore
Share & tools
lore

Aneesh Bansal

author
#0 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>
---
 include/configs/P1010RDB.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/P1010RDB.h +1 -2
index c21cf07..b0e51fb 100644
@@ -455,8 +455,7 @@ extern unsigned long get_sdram_size(void);
 #endif
 
 #ifdef CONFIG_SYS_FSL_ERRATUM_IFC_A003399
-#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)\
-	&& !defined(CONFIG_SECURE_BOOT)
+#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)
 #define CONFIG_A003399_NOR_WORKAROUND
 #endif
 #endif
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 14 lines · Aneesh Bansal

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>
---
 include/configs/P1010RDB.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/P1010RDB.h +0 -0
index c21cf07..b0e51fb 100644

include/configs/P1010RDB.h extern unsigned long get_sdram_size(void); · line 461

Quoted 9 lines
include/configs/P1010RDB.h +1 -2
@@ -455,8 +455,7 @@ extern unsigned long get_sdram_size(void);
 #endif
 
 #ifdef CONFIG_SYS_FSL_ERRATUM_IFC_A003399
-#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)\
-	&& !defined(CONFIG_SECURE_BOOT)
+#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)
 #define CONFIG_A003399_NOR_WORKAROUND
 #endif
 #endif

Why do you need the workaround? Doesn't secure boot involve the bootrom loading U-Boot into SRAM, rather than execute-in-place from NOR?

-Scott

author
#2 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 27 lines
Quoted 14 lines

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>
---
 include/configs/P1010RDB.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/P1010RDB.h +0 -0
index c21cf07..b0e51fb 100644

include/configs/P1010RDB.h extern unsigned long get_sdram_size(void); · line 461

Quoted 9 lines
include/configs/P1010RDB.h +1 -2
@@ -455,8 +455,7 @@ extern unsigned long get_sdram_size(void);
 #endif
 
 #ifdef CONFIG_SYS_FSL_ERRATUM_IFC_A003399
-#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)\
-     && !defined(CONFIG_SECURE_BOOT)
+#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)
 #define CONFIG_A003399_NOR_WORKAROUND
 #endif
 #endif

Why do you need the workaround? Doesn't secure boot involve the bootrom loading U-Boot into SRAM, rather than execute-in-place from NOR?

Quoted 1 line

-Scott

The Boot ROM code does not copy the U-boot from NOR into SRAM. In case of secure boot from NOR, it is executed as an execute-in-place memory and so this workaround is required.

Regards,
Aneesh Bansal

A message that is not in the archive (sent off-list or not yet received): e11ecd6cbd4e4d5280731bae97c37073@DM2PR03MB415.namprd03.prod.outlook.com

#4 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 32 lines · On Sun, 2014-01-26 at 23:27 -0600, Bansal Aneesh-B39320 wrote:
Quoted 32 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, January 21, 2014 3:36 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495
Subject: Re: [PATCH 2/3] powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 13 lines · Aneesh Bansal

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>
---
 include/configs/P1010RDB.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/configs/P1010RDB.h +0 -0
index c21cf07..b0e51fb 100644

include/configs/P1010RDB.h extern unsigned long get_sdram_size(void); #endif · line 458

Quoted 6 lines
include/configs/P1010RDB.h +1 -2
@@ -455,8 +455,7 @@ extern unsigned long get_sdram_size(void);  #endif
 
 #ifdef CONFIG_SYS_FSL_ERRATUM_IFC_A003399
-#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)\
-	&& !defined(CONFIG_SECURE_BOOT)
+#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)
 #define CONFIG_A003399_NOR_WORKAROUND  #endif  #endif

Why do you need the workaround? Doesn't secure boot involve the bootrom loading U-Boot into SRAM, rather than execute-in-place from NOR?

Quoted 5 lines
Quoted 2 lines

-Scott

The Boot ROM code does not copy the U-boot from NOR into SRAM. In case of secure boot from NOR, it is executed as an execute-in-place memory and so this workaround is required.

That doesn't sound very secure.

-Scott

author
#5 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 45 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, January 29, 2014 2:38 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495
Subject: Re: [PATCH 2/3] powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 24 lines · On Sun, 2014-01-26 at 23:27 -0600, Bansal Aneesh-B39320 wrote:
Quoted 24 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, January 21, 2014 3:36 AM
To: Bansal Aneesh-B39320
Cc: u-boot at lists.denx.de; Sun York-R58495
Subject: Re: [PATCH 2/3] powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

Quoted 15 lines · Aneesh Bansal

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>
---
 include/configs/P1010RDB.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
(quoted diff) +0 -0

b/include/configs/P1010RDB.h index c21cf07..b0e51fb 100644

include/configs/P1010RDB.h +0 -0
@@ -455,8 +455,7 @@ extern unsigned long get_sdram_size(void);
 #endif
Quoted 8 lines
Quoted 8 lines

include/configs/P1010RDB.h extern unsigned long get_sdram_size(void);

Quoted 5 lines
include/configs/P1010RDB.h +1 -2
 #ifdef CONFIG_SYS_FSL_ERRATUM_IFC_A003399
-#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)\
-	&& !defined(CONFIG_SECURE_BOOT)
+#if !defined(CONFIG_SPL) && !defined(CONFIG_SYS_RAMBOOT)
 #define CONFIG_A003399_NOR_WORKAROUND  #endif  #endif

Why do you need the workaround? Doesn't secure boot involve the bootrom loading U-Boot into SRAM, rather than execute-in-place from

NOR?

Quoted 3 lines
Quoted 3 lines

-Scott

Quoted 8 lines
Quoted 3 lines

The Boot ROM code does not copy the U-boot from NOR into SRAM. In case of secure boot from NOR, it is executed as an execute-in-place memory and so this workaround is required.

That doesn't sound very secure.

-Scott

Can you please elaborate on the kind of security threats that you see with this approach. If you are concerned about someone replacing the NOR flash at runtime, then we have the Hardware Tamper detect mechanism to deal with that.
So, currently the bootROM code does not copy from NOR to SRAM.

#6 lore raw

PATCH 2/3 powerpc/p1010rdb: SECURE BOOT- enable workaround for IFC errata A003399

In reply to Aneesh Bansal
Quoted 6 lines · Aneesh Bansal

The workaround for IFC errata A003399 was not enabled in case of secure boot. So, secure boot from NOR was not working.

Signed-off-by Aneesh Bansal <[email protected]>

---

Applied to u-boot-mpc85xx/master, thanks.

York