Skip to contentSkip to conversation

fsl/usb: Fix phy type for Second USB controller

PATCH New Nikhil Badola 2 participants 2 messages Dec 19, 2013 – Apr 23, 2014

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Nikhil Badola

author
#0 lore raw

PATCH 1/1 fsl/usb: Fix phy type for Second USB controller

Set correct phy_type value for second USB controller. This is required for supporting SOCs having 2 USB controllers working simultaneously, one with UTMI phy and other with ULPI phy

Signed-off-by Nikhil Badola <[email protected]>
---
 drivers/usb/host/ehci-fsl.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-fsl.c +6 -2
index 45e5d6a..0d19daa 100644
@@ -41,11 +41,14 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 	struct usb_ehci *ehci = NULL;
 	const char *phy_type = NULL;
 	size_t len;
+	char current_usb_controller[5];
 #ifdef CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
 	char usb_phy[5];
 
 	usb_phy[0] = '\0';
 #endif
+	memset(current_usb_controller, '\0', 5);
+	snprintf(current_usb_controller, 4, "usb%d", index+1);
 
 	switch (index) {
 	case 0:

@@ -70,8 +73,9 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 	out_be32(&ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
 
 	/* Init phy */
-	if (hwconfig_sub("usb1", "phy_type"))
-		phy_type = hwconfig_subarg("usb1", "phy_type", &len);
+	if (hwconfig_sub(current_usb_controller, "phy_type"))
+		phy_type = hwconfig_subarg(current_usb_controller,
+				"phy_type", &len);
 	else
 		phy_type = getenv("usb_phy_type");
Signature · 1 line
1.7.11.7
#1 lore raw

PATCH 1/1 fsl/usb: Fix phy type for Second USB controller

Quoted 6 lines · Nikhil Badola

Set correct phy_type value for second USB controller. This is required for supporting SOCs having 2 USB controllers working simultaneously, one with UTMI phy and other with ULPI phy

Signed-off-by Nikhil Badola <[email protected]>

---

Applied to u-boot-mpc85xx/master, thanks.

York