Skip to contentSkip to conversation

ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

PATCH New Javi Merino 4 participants 9 messages Apr 25, 2014 – May 13, 2014

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Javi Merino

author
#0 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Signed-off-by Javi Merino <[email protected]>

---

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this patch.

Cheers,
Javi

 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/exynos5420-arndale-octa.dts +0 -1
index 80a3bf4..722fb6c 100644
@@ -64,7 +64,6 @@
 		samsung,dw-mshc-ddr-timing = <1 2>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
-		vmmc-supply = <&ldo10_reg>;
 
 		slot at 0 {
 			reg = <0>;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Hi Javi,

Quoted 13 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Quoted 8 lines
Signed-off-by Javi Merino <[email protected]>

---

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Best regards,
Tomasz

author
#2 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Quoted 19 lines · Tomasz Figa

Hi Javi,

Quoted 16 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Signed-off-by Javi Merino <[email protected]>

---

Quoted 8 lines
Quoted 5 lines

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,
Javi

#3 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Quoted 29 lines · Javi Merino
Quoted 19 lines · Tomasz Figa

Hi Javi,

Quoted 16 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Signed-off-by Javi Merino <[email protected]>

---

Quoted 8 lines
Quoted 5 lines

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Quoted 7 lines

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,

Well, unfortunately exynos_defconfig is known to be far from being reasonable. Right now it should be considered just as a base to configure the kernel for Exynos SoCs. Most of board specific options (and many of SoC-wide ones) need to be selected manually.

Anyway, with the number of Exynos boards supported in mainline, I don't think we will be ever going to enable all options for all the supported boards by default in defconfig, especially considering the fact that we will be moving to generic multi_v7_defconfig and likely dropping exynos_defconfig completely.

As for now, I believe you should just make sure yourself that any options relevant to your board are enabled.

Best regards,
Tomasz

author
#4 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Quoted 41 lines · Tomasz Figa
Quoted 27 lines · Javi Merino
Quoted 17 lines · Tomasz Figa
Quoted 16 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not found, assuming 1 slot is available
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests probe deferral
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not found, assuming 1 slot is available
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests probe deferral

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Signed-off-by Javi Merino <[email protected]>

---

Quoted 8 lines
Quoted 5 lines

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply this patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Quoted 7 lines

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,

Well, unfortunately exynos_defconfig is known to be far from being reasonable. Right now it should be considered just as a base to configure the kernel for Exynos SoCs. Most of board specific options (and many of SoC-wide ones) need to be selected manually.

Quoted 8 lines

Anyway, with the number of Exynos boards supported in mainline, I don't think we will be ever going to enable all options for all the supported boards by default in defconfig, especially considering the fact that we will be moving to generic multi_v7_defconfig and likely dropping exynos_defconfig completely.

As for now, I believe you should just make sure yourself that any options relevant to your board are enabled.

Great. And I assume that there isn't a list of those options in the web. So how do I know what options are relevant to my board? By sending emails to linux-samsung-soc whenever it fails to boot?

Cheers,
Javi

#5 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Quoted 22 lines · Javi Merino
Quoted 9 lines · Tomasz Figa
Quoted 8 lines · Javi Merino
Quoted 7 lines · Tomasz Figa
Quoted 6 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Quoted 31 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Signed-off-by Javi Merino <[email protected]>

---

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply

this

Quoted 23 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Quoted 7 lines

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,

Well, unfortunately exynos_defconfig is known to be far from being reasonable. Right now it should be considered just as a base to configure the kernel for Exynos SoCs. Most of board specific options (and many of SoC-wide ones) need to be selected manually.

Anyway, with the number of Exynos boards supported in mainline, I don't think we will be ever going to enable all options for all the supported boards by default in defconfig, especially considering the fact that we will be moving to generic multi_v7_defconfig and likely dropping exynos_defconfig completely.

Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?

Quoted 8 lines
Quoted 3 lines

As for now, I believe you should just make sure yourself that any options relevant to your board are enabled.

Great. And I assume that there isn't a list of those options in the web. So how do I know what options are relevant to my board? By sending emails to linux-samsung-soc whenever it fails to boot?

I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.

Thanks,
Kukjin

#6 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Hi Javi,

Quoted 58 lines · Kukjin Kim
Quoted 22 lines · Javi Merino
Quoted 9 lines · Tomasz Figa
Quoted 8 lines · Javi Merino
Quoted 7 lines · Tomasz Figa
Quoted 6 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Quoted 31 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Signed-off-by Javi Merino <[email protected]>

---

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply

this

Quoted 23 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Quoted 7 lines

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,

Well, unfortunately exynos_defconfig is known to be far from being reasonable. Right now it should be considered just as a base to configure the kernel for Exynos SoCs. Most of board specific options (and many of SoC-wide ones) need to be selected manually.

Anyway, with the number of Exynos boards supported in mainline, I don't think we will be ever going to enable all options for all the supported boards by default in defconfig, especially considering the fact that we will be moving to generic multi_v7_defconfig and likely dropping exynos_defconfig completely.

Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

As for now, I believe you should just make sure yourself that any options relevant to your board are enabled.

Great. And I assume that there isn't a list of those options in the web. So how do I know what options are relevant to my board? By sending emails to linux-samsung-soc whenever it fails to boot?

I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.

You need the following patch to mount the MMC. Without this the regulator will not be enabled which is required by MMC.

ARM: exynos_defconfig: Enable HS-I2C
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527

Kukjin, can you please apply this patch?

Signature · 2 lines
With warm regards,
Sachin
author
#7 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Hi Sachin,

Quoted 66 lines · Sachin Kamat
Quoted 65 lines · Kukjin Kim
Quoted 22 lines · Javi Merino
Quoted 9 lines · Tomasz Figa
Quoted 8 lines · Javi Merino
Quoted 7 lines · Tomasz Figa
Quoted 6 lines · Javi Merino

d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc at 12200000 and mmc at 12220000 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews:

[    5.060000] dwmmc_exynos 12200000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.065000] platform 12200000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.075000] dwmmc_exynos 12220000.mmc: num-slots property not

found, assuming 1 slot is available

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
[    5.085000] platform 12220000.mmc: Driver dwmmc_exynos requests

probe deferral

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

And eventually hangs. Without the vmmc-supply property in the mmc at 12220000 node, the kernel boots again.

Quoted 31 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Signed-off-by Javi Merino <[email protected]>

---

Hi,

Note that I don't know *why* removing the property works, all I know is that 3.15-rc2 fails to boot on my Arndale Octa unless I apply

this

Quoted 23 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

patch.

Are you sure you have the required PMIC driver enabled in your kernel config?

Quoted 7 lines

I configured the kernel using exynos_defconfig and that gives me:

# CONFIG_PMIC_ADP5520 is not set
# CONFIG_PMIC_DA903X is not set

Should I be using other defconfig for this board? exynos_defconfig used to work in 3.14. Cheers,

Well, unfortunately exynos_defconfig is known to be far from being reasonable. Right now it should be considered just as a base to configure the kernel for Exynos SoCs. Most of board specific options (and many of SoC-wide ones) need to be selected manually.

Anyway, with the number of Exynos boards supported in mainline, I don't think we will be ever going to enable all options for all the supported boards by default in defconfig, especially considering the fact that we will be moving to generic multi_v7_defconfig and likely dropping exynos_defconfig completely.

Well, keeping exynos_defconfig would be helpful even if exynos multiplatform is available. Please see the case of omap2plus_defconfig?

Quoted 8 lines
Quoted 3 lines

As for now, I believe you should just make sure yourself that any options relevant to your board are enabled.

Great. And I assume that there isn't a list of those options in the web. So how do I know what options are relevant to my board? By sending emails to linux-samsung-soc whenever it fails to boot?

Quoted 7 lines
Quoted 1 line

I think, we need to enable all of regarding configs for each exynos boards so that exynos_defconfig can cover whenever.

You need the following patch to mount the MMC. Without this the regulator will not be enabled which is required by MMC.

ARM: exynos_defconfig: Enable HS-I2C
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527

Yes, that's the bit that I was missing. With that patch 3.15-rc2 boots on my Arndale Octa.

Quoted 1 line

Kukjin, can you please apply this patch?

You can add my Tested-by for Arndale Octa.

Thanks!
Javi

#8 lore raw

PATCH 1/1 ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

Quoted 2 lines · Javi Merino

Hi Sachin,

Hi Sachin and Javi,

[...]

Quoted 8 lines
Quoted 2 lines

You need the following patch to mount the MMC. Without this the

regulator will

Quoted 4 lines

not be enabled which is required by MMC.

ARM: exynos_defconfig: Enable HS-I2C
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/27527

Quoted 7 lines

Yes, that's the bit that I was missing. With that patch 3.15-rc2 boots on my Arndale Octa.

Quoted 1 line

Kukjin, can you please apply this patch?

You can add my Tested-by for Arndale Octa.

OK, agreed. I will apply the enable HS-I2C on exynos_defconfig with Javi's test tag.

Thanks,
Kukjin