Skip to contentSkip to conversation

ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD

PATCH New Eric Nelson 4 participants 6 messages Apr 25, 2014 – Jun 22, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD

---
Note that this seems a bit premature until we have some infrastructure around DTB files in place, but we certainly don't want big hairy warning messages on our boards.

Is anyone planning on pulling in at least the pinfunc and .dtsi files for i.MX? I'm not sure how much else will be useful in U-Boot.

 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/nitrogen6x.h +1 -0
index f7e7315..895f36f 100644
@@ -24,6 +24,7 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 #define CONFIG_REVISION_TAG
+#define CONFIG_SYS_GENERIC_BOARD
 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * 1024 * 1024)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD

On Saturday, April 26, 2014 at 01:15:46 AM, Eric Nelson wrote:

You should learn to write sensible commit messages ;-)

Quoted 17 lines

---
Note that this seems a bit premature until we have some infrastructure around DTB files in place, but we certainly don't want big hairy warning messages on our boards.

Is anyone planning on pulling in at least the pinfunc and .dtsi files for i.MX? I'm not sure how much else will be useful in U-Boot.

 include/configs/nitrogen6x.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/nitrogen6x.h +0 -0
index f7e7315..895f36f 100644

include/configs/nitrogen6x.h line 30

Quoted 7 lines
include/configs/nitrogen6x.h +1 -0
@@ -24,6 +24,7 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_INITRD_TAG
 #define CONFIG_REVISION_TAG
+#define CONFIG_SYS_GENERIC_BOARD
 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * 1024 * 1024)

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD

Quoted 4 lines · Marek Vasut

On Saturday, April 26, 2014 at 01:15:46 AM, Eric Nelson wrote:

You should learn to write sensible commit messages ;-)

Well, the current main issue is the warning, but the subject already says what is the change. IMHO the patch is ok. I will add myself by merging the same commit message that Fabio adds for his patchset on the same issue:

Enable CONFIG_SYS_GENERIC_BOARD, so that we get rid of the following warning on
boot:

"Warning: Your board does not use generic board. Please read

doc/README.generic-board and take action. Boards not

upgraded by the late 2014 may break or be removed."

This completes the patch and address Marek's comment.

Quoted 8 lines
Quoted 8 lines

---
Note that this seems a bit premature until we have some infrastructure around DTB files in place, but we certainly don't want big hairy warning messages on our boards.

Is anyone planning on pulling in at least the pinfunc and .dtsi files for i.MX? I'm not sure how much else will be useful in U-Boot.

I have currently no projects in this direction, so personally I will not work in a short amount of time on this topic. However, I agree that the first thing for a DTS in U-Boot should be the pinmux.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 1/1 imx: nitrogen6x: Add support for GENERIC_BOARD

Enable CONFIG_SYS_GENERIC_BOARD, so that we get rid of the following warning on boot:

"Warning: Your board does not use generic board. Please read doc/README.generic-board and take action. Boards not upgraded by the late 2014 may break or be removed."

---
V2 expands on the commit message as requested by Mark and suggested by Stefano.

 include/configs/nitrogen6x.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/nitrogen6x.h +2 -0
index b2b17ce..43d1971 100644
@@ -26,6 +26,8 @@
 #define CONFIG_REVISION_TAG
 #define CONFIG_SYS_GENERIC_BOARD
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * 1024 * 1024)
 
Signature · 1 line
1.9.1
#4 lore raw

PATCH v2 1/1 imx: nitrogen6x: Add support for GENERIC_BOARD

include/configs/nitrogen6x.h line 30

Quoted 8 lines · Eric Nelson
include/configs/nitrogen6x.h +2 -0
@@ -26,6 +26,8 @@
 #define CONFIG_REVISION_TAG
 #define CONFIG_SYS_GENERIC_BOARD
 
+#define CONFIG_SYS_GENERIC_BOARD
+

Looks like something went wrong here as we see
CONFIG_SYS_GENERIC_BOARD twice now :-)

#5 lore raw

PATCH v2 1/1 imx: nitrogen6x: Add support for GENERIC_BOARD

Thanks Fabio,

Quoted 8 lines · Fabio Estevam
Quoted 6 lines · Eric Nelson
include/configs/nitrogen6x.h +0 -0
@@ -26,6 +26,8 @@
 #define CONFIG_REVISION_TAG
 #define CONFIG_SYS_GENERIC_BOARD
 
Quoted 6 lines

include/configs/nitrogen6x.h line 30

Quoted 2 lines
include/configs/nitrogen6x.h +2 -0
+#define CONFIG_SYS_GENERIC_BOARD
+

Looks like something went wrong here as we see
CONFIG_SYS_GENERIC_BOARD twice now :-)

I guess that's what I get for looking in Patchwork to see the status instead of the code!

Regards,

Eric