Skip to contentSkip to conversation

bridge: Superfluous skb->nfct check in br_nf_dev_queue_xmit

PATCH New Vasily Averin 1 participant 1 message Apr 28, 2014

Subsystems (3)
Networking netfilter Ethernet bridge
lore
Share & tools
lore

Vasily Averin

author
#0 lore raw

PATCH v2 1/1 bridge: Superfluous skb->nfct check in br_nf_dev_queue_xmit

Currently bridge silently drops defragmented ipv4 packets if nf_conntrack module is not loaded on the node. However ipv4 fragmentation and defragmentation does not require enabled connection tracking.

Removing superfluous skb->nfct check allows to re-fragment previously defragmented packets and give them chance to reach destination side.

v2: removed #if IS_ENABLED(CONFIG_NF_CONNTRACK_IPV4) added because of using of nfct check

Signed-off-by Vasily Averin <[email protected]>
---
 net/bridge/br_netfilter.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
net/bridge/br_netfilter.c +1 -8
index 80e1b0f..d50c154 100644
@@ -859,12 +859,11 @@ static unsigned int br_nf_forward_arp(const struct nf_hook_ops *ops,
 	return NF_STOLEN;
 }
 
-#if IS_ENABLED(CONFIG_NF_CONNTRACK_IPV4)
 static int br_nf_dev_queue_xmit(struct sk_buff *skb)
 {
 	int ret;
 
-	if (skb->nfct != NULL && skb->protocol == htons(ETH_P_IP) &&
+	if (skb->protocol == htons(ETH_P_IP) &&
 	    skb->len + nf_bridge_mtu_reduction(skb) > skb->dev->mtu &&
 	    !skb_is_gso(skb)) {
 		if (br_parse_ip_options(skb))

@@ -876,12 +875,6 @@ static int br_nf_dev_queue_xmit(struct sk_buff *skb)
 
 	return ret;
 }
-#else
-static int br_nf_dev_queue_xmit(struct sk_buff *skb)
-{
-        return br_dev_queue_push_xmit(skb);
-}
-#endif
 
 /* PF_BRIDGE/POST_ROUTING ********************************************/
 static unsigned int br_nf_post_routing(const struct nf_hook_ops *ops,
Signature · 1 line
1.7.5.4