ARM: exynos: remove the unused code
PATCH 1/1 ARM: exynos: remove the unused code
"mmc boot" command didn't use anywhere.
It can be replaced to "mmc dev" command.
Signed-off-by Jaehoon Chung <[email protected]>
--- include/configs/s5pc210_universal.h | 7 ++----- include/configs/trats.h | 7 ++----- include/configs/trats2.h | 11 +++-------- 3 files changed, 7 insertions(+), 18 deletions(-)
include/configs/s5pc210_universal.h +2 -5
@@ -111,12 +111,9 @@"onenand write 0x41008000 0xc00000 0x500000\0" \"bootk=" \"run loaduimage; bootm 0x40007FC0\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \
include/configs/trats.h +2 -5
@@ -121,12 +121,9 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \
include/configs/trats2.h +3 -8
@@ -111,16 +111,11 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0x42100000 0 0x200;" \ -" mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0x52100000 0 0x800;" \ +" mmc dev 0 0\0" \"updatebootb=" \ -"mmc read 0x51000000 0x80 0x200; run updatebackup\0" \ -"updateuboot=" \ -"mmc write 0x50000000 0x80 0x400\0" \ +"mmc read 0x51000000 0x80 0x800; run updatebackup\0" \"mmcboot=" \"setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \"${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: exynos: remove the unused code
Hello Jaehoon,
Quoted 59 lines · Jaehoon Chung
"mmc boot" command didn't use anywhere.
It can be replaced to "mmc dev" command.Signed-off-by Jaehoon Chung <[email protected]>--- include/configs/s5pc210_universal.h | 7 ++----- include/configs/trats.h | 7 ++----- include/configs/trats2.h | 11 +++-------- 3 files changed, 7 insertions(+), 18 deletions(-)include/configs/s5pc210_universal.h +2
-5@@ -111,12 +111,9 @@"onenand write 0x41008000 0xc00000 0x500000\0" \"bootk=" \"run loaduimage; bootm 0x40007FC0\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \include/configs/trats.h +2
-5@@ -121,12 +121,9 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \include/configs/trats2.h +0
-3@@ -111,16 +111,11 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \
include/configs/trats2.h line 118
Quoted 10 lines
include/configs/trats2.h +3
-5"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0x42100000 0 0x200;" \ -" mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0x52100000 0 0x800;" \ +" mmc dev 0 0\0" \"updatebootb=" \ -"mmc read 0x51000000 0x80 0x200; run updatebackup\0" \ -"updateuboot=" \ -"mmc write 0x50000000 0x80 0x400\0" \ +"mmc read 0x51000000 0x80 0x800; run updatebackup\0" \
Are you sure that this works fine?
You load u-boot at 0x51... and then in updatebackup you write it to mmc from another address (0x521...), so it's probably by mistake.
include/configs/trats2.h line 121
Quoted 4 lines
include/configs/trats2.h +0
-0"mmcboot=" \"setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \"${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \
Thanks
Signature · 4 lines
Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com
PATCH 1/1 ARM: exynos: remove the unused code
Hi, Przemyslaw.
Quoted 66 lines · Przemyslaw Marczak
Hello Jaehoon,
Quoted 63 lines · Jaehoon Chung
"mmc boot" command didn't use anywhere.
It can be replaced to "mmc dev" command.Signed-off-by Jaehoon Chung <[email protected]>--- include/configs/s5pc210_universal.h | 7 ++----- include/configs/trats.h | 7 ++----- include/configs/trats2.h | 11 +++-------- 3 files changed, 7 insertions(+), 18 deletions(-)include/configs/s5pc210_universal.h +2
-5@@ -111,12 +111,9 @@"onenand write 0x41008000 0xc00000 0x500000\0" \"bootk=" \"run loaduimage; bootm 0x40007FC0\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \include/configs/trats.h +2
-5@@ -121,12 +121,9 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \ +"mmc dev 0 0\0" \"updatebootb=" \"mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \"lpj=lpj=3981312\0" \include/configs/trats2.h +1
-5@@ -111,16 +111,11 @@"bootm 0x40007FC0 - ${fdtaddr};" \"fi;" \"bootm 0x40007FC0;\0" \ -"updatemmc=" \ -"mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200;" \ -"mmc boot 0 1 1 0\0" \"updatebackup=" \ -"mmc boot 0 1 1 2; mmc write 0x42100000 0 0x200;" \ -" mmc boot 0 1 1 0\0" \ +"mmc dev 0 2; mmc write 0x52100000 0 0x800;" \
Quoted 8 lines
include/configs/trats2.h line 118
Quoted 6 lines
include/configs/trats2.h +2
-3+" mmc dev 0 0\0" \"updatebootb=" \ -"mmc read 0x51000000 0x80 0x200; run updatebackup\0" \ -"updateuboot=" \ -"mmc write 0x50000000 0x80 0x400\0" \ +"mmc read 0x51000000 0x80 0x800; run updatebackup\0" \Are you sure that this works fine?
You load u-boot at0x51... and then in updatebackup you write it to mmc from another address (0x521...), so it's probably by mistake.
It's my mistake. You're right. it's wrong. :)
I will fix it. Thanks!
Best Regards,
Jaehoon Chung
Quoted 7 lines
include/configs/trats2.h line 121
Quoted 5 lines
include/configs/trats2.h +0
-0"mmcboot=" \"setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \"${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \Thanks