common: image: Allow mkimage to build a uImage for extensa
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
From: Fabio Estevam <[email protected]>
Currently we get the following failure when trying to build a uImage for extensa:
$ ./tools/mkimage -A xtensa
Invalid CPU Type - valid names are: alpha, arm, x86, ia64, m68k, microblaze, mips, mips64, nios2, powerpc, ppc, s390, sh, sparc, sparc64, blackfin, avr32, nds32, or1k, sandbox, arm64
Add an entry for extensa so that a uImage can be built.
--- common/image.c | 1 + include/image.h | 1 + 2 files changed, 2 insertions(+)
common/image.c +1 -0
@@ -83,6 +83,7 @@ static const table_entry_t uimage_arch[] = { { IH_ARCH_SANDBOX, "sandbox", "Sandbox", }, { IH_ARCH_ARM64, "arm64", "AArch64", }, { IH_ARCH_ARC, "arc", "ARC", }, + { IH_ARCH_EXTENSA, "extensa", "EXTENSA", }, { -1, "", "", }, };
include/image.h +1 -0
@@ -158,6 +158,7 @@ struct lmb;#define IH_ARCH_OPENRISC 21/* OpenRISC 1000 */ #define IH_ARCH_ARM64 22/* ARM64 */ #define IH_ARCH_ARC 23/* Synopsys DesignWare ARC */ +#define IH_ARCH_EXTENSA 24/* Extensa */ /* * Image Types
Signature · 1 line
1.8.3.2
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Hi Fabio,
Thanks for the patch, but the name is actually 'xtensa' (without the 'e'). Would be great if you could change that.
Thanks,
-Chris
Quoted 44 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently we get the following failure when trying to build a uImage for extensa:
$ ./tools/mkimage -A xtensaInvalid CPU Type - valid names are: alpha, arm, x86, ia64, m68k, microblaze, mips, mips64, nios2, powerpc, ppc, s390, sh, sparc, sparc64, blackfin, avr32, nds32, or1k, sandbox, arm64
Add an entry for extensa so that a uImage can be built.
Reported-by Geert Uytterhoeven <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- common/image.c | 1 + include/image.h | 1 + 2 files changed, 2 insertions(+)common/image.c +1
-0@@ -83,6 +83,7 @@ static const table_entry_t uimage_arch[] = { { IH_ARCH_SANDBOX, "sandbox", "Sandbox", }, { IH_ARCH_ARM64, "arm64", "AArch64", }, { IH_ARCH_ARC, "arc", "ARC", }, + { IH_ARCH_EXTENSA, "extensa", "EXTENSA", }, { -1, "", "", }, };include/image.h +1
-0@@ -158,6 +158,7 @@ struct lmb;#define IH_ARCH_OPENRISC 21/* OpenRISC 1000 */ #define IH_ARCH_ARM64 22/* ARM64 */ #define IH_ARCH_ARC 23/* Synopsys DesignWare ARC */ +#define IH_ARCH_EXTENSA 24/* Extensa */ /* * Image Types
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
In reply to Fabio EstevamDear Fabio Estevam,
Quoted 6 lines · In message <[email protected]> you wrote:
From: Fabio Estevam <[email protected]>
Currently we get the following failure when trying to build a uImage for extensa:
$ ./tools/mkimage -A xtensa
...
common/image.c static const table_entry_t uimage_arch[] = { · line 86
Quoted 1 line
common/image.c +1
-0+ { IH_ARCH_EXTENSA, "extensa", "EXTENSA", },
Is this "xtensa" or "extensa"?
And which actual architecture would that be? I cannot find any architecture support for xtensa in U-Boot mainline, so why should we add image support for it?
If you plan to add support for this architecture, then please submit this patch as part of the series that adds such architecture support.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Your own mileage may vary.
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Quoted 5 lines · Wolfgang Denk
Dear Fabio Estevam,
Quoted 2 lines · In message <[email protected]> you wrote:
From: Fabio Estevam <[email protected]>
Quoted 8 lines
Quoted 4 lines
Currently we get the following failure when trying to build a uImage for extensa:
$ ./tools/mkimage -A xtensa...
Quoted 1 line
+ {
IH_ARCH_EXTENSA, "extensa", "EXTENSA", },Is this "xtensa" or "extensa"?
It is xtensa, sorry.
Quoted 7 lines
And which actual architecture would that be? I cannot find any architecture support for xtensa in U-Boot mainline, so why should we add image support for it?
If you plan to add support for this architecture, then please submit this patch as part of the series that adds such architecture support.
Ok, understood.
Looks like the quick fix is for Michael/Geert do not build uImage for xtensa on their automated build environments.
Regards,
Fabio Estevam
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Dear Fabio,
Quoted 3 lines · In message <CAOMZO5BozLxi65cknttwu2hA0OGy_N=VZBbwm7_WWMaRBbKK6w@mail.gmail.com>…
Looks like the quick fix is for Michael/Geert do not build uImage for xtensa on their automated build environments.
What would you do with an uImage file when there is no U-Boot to load it?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Chairman was as necessary to a Board planet as the zero was in
mathematics, but being a zero had big disadvantages...
- Terry Pratchett, _The Dark Side of the Sun_PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Quoted 9 lines · Wolfgang Denk
Dear Fabio,
Quoted 3 lines · In message <CAOMZO5BozLxi65cknttwu2hA0OGy_N=VZBbwm7_WWMaRBbKK6w@mail.gmail.com>…
Looks like the quick fix is for Michael/Geert do not build uImage for xtensa on their automated build environments.
What would you do with an uImage file when there is no U-Boot to load it?
Michael's build system builds uImage for xtensa:
http://kisskb.ellerman.id.au/kisskb/buildresult/10665903/
,so it makes more sense simply not to build uImage for such architecture.
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Quoted 8 lines · Fabio Estevam
Quoted 7 lines · Wolfgang Denk
Dear Fabio,
Quoted 3 lines · In message <CAOMZO5BozLxi65cknttwu2hA0OGy_N=VZBbwm7_WWMaRBbKK6w@mail.gmail.com>…
Looks like the quick fix is for Michael/Geert do not build uImage for xtensa on their automated build environments.
Quoted 7 lines
Quoted 2 lines
What would you do with an uImage file when there is no U-Boot to load it?
Michael's build system builds uImage for xtensa:
http://kisskb.ellerman.id.au/kisskb/buildresult/10665903/so it makes more sense simply not to build uImage for such architecture.
It just runs "make".
The decision about building a uImage must be in the .config somewhere.
This failure is for allnoconfig, so presumably there is something like a CONFIG_DONT_BUILD_UIMAGE which is getting set to n by allnoconfig. If you can tell me what that option is I can force it back on (I think).
cheers
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
Quoted 7 lines · Michael Ellerman
It just runs "make".
The decision about building a uImage must be in the .config somewhere.
This failure is for allnoconfig, so presumably there is something like a
CONFIG_DONT_BUILD_UIMAGEwhich is getting set to n by allnoconfig. If you can tell me what that option is I can force it back on (I think).
It seems that xtensa uses an out of tree U-boot port then.
Chris mentioned that he plans to upstream xtensa u-boot support.
arch/xtensa/boot/boot-uboot/Makefile does force the uImage to be generated.
PATCH 1/1 common: image: Allow mkimage to build a uImage for extensa
In reply to Wolfgang DenkHi,
I have a port for the Xtensa architecture ready, and it would be great if you could include it in the mainline tree. I still have to finish another project, but could start sending patches for RFC to this mailing list in a week or two.
Thanks,
-Chris
Quoted 12 lines · Wolfgang Denk
Dear Fabio,
Quoted 2 lines · In message <CAOMZO5BozLxi65cknttwu2hA0OGy_N=VZBbwm7_WWMaRBbKK6w@mail.gmail.com>…
Looks like the quick fix is for Michael/Geert do not build uImage for xtensa on their automated build environments.
What would you do with an uImage file when there is no U-Boot to load it?
Best regards,
Wolfgang Denk