target-finalize: avoid stripping kernel modules with incorrect permissions
PATCH 1/1 target-finalize: avoid stripping kernel modules with incorrect permissions
If a kernel module is installed with incorrect permissions (0755 iso 0644), it would get stripped in a way that would render the kernel module broken. While the incorrect permissions are a developer error, it is a minor change to prevent this mistake from causing incorrectly stripped modules.
This was reported with bug #6992:
https://bugs.busybox.net/show_bug.cgi?id=6992
--- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
@@ -507,7 +507,7 @@ ifneq (,$(call qstrip,$(BR2_STRIP_EXCLUD STRIP_FIND_CMD += \( $(call finddirclauses,$(TARGET_DIR),$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS))) \) -prune -o endif STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) -STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print +STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* *.ko $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print $(TARGETS_ROOTFS): target-finalize
PATCH 1/1 target-finalize: avoid stripping kernel modules with incorrect permissions
Quoted 9 lines · Thomas De Schampheleire
If a kernel module is installed with incorrect permissions (0755 iso 0644), it would get stripped in a way that would render the kernel module broken. While the incorrect permissions are a developer error, it is a minor change to prevent this mistake from causing incorrectly stripped modules.
This was reported with bug #6992:
https://bugs.busybox.net/show_bug.cgi?id=6992Signed-off-by Thomas De Schampheleire <[email protected]>
Quoted 9 lines
--- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile ifneq (,$(call qstrip,$(BR2_STRIP_EXCLUD · line 510
Quoted 5 lines
Makefile +1
-1@@ -507,7 +507,7 @@ ifneq (,$(call qstrip,$(BR2_STRIP_EXCLUD STRIP_FIND_CMD += \( $(call finddirclauses,$(TARGET_DIR),$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS))) \) -prune -o endif STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \) -STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print +STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* *.ko $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print
The *.ko is a bit lost between the others, so maybe add a comment to
explain why libpthread*.so* and *.ko are excluded.
But that's optional and may be a separate patch, hence my Ack on this
one already.
Regards,
Arnout
Quoted 8 lines
Makefile +0
-0$(TARGETS_ROOTFS): target-finalize_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F