Skip to contentSkip to conversation

osm_console_io.c: Handle return value of function setsockopt

PATCH New Hal Rosenstock 1 participant 1 message Apr 30, 2014 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 osm_console_io.c: Handle return value of function setsockopt

From: Tomer Cohen <tomerco-VPRAkNaXOzVWk0Htik3J/[email protected]>

Found by Coverity

---
 opensm/osm_console_io.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
opensm/osm_console_io.c +9 -2
index dfc903f..2426b84 100644
@@ -208,8 +208,15 @@ int osm_console_init(osm_subn_opt_t * opt, osm_console_t * p_oct, osm_log_t * p_
 				strerror(errno));
 			return -1;
 		}
-		setsockopt(p_oct->socket, SOL_SOCKET, SO_REUSEADDR,
-			   &optval, sizeof(optval));
+
+		if (setsockopt(p_oct->socket, SOL_SOCKET, SO_REUSEADDR,
+			       &optval, sizeof(optval))) {
+			OSM_LOG(p_log, OSM_LOG_ERROR,
+		                "ERR 4B06: Failed to set socket option: %s\n",
+		                strerror(errno));
+		        return -1;
+		}
+
 		sin.sin_family = AF_INET;
 		sin.sin_port = htons(opt->console_port);
 #ifdef ENABLE_OSM_CONSOLE_SOCKET
Signature · 6 lines
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html