randconfig failures - MMC + trusted foundations

The setup_max_cpu variable is only defined if CONFIG_SMP is set. Add a preprocessor condition to avoid the following compilation error if CONFIG_SMP is not set:

arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)

Reported-by Russell King <[email protected]>

Signed-off-by Alexandre Courbot <[email protected]>

---
Hi Russell,

This should take care of the trusted foundations issue. Thanks for reporting this.

 arch/arm/include/asm/trusted_foundations.h | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/include/asm/trusted_foundations.h +2 -1

index b5f7705..624e1d4 100644
@@ -54,7 +54,9 @@ static inline void register_trusted_foundations(
         */
        pr_err("No support for Trusted Foundations, continuing in degraded mode.\n");
        pr_err("Secondary processors as well as CPU PM will be disabled.\n");
+#if IS_ENABLED(CONFIG_SMP)
        setup_max_cpus = 0;
+#endif
        cpu_idle_poll_ctrl(true);
 }
 
--

1.9.2

Quoted 12 lines · Alexandre Courbot

The setup_max_cpu variable is only defined if CONFIG_SMP is set. Add a preprocessor condition to avoid the following compilation error if CONFIG_SMP is not set:

arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)

Reported-by Russell King <[email protected]>

Signed-off-by Alexandre Courbot <[email protected]>

---
Hi Russell,

Quoted 1 line

This should take care of the trusted foundations issue. Thanks for reporting this.

Russell,

Do you mind taking this into your tree? Or do you prefer if the Tegra folks do it?

Quoted 13 lines · Alexandre Courbot

Quoted 12 lines · Alexandre Courbot

The setup_max_cpu variable is only defined if CONFIG_SMP is set. Add a preprocessor condition to avoid the following compilation error if CONFIG_SMP is not set:

arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)

Reported-by Russell King <[email protected]>

Signed-off-by Alexandre Courbot <[email protected]>

---
Hi Russell,

Quoted 6 lines

Quoted 1 line

This should take care of the trusted foundations issue. Thanks for reporting this.

Russell,

Do you mind taking this into your tree? Or do you prefer if the Tegra folks do it?

I /think/ that Russell prefers to pick patches up from his patch tracker:

http://www.arm.linux.org.uk/developer/patches/

and instructions:
http://www.arm.linux.org.uk/developer/patches/info.php

If you add it there and he objects, I expect he'll let you know:-)

Last night's omap4430-sdp randconfig build:

In file included from arch/arm/mach-tegra/tegra.c:43:0:
arch/arm/include/asm/trusted_foundations.h: In function 'register_trusted_foundations':
arch/arm/include/asm/trusted_foundations.h:57:2: error: 'setup_max_cpus' undeclared (first use in this function)

Last night's versatile randconfig build:

drivers/mmc/core/core.c: In function 'mmc_card_power_up':
drivers/mmc/core/core.c:1517:4: error: implicit declaration of function 'gpiod_set_value'

This one appears to be a regular feature of failure, and is as I'm carrying Olof's "mmc: add support for power-on sequencing through DT" patch for CuBox wireless - see the 222 patch set. It probably points at something not being right with GPIO stuff.

Hi Russell,

Quoted 9 lines · Russell King - ARM Linux

Last night's versatile randconfig build:

drivers/mmc/core/core.c: In function 'mmc_card_power_up':
drivers/mmc/core/core.c:1517:4: error: implicit declaration of function 'gpiod_set_value'

This one appears to be a regular feature of failure, and is as I'm carrying Olof's "mmc: add support for power-on sequencing through DT" patch for CuBox wireless - see the 222 patch set. It probably points at something not being right with GPIO stuff.

I had a quick look at the patch and I would say this is happening because drivers/mmc/core/core.c does not include <linux/gpio/consumer.h> despite using the gpiod_* functions. The error will only happen if CONFIG_GPIOLIB is not defined. Olof, if it is not too late can you fix this in your patch series?

Quoted 14 lines · Alexandre Courbot

Hi Russell,

Quoted 9 lines · Russell King - ARM Linux

Last night's versatile randconfig build:

drivers/mmc/core/core.c: In function 'mmc_card_power_up':
drivers/mmc/core/core.c:1517:4: error: implicit declaration of function 'gpiod_set_value'

This one appears to be a regular feature of failure, and is as I'm carrying Olof's "mmc: add support for power-on sequencing through DT" patch for CuBox wireless - see the 222 patch set. It probably points at something not being right with GPIO stuff.

Quoted 5 lines

I had a quick look at the patch and I would say this is happening because drivers/mmc/core/core.c does not include <linux/gpio/consumer.h> despite using the gpiod_* functions. The error will only happen if CONFIG_GPIOLIB is not defined. Olof, if it is not too late can you fix this in your patch series?

I received a report from someone else last week (in the mmc patch series I posted) that Chris has already merged this into his mmc tree, so I think it would need to be a follow on patch.

Quoted 3 lines · Russell King - ARM Linux

I received a report from someone else last week (in the mmc patch series I posted) that Chris has already merged this into his mmc tree, so I think it would need to be a follow on patch.

Huh, I don't see the patches in mmc-next. Did they get applied somewhere else? They're not in linux-next either.

Timing is good though; I was hoping to revisit that patch set this week.