serial-getty service: Add linux as default TERM
PATCH v2 1/1 serial-getty service: Add linux as default TERM
In poky with systemd enabled, vt102 is selected for getty causing user to experience a very crappy terminal. Default TERM to linux.
---
v2: Dropped PR bump
.../systemd-serialgetty/[email protected] | 1 + 1 file changed, 1 insertion(+)
meta/recipes-core/systemd/systemd-serialgetty/[email protected] +1 -0
@@ -20,6 +20,7 @@ Before=getty.target IgnoreOnIsolate=yes [Service] +Environment="TERM=linux" ExecStart=-/sbin/agetty --keep-baud %I @BAUDRATE@ $TERM Type=idle Restart=always
Signature · 1 line
1.7.9.5
Quoted 16 lines · Joel Fernandes
In poky with systemd enabled, vt102 is selected for getty causing user to experience a very crappy terminal. Default TERM to linux.
Signed-off-by Joel Fernandes <[email protected]>---
v2: Dropped PR bump.../systemd-serialgetty/[email protected] | 1 + 1 file changed, 1 insertion(+)meta/recipes-core/systemd/systemd-serialgetty/[email protected] +0
-0
meta/recipes-core/systemd/systemd-serialgetty/[email protected] Before=getty.target · line 26
Quoted 7 lines
meta/recipes-core/systemd/systemd-serialgetty/[email protected] +1
-0@@ -20,6 +20,7 @@ Before=getty.target IgnoreOnIsolate=yes [Service] +Environment="TERM=linux" ExecStart=-/sbin/agetty --keep-baud %I @BAUDRATE@ $TERM Type=idle Restart=always
I would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
"xterm" as it is much more widely supported than "linux". Also, PuTTY uses "xterm" by default.
-8 to assume the tty is 8-bit clean and disable parity detection. I have had some issues where parity sometimes gets enabled even though the serial line is 8-bit clean and I end up with garbage on the serial terminal.
Regards,
Jonathan
Quoted 29 lines · Jonathan Liu
Quoted 18 lines · Joel Fernandes
In poky with systemd enabled, vt102 is selected for getty causing user to experience a very crappy terminal. Default TERM to linux.
Signed-off-by Joel Fernandes <[email protected]>---
v2: Dropped PR bump.../systemd-serialgetty/[email protected] | 1 + 1 file changed, 1 insertion(+)diff --git a/meta/recipes-core/systemd/systemd-serialgetty/[email protected] b/meta/recipes-core/systemd/systemd-serialgetty/[email protected] index 865de34..eb2280b 100644
meta/recipes-core/systemd/systemd-serialgetty/[email protected] Before=getty.target · line 25
Quoted 6 lines
meta/recipes-core/systemd/systemd-serialgetty/[email protected] +1
-0@@ -20,6 +20,7 @@ Before=getty.target IgnoreOnIsolate=yes [Service] +Environment="TERM=linux" ExecStart=-/sbin/agetty --keep-baud %I @BAUDRATE@ $TERM Type=idle Restart=alwaysI would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
Quoted 6 lines
"xterm" as it is much more widely supported than "linux". Also, PuTTY uses "xterm" by default.
-8 to assume the tty is 8-bit clean and disable parity detection. I have had some issues where parity sometimes gets enabled even though the serial line is 8-bit clean and I end up with garbage on the serial terminal.
Fair enough, I tested and it works fine for me. Will submit a patch.
-Joel
Quoted 3 lines · Jonathan Liu
I would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
I wonder if that would add some dependency on right terminfo being present on system ?
Quoted 8 lines · Khem Raj
Quoted 3 lines · Jonathan Liu
I would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERMI wonder if that would add some dependency on right terminfo being present on system ?
I thought about this too, I have no idea frankly, I can see that it probably would :-(
Quoted 6 lines · Joel Fernandes
Quoted 5 lines · Khem Raj
Quoted 3 lines · Jonathan Liu
I would prefer:
Environment="TERM=xterm"
ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
Quoted 7 lines
Quoted 3 lines
I wonder if that would add some dependency on right terminfo being present on system ?
I thought about this too, I have no idea frankly, I can see that it probably would :-(
Khem,
terminfo data (/usr/share/terminfo) seems to be coming from ncurses in my build. I think ncurses-terminfo-base. Not sure what the right dependency play we should be doing for this... set dependency to ncurses-terminfo-base?
by the way/lib/systemd/system/debug-shell.service
which ships with systemd already sets Environment=TERM=linux
Thanks,
-Joel
Quoted 6 lines · Joel Fernandes
Khem,
terminfo data (/usr/share/terminfo) seems to be coming from ncurses in my build. I think ncurses-terminfo-base. Not sure what the right dependency play we should be doing for this... set dependency to ncurses-terminfo-base?
adding ncurses to dependencies would do it. but that could be an overkill.
Quoted 3 lines
by the way
/lib/systemd/system/debug-shell.service
which ships with systemd already sets Environment=TERM=linux
yes this seems ok probably.
Quoted 8 lines · Khem Raj
Quoted 6 lines · Joel Fernandes
Khem,
terminfo data (/usr/share/terminfo) seems to be coming from ncurses in my build. I think ncurses-terminfo-base. Not sure what the right dependency play we should be doing for this... set dependency to ncurses-terminfo-base?
Quoted 8 lines
adding ncurses to dependencies would do it. but that could be an overkill.
Quoted 3 lines
by the way
/lib/systemd/system/debug-shell.service
which ships with systemd already sets Environment=TERM=linuxyes this seems ok probably.
Ok. I'll take that as an Ack :-D. So can you pull this patch (or someone else)?
Regards,
-Joel