rtc: add support for maxim dallas rtc ds1343 and ds1344
Quoted 12 lines
Review
Quoted 8 lines · On Wed, 30 Apr 2014 21:55:07 +0530 Raghavendra Ganiga <[email protected]>…
(quoted diff) +8
-0+static int ds1343_proc(struct device *dev, struct seq_file *seq) +{ + struct ds1343_priv *priv = dev_get_drvdata(dev); + unsigned int data; + unsigned char alarm_mode = 0; + const char *alarm_str, *diodes = "disabled", *resistors = " "; + + regmap_read(priv->map, DS1343_CONTROL_REG, &data);is this thing really useful? what about having sysfs entries instead?
i am replacing the proc interface with the sysfs entries also removing the unnecessary parameters. i am adding the following parameters as sysfs entries
1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameter
and i am removing the proc interface.
is the above implementation ok as per your last comment on the proc interface. please provide the feedback.
Thanks and regards
Raghavendra Chandra Ganiga
Quoted 9 lines · On Mon, 05 May 2014 23:46:06 +0530 RAGHAVENDRA GANIGA <[email protected]>…
1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameterand i am removing the proc interface.
is the above implementation ok as per your last comment on the proc interface. please provide the feedback.
That's sounds like a plan. Please send the code when you're ready.
Signature · 6 lines
Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it