Skip to contentSkip to conversation

pwrite/pwrite02.c: cleanup

PATCH In review Xiaoguang Wang 2 participants 2 messages May 6, 2014 – May 28, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 pwrite/pwrite02.c: cleanup

Hi,

In pwrite/pwrite03.c, there is a invalid character encoding and it causes
that "git am" failed, so I send this patch as a attachment, thanks.

Regards,
Wang

From d434449268b94176a4e5f1040d9735f312b00fb9 Mon Sep 17 00:00:00 2001
From: Xiaoguang Wang <[email protected]>
Date: Tue, 6 May 2014 09:32:58 +0800
Subject: [PATCH v2 1/2] pwrite/pwrite02.c: cleanup

Merge pwrite02, pwrite03 into one pwrite02 test, which contains ESPIPE, EINVAL, EBADF and EFAULT tests.

Remove useless comments and make use of SAFE_MACROS().

Delete some useless code and do some code re-arrangement.

printf() is not async-signal-safe, so use write(2) in signal handler directly.

---
 runtest/ltplite                             |   2 -
 runtest/stress.part3                        |   2 -
 runtest/syscalls                            |   2 -
 testcases/kernel/syscalls/.gitignore        |   2 -
 testcases/kernel/syscalls/pwrite/pwrite02.c | 322 +++++++++-------------------
 testcases/kernel/syscalls/pwrite/pwrite03.c | 211 ------------------
 6 files changed, 101 insertions(+), 440 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/pwrite/pwrite03.c
runtest/ltplite +0 -2
index ebe171e..f076c5a 100644
@@ -595,12 +595,10 @@ ptrace05 ptrace05
 
 pwrite01 pwrite01
 pwrite02 pwrite02
-pwrite03 pwrite03
 pwrite04 pwrite04
 
 pwrite01_64 pwrite01_64
 pwrite02_64 pwrite02_64
-pwrite03_64 pwrite03_64
 pwrite04_64 pwrite04_64
 
 read01 read01
runtest/stress.part3 +0 -2
index b4ad297..1ef5401 100644
@@ -505,12 +505,10 @@ ptrace03 ptrace03
 
 pwrite01 pwrite01
 pwrite02 pwrite02
-pwrite03 pwrite03
 pwrite04 pwrite04
 
 pwrite01_64 pwrite01_64
 pwrite02_64 pwrite02_64
-pwrite03_64 pwrite03_64
 pwrite04_64 pwrite04_64
 
 read01 read01
runtest/syscalls +0 -2
index fb3e59f..75017fb 100644
@@ -787,12 +787,10 @@ ptrace05 ptrace05
 
 pwrite01 pwrite01
 pwrite02 pwrite02
-pwrite03 pwrite03
 pwrite04 pwrite04
 
 pwrite01_64 pwrite01_64
 pwrite02_64 pwrite02_64
-pwrite03_64 pwrite03_64
 pwrite04_64 pwrite04_64
 
 quotactl01 quotactl01
testcases/kernel/syscalls/.gitignore +0 -2
index d5c7bac..bcbc055 100644
@@ -648,8 +648,6 @@
 /pwrite/pwrite01_64
 /pwrite/pwrite02
 /pwrite/pwrite02_64
-/pwrite/pwrite03
-/pwrite/pwrite03_64
 /pwrite/pwrite04
 /pwrite/pwrite04_64
 /quotactl/quotactl01
testcases/kernel/syscalls/pwrite/pwrite02.c +101 -221

406 lines not on this page · raw message

testcases/kernel/syscalls/pwrite/pwrite03.c deleted +0 -211

211 lines not on this page · raw message

Signature · 1 line
1.8.2.1

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

Hi!
I've silenced the unused return value from write() warnings and pushed, thanks.

Signature · 11 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list