Skip to contentSkip to conversation

i2c: zynq: Fixed compilation errors when using DEBUG

PATCH New Michal Simek 3 participants 3 messages Apr 25, 2014 – May 6, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: zynq: Fixed compilation errors when using DEBUG

From: "Jesper B. Christensen" <[email protected]>

---

 drivers/i2c/zynq_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/zynq_i2c.c +2 -2
index f1f6513..b3264af 100644
@@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
 			break;
 	}
 #ifdef DEBUG
-	zynq_i2c_debug_status(zynq_i2c));
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	/* Clear interrupt status flags */
 	writel(int_status & mask, &zynq_i2c->interrupt_status);
@@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
 	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
 
 #ifdef DEBUG
-	zynq_i2c_debug_status();
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	return 0;
 }

--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140425/caa0f6bf/attachment.pgp>

#1 lore raw

PATCH 1/1 i2c: zynq: Fixed compilation errors when using DEBUG

Hi Heiko,

Quoted 32 lines · Michal Simek

From: "Jesper B. Christensen" <[email protected]>

---

 drivers/i2c/zynq_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/zynq_i2c.c +2 -3
index f1f6513..b3264af 100644
@@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
 			break;
 	}
 #ifdef DEBUG
-	zynq_i2c_debug_status(zynq_i2c));
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	/* Clear interrupt status flags */
 	writel(int_status & mask, &zynq_i2c->interrupt_status);
@@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
 	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
 
 #ifdef DEBUG
-	zynq_i2c_debug_status();
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	return 0;
 }
--
Quoted 2 lines

1.8.2.3

Can you please add this patch to your i2c custodian repo?

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/1fb2d6d4/attachment.pgp>
#2 lore raw

PATCH 1/1 i2c: zynq: Fixed compilation errors when using DEBUG

Hello Michael,

Am 06.05.2014 13:39, schrieb Michal Simek:

Quoted 28 lines

Hi Heiko,

Quoted 25 lines · Michal Simek

From: "Jesper B. Christensen"<[email protected]>

---

  drivers/i2c/zynq_i2c.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/zynq_i2c.c +1 -1
index f1f6513..b3264af 100644
@@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
  			break;
  	}
  #ifdef DEBUG
-	zynq_i2c_debug_status(zynq_i2c));
+	zynq_i2c_debug_status(zynq_i2c);
  #endif
  	/* Clear interrupt status flags */
  	writel(int_status&  mask,&zynq_i2c->interrupt_status);
@@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
  	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
 
Quoted 11 lines
Quoted 9 lines
drivers/i2c/zynq_i2c.c +1 -2
  #ifdef DEBUG
-	zynq_i2c_debug_status();
+	zynq_i2c_debug_status(zynq_i2c);
  #endif
  	return 0;
  }
--

1.8.2.3

Can you please add this patch to your i2c custodian repo?

Added it to my ToDo list in patchwork

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany