ARM: tegra: add SD wp-gpios to Venice2 DT
Subsystems (2)
PATCH 1/1 ARM: tegra: add SD wp-gpios to Venice2 DT
From: Stephen Warren <[email protected]>
Venice2 can detect write-protect on the SD card. Add the required DT entries to allow this.
---
Thierry, could you test this for me; my Venice2 has been sent away for a few days for some rework. You should find that if you write-protect your SD card, the kernel fails/panics trying to mount it as a r/w root fs, whereas if the card is not write-protected, everything still works fine. Thanks.
--- arch/arm/boot/dts/tegra124-venice2.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/tegra124-venice2.dts +1 -0
@@ -943,6 +943,7 @@ sdhci at 0,700b0400 { cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>; power-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>; + wp-gpios = <&gpio TEGRA_GPIO(Q, 4) GPIO_ACTIVE_HIGH>; status = "okay"; bus-width = <4>; vqmmc-supply = <&vddio_sdmmc3>;
Signature · 1 line
1.8.1.5
PATCH 1/1 ARM: tegra: add SD wp-gpios to Venice2 DT
Quoted 21 lines · Stephen Warren
From: Stephen Warren <[email protected]>
Venice2 can detect write-protect on the SD card. Add the required DT entries to allow this.
Signed-off-by Stephen Warren <[email protected]>---
Thierry, could you test this for me; my Venice2 has been sent away for a few days for some rework. You should find that if you write-protect your SD card, the kernel fails/panics trying to mount it as a r/w root fs, whereas if the card is not write-protected, everything still works fine. Thanks.--- arch/arm/boot/dts/tegra124-venice2.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/tegra124-venice2.dts +0
-0
arch/arm/boot/dts/tegra124-venice2.dts line 946
Quoted 4 lines
arch/arm/boot/dts/tegra124-venice2.dts +1
-0@@ -943,6 +943,7 @@ sdhci at 0,700b0400 { cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>; power-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>; + wp-gpios = <&gpio TEGRA_GPIO(Q, 4) GPIO_ACTIVE_HIGH>;
I need to make this GPIO_ACTIVE_LOW for this to work properly on my Venice2. With that I can see the initrd reporting:
mount: /dev/mmcblk0p1 is write-protected, mounting read-only
So with that changed:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140429/b3a92f2a/attachment.sig>
PATCH 1/1 ARM: tegra: add SD wp-gpios to Venice2 DT
Quoted 17 lines · Thierry Reding
Quoted 16 lines · Stephen Warren
From: Stephen Warren <[email protected]>
Venice2 can detect write-protect on the SD card. Add the required DT entries to allow this.
Signed-off-by Stephen Warren <[email protected]>---
Thierry, could you test this for me; my Venice2 has been sent away for a few days for some rework. You should find that if you write-protect your SD card, the kernel fails/panics trying to mount it as a r/w root fs, whereas if the card is not write-protected, everything still works fine. Thanks.--- arch/arm/boot/dts/tegra124-venice2.dts | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
arch/arm/boot/dts/tegra124-venice2.dts line 946
Quoted 9 lines
arch/arm/boot/dts/tegra124-venice2.dts +1
-0@@ -943,6 +943,7 @@ sdhci at 0,700b0400 { cd-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>; power-gpios = <&gpio TEGRA_GPIO(R, 0) GPIO_ACTIVE_HIGH>; + wp-gpios = <&gpio TEGRA_GPIO(Q, 4) GPIO_ACTIVE_HIGH>;I need to make this
GPIO_ACTIVE_LOWfor this to work properly on my Venice2.
Ah yes, I need that too. The other kernel I was using as a reference evidently doesn't use the GPIO flags for inversion, but rather a separate wp-inverted property, which I hadn't noticed.
With the polarity fixed, I have applied this to Tegra's for-3.16/dt branch.