Skip to contentSkip to conversation

net-sysfs: expose permanent hardware address in sysfs

PATCH In review David Decotigny 3 participants 3 messages May 6, 2014 – May 7, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 net-sysfs: expose permanent hardware address in sysfs

Tested:
grep . /sys/class/net/*/*addr*

---
 net/core/net-sysfs.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
net/core/net-sysfs.c +15 -0
index 1cac29e..bf57024 100644
@@ -127,6 +127,20 @@ static ssize_t address_show(struct device *dev, struct device_attribute *attr,
 }
 static DEVICE_ATTR_RO(address);
 
+static ssize_t perm_addr_show(struct device *dev, struct device_attribute *attr,
+			      char *buf)
+{
+	struct net_device *net = to_net_dev(dev);
+	ssize_t ret = -EINVAL;
+
+	read_lock(&dev_base_lock);
+	if (dev_isalive(net))
+		ret = sysfs_format_mac(buf, net->perm_addr, net->addr_len);
+	read_unlock(&dev_base_lock);
+	return ret;
+}
+static DEVICE_ATTR_RO(perm_addr);
+
 static ssize_t broadcast_show(struct device *dev,
 			      struct device_attribute *attr, char *buf)
 {
@@ -391,6 +405,7 @@ static struct attribute *net_class_attrs[] = {
 	&dev_attr_addr_len.attr,
 	&dev_attr_link_mode.attr,
 	&dev_attr_address.attr,
+	&dev_attr_perm_addr.attr,
 	&dev_attr_broadcast.attr,
 	&dev_attr_speed.attr,
 	&dev_attr_duplex.attr,
Signature · 1 line
1.9.1.423.g4596e3a
#2 lore raw
Quoted 2 lines · David Decotigny

Tested:

   grep . /sys/class/net/*/*addr*

Please also include the relevant sysfs documentation changes in Documentation/ABI/testing/sysfs-class-net.

Thanks!

Quoted 40 lines
---
  net/core/net-sysfs.c | 15 +++++++++++++++
  1 file changed, 15 insertions(+)
net/core/net-sysfs.c +15 -0
index 1cac29e..bf57024 100644
@@ -127,6 +127,20 @@ static ssize_t address_show(struct device *dev, struct device_attribute *attr,
  }
  static DEVICE_ATTR_RO(address);
 
+static ssize_t perm_addr_show(struct device *dev, struct device_attribute *attr,
+			      char *buf)
+{
+	struct net_device *net = to_net_dev(dev);
+	ssize_t ret = -EINVAL;
+
+	read_lock(&dev_base_lock);
+	if (dev_isalive(net))
+		ret = sysfs_format_mac(buf, net->perm_addr, net->addr_len);
+	read_unlock(&dev_base_lock);
+	return ret;
+}
+static DEVICE_ATTR_RO(perm_addr);
+
  static ssize_t broadcast_show(struct device *dev,
  			      struct device_attribute *attr, char *buf)
  {
@@ -391,6 +405,7 @@ static struct attribute *net_class_attrs[] = {
  	&dev_attr_addr_len.attr,
  	&dev_attr_link_mode.attr,
  	&dev_attr_address.attr,
+	&dev_attr_perm_addr.attr,
  	&dev_attr_broadcast.attr,
  	&dev_attr_speed.attr,
  	&dev_attr_duplex.attr,